Re: [REVIEWv2 PATCH 12/13] vb2: start messages with a lower-case for consistency.

2014-04-09 Thread Pawel Osciak 
On Mon, Apr 7, 2014 at 10:11 PM, Hans Verkuil hverk...@xs4all.nl wrote:
 From: Hans Verkuil hans.verk...@cisco.com

 The kernel debug messages produced by vb2 started either with a
 lower or an upper case character. Switched all to use lower-case
 which seemed to be what was used in the majority of the messages.

 Signed-off-by: Hans Verkuil hans.verk...@cisco.com

Acked-by: Pawel Osciak pa...@osciak.com

 ---
  drivers/media/v4l2-core/videobuf2-core.c | 58 
 
  1 file changed, 29 insertions(+), 29 deletions(-)

 diff --git a/drivers/media/v4l2-core/videobuf2-core.c 
 b/drivers/media/v4l2-core/videobuf2-core.c
 index d33c69b..e79d70c 100644
 --- a/drivers/media/v4l2-core/videobuf2-core.c
 +++ b/drivers/media/v4l2-core/videobuf2-core.c
 @@ -151,7 +151,7 @@ static void __vb2_buf_mem_free(struct vb2_buffer *vb)
 for (plane = 0; plane  vb-num_planes; ++plane) {
 call_memop(vb, put, vb-planes[plane].mem_priv);
 vb-planes[plane].mem_priv = NULL;
 -   dprintk(3, Freed plane %d of buffer %d\n, plane,
 +   dprintk(3, freed plane %d of buffer %d\n, plane,
 vb-v4l2_buf.index);
 }
  }
 @@ -246,7 +246,7 @@ static void __setup_offsets(struct vb2_queue *q, unsigned 
 int n)
 for (plane = 0; plane  vb-num_planes; ++plane) {
 vb-v4l2_planes[plane].m.mem_offset = off;

 -   dprintk(3, Buffer %d, plane %d offset 0x%08lx\n,
 +   dprintk(3, buffer %d, plane %d offset 0x%08lx\n,
 buffer, plane, off);

 off += vb-v4l2_planes[plane].length;
 @@ -273,7 +273,7 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum 
 v4l2_memory memory,
 /* Allocate videobuf buffer structures */
 vb = kzalloc(q-buf_struct_size, GFP_KERNEL);
 if (!vb) {
 -   dprintk(1, Memory alloc for buffer struct failed\n);
 +   dprintk(1, memory alloc for buffer struct failed\n);
 break;
 }

 @@ -292,7 +292,7 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum 
 v4l2_memory memory,
 if (memory == V4L2_MEMORY_MMAP) {
 ret = __vb2_buf_mem_alloc(vb);
 if (ret) {
 -   dprintk(1, Failed allocating memory for 
 +   dprintk(1, failed allocating memory for 
 buffer %d\n, buffer);
 kfree(vb);
 break;
 @@ -304,7 +304,7 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum 
 v4l2_memory memory,
  */
 ret = call_vb_qop(vb, buf_init, vb);
 if (ret) {
 -   dprintk(1, Buffer %d %p initialization
 +   dprintk(1, buffer %d %p initialization
  failed\n, buffer, vb);
 fail_vb_qop(vb, buf_init);
 __vb2_buf_mem_free(vb);
 @@ -320,7 +320,7 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum 
 v4l2_memory memory,
 if (memory == V4L2_MEMORY_MMAP)
 __setup_offsets(q, buffer);

 -   dprintk(1, Allocated %d buffers, %d plane(s) each\n,
 +   dprintk(1, allocated %d buffers, %d plane(s) each\n,
 buffer, num_planes);

 return buffer;
 @@ -477,13 +477,13 @@ static int __verify_planes_array(struct vb2_buffer *vb, 
 const struct v4l2_buffer

 /* Is memory for copying plane information present? */
 if (NULL == b-m.planes) {
 -   dprintk(1, Multi-planar buffer passed but 
 +   dprintk(1, multi-planar buffer passed but 
planes array not provided\n);
 return -EINVAL;
 }

 if (b-length  vb-num_planes || b-length  VIDEO_MAX_PLANES) {
 -   dprintk(1, Incorrect planes array length, 
 +   dprintk(1, incorrect planes array length, 
expected %d, got %d\n, vb-num_planes, 
 b-length);
 return -EINVAL;
 }
 @@ -847,7 +847,7 @@ static int __reqbufs(struct vb2_queue *q, struct 
 v4l2_requestbuffers *req)
 /* Finally, allocate buffers and video memory */
 allocated_buffers = __vb2_queue_alloc(q, req-memory, num_buffers, 
 num_planes);
 if (allocated_buffers == 0) {
 -   dprintk(1, Memory allocation failed\n);
 +   dprintk(1, memory allocation failed\n);
 return -ENOMEM;
 }

 @@ -960,7 +960,7 @@ static int __create_bufs(struct vb2_queue *q, struct 
 v4l2_create_buffers *create
 allocated_buffers = __vb2_queue_alloc(q, create-memory,

[REVIEWv2 PATCH 12/13] vb2: start messages with a lower-case for consistency.

2014-04-07 Thread Hans Verkuil 
From: Hans Verkuil hans.verk...@cisco.com

The kernel debug messages produced by vb2 started either with a
lower or an upper case character. Switched all to use lower-case
which seemed to be what was used in the majority of the messages.

Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
 drivers/media/v4l2-core/videobuf2-core.c | 58 
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/drivers/media/v4l2-core/videobuf2-core.c 
b/drivers/media/v4l2-core/videobuf2-core.c
index d33c69b..e79d70c 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -151,7 +151,7 @@ static void __vb2_buf_mem_free(struct vb2_buffer *vb)
for (plane = 0; plane  vb-num_planes; ++plane) {
call_memop(vb, put, vb-planes[plane].mem_priv);
vb-planes[plane].mem_priv = NULL;
-   dprintk(3, Freed plane %d of buffer %d\n, plane,
+   dprintk(3, freed plane %d of buffer %d\n, plane,
vb-v4l2_buf.index);
}
 }
@@ -246,7 +246,7 @@ static void __setup_offsets(struct vb2_queue *q, unsigned 
int n)
for (plane = 0; plane  vb-num_planes; ++plane) {
vb-v4l2_planes[plane].m.mem_offset = off;
 
-   dprintk(3, Buffer %d, plane %d offset 0x%08lx\n,
+   dprintk(3, buffer %d, plane %d offset 0x%08lx\n,
buffer, plane, off);
 
off += vb-v4l2_planes[plane].length;
@@ -273,7 +273,7 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum 
v4l2_memory memory,
/* Allocate videobuf buffer structures */
vb = kzalloc(q-buf_struct_size, GFP_KERNEL);
if (!vb) {
-   dprintk(1, Memory alloc for buffer struct failed\n);
+   dprintk(1, memory alloc for buffer struct failed\n);
break;
}
 
@@ -292,7 +292,7 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum 
v4l2_memory memory,
if (memory == V4L2_MEMORY_MMAP) {
ret = __vb2_buf_mem_alloc(vb);
if (ret) {
-   dprintk(1, Failed allocating memory for 
+   dprintk(1, failed allocating memory for 
buffer %d\n, buffer);
kfree(vb);
break;
@@ -304,7 +304,7 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum 
v4l2_memory memory,
 */
ret = call_vb_qop(vb, buf_init, vb);
if (ret) {
-   dprintk(1, Buffer %d %p initialization
+   dprintk(1, buffer %d %p initialization
 failed\n, buffer, vb);
fail_vb_qop(vb, buf_init);
__vb2_buf_mem_free(vb);
@@ -320,7 +320,7 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum 
v4l2_memory memory,
if (memory == V4L2_MEMORY_MMAP)
__setup_offsets(q, buffer);
 
-   dprintk(1, Allocated %d buffers, %d plane(s) each\n,
+   dprintk(1, allocated %d buffers, %d plane(s) each\n,
buffer, num_planes);
 
return buffer;
@@ -477,13 +477,13 @@ static int __verify_planes_array(struct vb2_buffer *vb, 
const struct v4l2_buffer
 
/* Is memory for copying plane information present? */
if (NULL == b-m.planes) {
-   dprintk(1, Multi-planar buffer passed but 
+   dprintk(1, multi-planar buffer passed but 
   planes array not provided\n);
return -EINVAL;
}
 
if (b-length  vb-num_planes || b-length  VIDEO_MAX_PLANES) {
-   dprintk(1, Incorrect planes array length, 
+   dprintk(1, incorrect planes array length, 
   expected %d, got %d\n, vb-num_planes, b-length);
return -EINVAL;
}
@@ -847,7 +847,7 @@ static int __reqbufs(struct vb2_queue *q, struct 
v4l2_requestbuffers *req)
/* Finally, allocate buffers and video memory */
allocated_buffers = __vb2_queue_alloc(q, req-memory, num_buffers, 
num_planes);
if (allocated_buffers == 0) {
-   dprintk(1, Memory allocation failed\n);
+   dprintk(1, memory allocation failed\n);
return -ENOMEM;
}
 
@@ -960,7 +960,7 @@ static int __create_bufs(struct vb2_queue *q, struct 
v4l2_create_buffers *create
allocated_buffers = __vb2_queue_alloc(q, create-memory, num_buffers,
num_planes);
if (allocated_buffers == 0) {
-   dprintk(1, Memory allocation failed\n);
+   dprintk(1, memory allocation