Re: [PATCH 2/2] ipu3-cio2: Use cio2_queues_exit

2018-10-13 Thread Sakari Ailus 
On Thu, Oct 11, 2018 at 05:16:30PM +0800, Bing Bu Cao wrote:
> Tested-by: Bingbu Cao 
> Reviewed-by: Bingbu Cao 

Thanks!!

-- 
Sakari Ailus
sakari.ai...@linux.intel.com

Re: [PATCH 2/2] ipu3-cio2: Use cio2_queues_exit

2018-10-11 Thread Bing Bu Cao 
Tested-by: Bingbu Cao 
Reviewed-by: Bingbu Cao 

On 10/10/2018 04:32 PM, Sakari Ailus wrote:
> The ipu3-cio2 driver has a function to tear down video devices as well as
> the associated video buffer queues. Use it.
>
> Signed-off-by: Sakari Ailus 
> ---
>  drivers/media/pci/intel/ipu3/ipu3-cio2.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c 
> b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index 723022ef3662..447baaebca44 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -1844,12 +1844,10 @@ static int cio2_pci_probe(struct pci_dev *pci_dev,
>  static void cio2_pci_remove(struct pci_dev *pci_dev)
>  {
>   struct cio2_device *cio2 = pci_get_drvdata(pci_dev);
> - unsigned int i;
>  
>   media_device_unregister(>media_dev);
>   cio2_notifier_exit(cio2);
> - for (i = 0; i < CIO2_QUEUES; i++)
> - cio2_queue_exit(cio2, >queue[i]);
> + cio2_queues_exit(cio2);
>   cio2_fbpt_exit_dummy(cio2);
>   v4l2_device_unregister(>v4l2_dev);
>   media_device_cleanup(>media_dev);

[PATCH 2/2] ipu3-cio2: Use cio2_queues_exit

2018-10-10 Thread Sakari Ailus 
The ipu3-cio2 driver has a function to tear down video devices as well as
the associated video buffer queues. Use it.

Signed-off-by: Sakari Ailus 
---
 drivers/media/pci/intel/ipu3/ipu3-cio2.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c 
b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
index 723022ef3662..447baaebca44 100644
--- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
+++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
@@ -1844,12 +1844,10 @@ static int cio2_pci_probe(struct pci_dev *pci_dev,
 static void cio2_pci_remove(struct pci_dev *pci_dev)
 {
struct cio2_device *cio2 = pci_get_drvdata(pci_dev);
-   unsigned int i;
 
media_device_unregister(>media_dev);
cio2_notifier_exit(cio2);
-   for (i = 0; i < CIO2_QUEUES; i++)
-   cio2_queue_exit(cio2, >queue[i]);
+   cio2_queues_exit(cio2);
cio2_fbpt_exit_dummy(cio2);
v4l2_device_unregister(>v4l2_dev);
media_device_cleanup(>media_dev);
-- 
2.11.0