Re: compat.h required to build
On Fri, Aug 21, 2009 at 12:34 PM, Andy Walls wrote: > DIV_ROUND_CLOSEST is probably available only in more recent kernels. > When its use was added to those files, backward compatability was likely > not tested. Including compat.h is the proper thing to do. > > Regards, > Andy I'm pretty sure Mauro just added the macro to compat.h yesterday (and I can only assume he missed a couple of includes). Lou, feel free to submit a patch with the extra includes, including an SOB. Thanks, Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: compat.h required to build
On Fri, 2009-08-21 at 17:02 +0100, Lou Otway wrote: > Hi, > > The following files: > > /linux/drivers/media/dvb/frontends/stb6100.c > /linux/drivers/media/dvb/frontends/tda10021.c > /linux/drivers/media/dvb/frontends/ves1820.c > > Fail to build with: > > error: implicit declaration of function 'DIV_ROUND_CLOSEST' > > and need the addition of: > > #include "compat.h" > > when building on my system. Is this related to my kernel version > (2.6.28) or is it something else? DIV_ROUND_CLOSEST is probably available only in more recent kernels. When its use was added to those files, backward compatability was likely not tested. Including compat.h is the proper thing to do. Regards, Andy > Thanks, > > Lou > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
compat.h required to build
Hi, The following files: /linux/drivers/media/dvb/frontends/stb6100.c /linux/drivers/media/dvb/frontends/tda10021.c /linux/drivers/media/dvb/frontends/ves1820.c Fail to build with: error: implicit declaration of function 'DIV_ROUND_CLOSEST' and need the addition of: #include "compat.h" when building on my system. Is this related to my kernel version (2.6.28) or is it something else? Thanks, Lou -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
