Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot

2014-04-18 Thread Tony Lindgren 
* Tomi Valkeinen  [140408 23:31]:
> On 08/04/14 23:51, Sebastian Reichel wrote:
> > Do not try to initialize display for DT boot, since omapdss
> > is now initialized via Device Tree. Without this patch the
> > display subsystem does not properly come up.
> > 
> > Signed-off-by: Sebastian Reichel 
> > ---
> > Hi,
> > 
> > This patch should be added to 3.15-rc to make display initialization via DT
> > possible. Sorry for not noticing earlier, that this was missing in Tomi's
> > patchset.
> > 
> > -- Sebastian
> > ---
> >  arch/arm/mach-omap2/board-rx51-video.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-omap2/board-rx51-video.c 
> > b/arch/arm/mach-omap2/board-rx51-video.c
> > index 43a90c8..9cfebc5 100644
> > --- a/arch/arm/mach-omap2/board-rx51-video.c
> > +++ b/arch/arm/mach-omap2/board-rx51-video.c
> > @@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
> >  
> >  static int __init rx51_video_init(void)
> >  {
> > -   if (!machine_is_nokia_rx51() && 
> > !of_machine_is_compatible("nokia,omap3-n900"))
> > +   if (!machine_is_nokia_rx51())
> > return 0;
> >  
> > if (omap_mux_init_gpio(RX51_LCD_RESET_GPIO, OMAP_PIN_OUTPUT)) {
> > 
> 
> Acked-by: Tomi Valkeinen 

Applying into omap-for-v3.15/fixes thanks.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot

2014-04-08 Thread Tomi Valkeinen 
On 08/04/14 23:51, Sebastian Reichel wrote:
> Do not try to initialize display for DT boot, since omapdss
> is now initialized via Device Tree. Without this patch the
> display subsystem does not properly come up.
> 
> Signed-off-by: Sebastian Reichel 
> ---
> Hi,
> 
> This patch should be added to 3.15-rc to make display initialization via DT
> possible. Sorry for not noticing earlier, that this was missing in Tomi's
> patchset.
> 
> -- Sebastian
> ---
>  arch/arm/mach-omap2/board-rx51-video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/board-rx51-video.c 
> b/arch/arm/mach-omap2/board-rx51-video.c
> index 43a90c8..9cfebc5 100644
> --- a/arch/arm/mach-omap2/board-rx51-video.c
> +++ b/arch/arm/mach-omap2/board-rx51-video.c
> @@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
>  
>  static int __init rx51_video_init(void)
>  {
> - if (!machine_is_nokia_rx51() && 
> !of_machine_is_compatible("nokia,omap3-n900"))
> + if (!machine_is_nokia_rx51())
>   return 0;
>  
>   if (omap_mux_init_gpio(RX51_LCD_RESET_GPIO, OMAP_PIN_OUTPUT)) {
> 

Acked-by: Tomi Valkeinen 

 Tomi




signature.asc
Description: OpenPGP digital signature

Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot

2014-04-08 Thread Aaro Koskinen 
On Tue, Apr 08, 2014 at 03:23:55PM -0700, Tony Lindgren wrote:
> * Aaro Koskinen  [140408 14:48]:
> > Shouldn't we delete the whole file, since non-DT boot is
> > not anymore supported?
> 
> Legacy support is still there for omap3 until the DSS displays are
> converted.

Sorry, I was confused. It seems on omap2 (N800 etc.) the legacy boot
is not supported anymore, and I thought it's the same for omap3. Sorry
for the noise.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot

2014-04-08 Thread Tony Lindgren 
* Aaro Koskinen  [140408 14:48]:
> Hi,
> 
> On Tue, Apr 08, 2014 at 10:51:18PM +0200, Sebastian Reichel wrote:
> > Do not try to initialize display for DT boot, since omapdss
> > is now initialized via Device Tree. Without this patch the
> > display subsystem does not properly come up.
> > 
> > Signed-off-by: Sebastian Reichel 
> > ---
> > Hi,
> > 
> > This patch should be added to 3.15-rc to make display initialization via DT
> > possible. Sorry for not noticing earlier, that this was missing in Tomi's
> > patchset.
> > 
> > -- Sebastian
> > ---
> >  arch/arm/mach-omap2/board-rx51-video.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-omap2/board-rx51-video.c 
> > b/arch/arm/mach-omap2/board-rx51-video.c
> > index 43a90c8..9cfebc5 100644
> > --- a/arch/arm/mach-omap2/board-rx51-video.c
> > +++ b/arch/arm/mach-omap2/board-rx51-video.c
> > @@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
> >  
> >  static int __init rx51_video_init(void)
> >  {
> > -   if (!machine_is_nokia_rx51() && 
> > !of_machine_is_compatible("nokia,omap3-n900"))
> > +   if (!machine_is_nokia_rx51())
> > return 0;
> 
> Shouldn't we delete the whole file, since non-DT boot is
> not anymore supported?

Legacy support is still there for omap3 until the DSS displays are
converted.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot

2014-04-08 Thread Aaro Koskinen 
Hi,

On Tue, Apr 08, 2014 at 10:51:18PM +0200, Sebastian Reichel wrote:
> Do not try to initialize display for DT boot, since omapdss
> is now initialized via Device Tree. Without this patch the
> display subsystem does not properly come up.
> 
> Signed-off-by: Sebastian Reichel 
> ---
> Hi,
> 
> This patch should be added to 3.15-rc to make display initialization via DT
> possible. Sorry for not noticing earlier, that this was missing in Tomi's
> patchset.
> 
> -- Sebastian
> ---
>  arch/arm/mach-omap2/board-rx51-video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/board-rx51-video.c 
> b/arch/arm/mach-omap2/board-rx51-video.c
> index 43a90c8..9cfebc5 100644
> --- a/arch/arm/mach-omap2/board-rx51-video.c
> +++ b/arch/arm/mach-omap2/board-rx51-video.c
> @@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
>  
>  static int __init rx51_video_init(void)
>  {
> - if (!machine_is_nokia_rx51() && 
> !of_machine_is_compatible("nokia,omap3-n900"))
> + if (!machine_is_nokia_rx51())
>   return 0;

Shouldn't we delete the whole file, since non-DT boot is
not anymore supported?

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ARM: OMAP2+: N900: remove omapdss init for DT boot

2014-04-08 Thread Sebastian Reichel 
Do not try to initialize display for DT boot, since omapdss
is now initialized via Device Tree. Without this patch the
display subsystem does not properly come up.

Signed-off-by: Sebastian Reichel 
---
Hi,

This patch should be added to 3.15-rc to make display initialization via DT
possible. Sorry for not noticing earlier, that this was missing in Tomi's
patchset.

-- Sebastian
---
 arch/arm/mach-omap2/board-rx51-video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/board-rx51-video.c 
b/arch/arm/mach-omap2/board-rx51-video.c
index 43a90c8..9cfebc5 100644
--- a/arch/arm/mach-omap2/board-rx51-video.c
+++ b/arch/arm/mach-omap2/board-rx51-video.c
@@ -48,7 +48,7 @@ static struct omap_dss_board_info rx51_dss_board_info = {
 
 static int __init rx51_video_init(void)
 {
-   if (!machine_is_nokia_rx51() && 
!of_machine_is_compatible("nokia,omap3-n900"))
+   if (!machine_is_nokia_rx51())
return 0;
 
if (omap_mux_init_gpio(RX51_LCD_RESET_GPIO, OMAP_PIN_OUTPUT)) {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html