Re: [PATCH v3 0/2] dmaengine: omap-dma: Fix cyclic suspend/resume
On Tue, Sep 16, 2014 at 10:45:55PM +0300, Peter Ujfalusi wrote: > Hi, > > Changes since v2: > - fix typo in patch two > - Acked-by added from Russell > > When the audio is paused/resumed (application paused the sream or board > suspend) > the audio was only playing back one period worth of data and then stops > because > the omap_dam_stop() clears the link configuration and it is not restored in > start. > > Also add memory barrier call to resume path since this could happen right > after > coming out from suspend. Applied, thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/2] dmaengine: omap-dma: Fix cyclic suspend/resume
Vinod, On 09/16/2014 10:45 PM, Peter Ujfalusi wrote: > Hi, > > Changes since v2: > - fix typo in patch two > - Acked-by added from Russell > > When the audio is paused/resumed (application paused the sream or board > suspend) > the audio was only playing back one period worth of data and then stops > because > the omap_dam_stop() clears the link configuration and it is not restored in > start. > > Also add memory barrier call to resume path since this could happen right > after > coming out from suspend. Would it be possible to queue this two patch for 3.17? This stop/start issue affects not only board suspend/resume, but in all cases when application pauses the stream as well when we have underrun in ALSA which would not trigger a full stop and start of audio. Thanks, Péter > Regards, > Peter > --- > Peter Ujfalusi (2): > dmaengine: omap-dma: Add memory barrier to dma_resume path > dmaengine: omap-dma: Restore the CLINK_CTRL in resume path > > drivers/dma/omap-dma.c | 5 + > 1 file changed, 5 insertions(+) > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 0/2] dmaengine: omap-dma: Fix cyclic suspend/resume
Hi, Changes since v2: - fix typo in patch two - Acked-by added from Russell When the audio is paused/resumed (application paused the sream or board suspend) the audio was only playing back one period worth of data and then stops because the omap_dam_stop() clears the link configuration and it is not restored in start. Also add memory barrier call to resume path since this could happen right after coming out from suspend. Regards, Peter --- Peter Ujfalusi (2): dmaengine: omap-dma: Add memory barrier to dma_resume path dmaengine: omap-dma: Restore the CLINK_CTRL in resume path drivers/dma/omap-dma.c | 5 + 1 file changed, 5 insertions(+) -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
