RE: [PATCH v6 3/7] omap: gpmc: enable irq mode in gpmc
> -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Saturday, December 18, 2010 5:40 AM > To: Ghorai, Sukumar > Cc: linux-omap@vger.kernel.org; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v6 3/7] omap: gpmc: enable irq mode in gpmc > > * Sukumar Ghorai [101126 07:25]: > > add support the irq mode in GPMC. > > gpmc_init() function move after omap_init_irq() as it has dependecy on > irq. > > > > Signed-off-by: Sukumar Ghorai > > --- > > arch/arm/mach-omap2/board-2430sdp.c|1 + > > arch/arm/mach-omap2/board-3430sdp.c|1 + > > arch/arm/mach-omap2/board-3630sdp.c|1 + > > arch/arm/mach-omap2/board-4430sdp.c|2 + > > arch/arm/mach-omap2/board-am3517evm.c |2 + > > arch/arm/mach-omap2/board-apollon.c|1 + > > arch/arm/mach-omap2/board-cm-t35.c |1 + > > arch/arm/mach-omap2/board-devkit8000.c |1 + > > arch/arm/mach-omap2/board-generic.c|2 + > > arch/arm/mach-omap2/board-h4.c |1 + > > arch/arm/mach-omap2/board-igep0020.c |1 + > > arch/arm/mach-omap2/board-ldp.c|1 + > > arch/arm/mach-omap2/board-n8x0.c |2 + > > arch/arm/mach-omap2/board-omap3beagle.c|1 + > > arch/arm/mach-omap2/board-omap3evm.c |2 + > > arch/arm/mach-omap2/board-omap3pandora.c |2 + > > arch/arm/mach-omap2/board-omap3stalker.c |1 + > > arch/arm/mach-omap2/board-omap3touchbook.c |1 + > > arch/arm/mach-omap2/board-omap4panda.c |2 + > > arch/arm/mach-omap2/board-overo.c |1 + > > arch/arm/mach-omap2/board-rx51.c |1 + > > arch/arm/mach-omap2/board-zoom2.c |2 + > > arch/arm/mach-omap2/board-zoom3.c |2 + > > arch/arm/mach-omap2/gpmc.c | 39 > ++- > > arch/arm/mach-omap2/io.c |2 - > > arch/arm/plat-omap/include/plat/gpmc.h |4 +++ > > arch/arm/plat-omap/include/plat/irqs.h |9 +- > > 27 files changed, 81 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach- > omap2/board-2430sdp.c > > index b527f8d..11c89dc 100644 > > --- a/arch/arm/mach-omap2/board-2430sdp.c > > +++ b/arch/arm/mach-omap2/board-2430sdp.c > > @@ -145,6 +145,7 @@ static void __init omap_2430sdp_init_irq(void) > > omap_board_config_size = ARRAY_SIZE(sdp2430_config); > > omap2_init_common_hw(NULL, NULL); > > omap_init_irq(); > > + gpmc_init(); > > omap_gpio_init(); > > } > > > > diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach- > omap2/board-3430sdp.c > > index 4e3742c..a040165 100644 > > --- a/arch/arm/mach-omap2/board-3430sdp.c > > +++ b/arch/arm/mach-omap2/board-3430sdp.c > > @@ -328,6 +328,7 @@ static void __init omap_3430sdp_init_irq(void) > > omap3_pm_init_cpuidle(omap3_cpuidle_params_table); > > omap2_init_common_hw(hyb18m512160af6_sdrc_params, NULL); > > omap_init_irq(); > > + gpmc_init(); > > omap_gpio_init(); > > } > ... > > The gpmc init should be done with subsys_initcall instead. [Ghorai] You suggested the same in previous v5; and I mentioned the issues [1] that - nand_init()called before subsys_initcall(gpmc_init); Let me know if I am missing anything again. [1] https://patchwork.kernel.org/patch/212452/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 3/7] omap: gpmc: enable irq mode in gpmc
* Sukumar Ghorai [101126 07:25]: > add support the irq mode in GPMC. > gpmc_init() function move after omap_init_irq() as it has dependecy on irq. > > Signed-off-by: Sukumar Ghorai > --- > arch/arm/mach-omap2/board-2430sdp.c|1 + > arch/arm/mach-omap2/board-3430sdp.c|1 + > arch/arm/mach-omap2/board-3630sdp.c|1 + > arch/arm/mach-omap2/board-4430sdp.c|2 + > arch/arm/mach-omap2/board-am3517evm.c |2 + > arch/arm/mach-omap2/board-apollon.c|1 + > arch/arm/mach-omap2/board-cm-t35.c |1 + > arch/arm/mach-omap2/board-devkit8000.c |1 + > arch/arm/mach-omap2/board-generic.c|2 + > arch/arm/mach-omap2/board-h4.c |1 + > arch/arm/mach-omap2/board-igep0020.c |1 + > arch/arm/mach-omap2/board-ldp.c|1 + > arch/arm/mach-omap2/board-n8x0.c |2 + > arch/arm/mach-omap2/board-omap3beagle.c|1 + > arch/arm/mach-omap2/board-omap3evm.c |2 + > arch/arm/mach-omap2/board-omap3pandora.c |2 + > arch/arm/mach-omap2/board-omap3stalker.c |1 + > arch/arm/mach-omap2/board-omap3touchbook.c |1 + > arch/arm/mach-omap2/board-omap4panda.c |2 + > arch/arm/mach-omap2/board-overo.c |1 + > arch/arm/mach-omap2/board-rx51.c |1 + > arch/arm/mach-omap2/board-zoom2.c |2 + > arch/arm/mach-omap2/board-zoom3.c |2 + > arch/arm/mach-omap2/gpmc.c | 39 ++- > arch/arm/mach-omap2/io.c |2 - > arch/arm/plat-omap/include/plat/gpmc.h |4 +++ > arch/arm/plat-omap/include/plat/irqs.h |9 +- > 27 files changed, 81 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-2430sdp.c > b/arch/arm/mach-omap2/board-2430sdp.c > index b527f8d..11c89dc 100644 > --- a/arch/arm/mach-omap2/board-2430sdp.c > +++ b/arch/arm/mach-omap2/board-2430sdp.c > @@ -145,6 +145,7 @@ static void __init omap_2430sdp_init_irq(void) > omap_board_config_size = ARRAY_SIZE(sdp2430_config); > omap2_init_common_hw(NULL, NULL); > omap_init_irq(); > + gpmc_init(); > omap_gpio_init(); > } > > diff --git a/arch/arm/mach-omap2/board-3430sdp.c > b/arch/arm/mach-omap2/board-3430sdp.c > index 4e3742c..a040165 100644 > --- a/arch/arm/mach-omap2/board-3430sdp.c > +++ b/arch/arm/mach-omap2/board-3430sdp.c > @@ -328,6 +328,7 @@ static void __init omap_3430sdp_init_irq(void) > omap3_pm_init_cpuidle(omap3_cpuidle_params_table); > omap2_init_common_hw(hyb18m512160af6_sdrc_params, NULL); > omap_init_irq(); > + gpmc_init(); > omap_gpio_init(); > } ... The gpmc init should be done with subsys_initcall instead. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 3/7] omap: gpmc: enable irq mode in gpmc
add support the irq mode in GPMC. gpmc_init() function move after omap_init_irq() as it has dependecy on irq. Signed-off-by: Sukumar Ghorai --- arch/arm/mach-omap2/board-2430sdp.c|1 + arch/arm/mach-omap2/board-3430sdp.c|1 + arch/arm/mach-omap2/board-3630sdp.c|1 + arch/arm/mach-omap2/board-4430sdp.c|2 + arch/arm/mach-omap2/board-am3517evm.c |2 + arch/arm/mach-omap2/board-apollon.c|1 + arch/arm/mach-omap2/board-cm-t35.c |1 + arch/arm/mach-omap2/board-devkit8000.c |1 + arch/arm/mach-omap2/board-generic.c|2 + arch/arm/mach-omap2/board-h4.c |1 + arch/arm/mach-omap2/board-igep0020.c |1 + arch/arm/mach-omap2/board-ldp.c|1 + arch/arm/mach-omap2/board-n8x0.c |2 + arch/arm/mach-omap2/board-omap3beagle.c|1 + arch/arm/mach-omap2/board-omap3evm.c |2 + arch/arm/mach-omap2/board-omap3pandora.c |2 + arch/arm/mach-omap2/board-omap3stalker.c |1 + arch/arm/mach-omap2/board-omap3touchbook.c |1 + arch/arm/mach-omap2/board-omap4panda.c |2 + arch/arm/mach-omap2/board-overo.c |1 + arch/arm/mach-omap2/board-rx51.c |1 + arch/arm/mach-omap2/board-zoom2.c |2 + arch/arm/mach-omap2/board-zoom3.c |2 + arch/arm/mach-omap2/gpmc.c | 39 ++- arch/arm/mach-omap2/io.c |2 - arch/arm/plat-omap/include/plat/gpmc.h |4 +++ arch/arm/plat-omap/include/plat/irqs.h |9 +- 27 files changed, 81 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c index b527f8d..11c89dc 100644 --- a/arch/arm/mach-omap2/board-2430sdp.c +++ b/arch/arm/mach-omap2/board-2430sdp.c @@ -145,6 +145,7 @@ static void __init omap_2430sdp_init_irq(void) omap_board_config_size = ARRAY_SIZE(sdp2430_config); omap2_init_common_hw(NULL, NULL); omap_init_irq(); + gpmc_init(); omap_gpio_init(); } diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c index 4e3742c..a040165 100644 --- a/arch/arm/mach-omap2/board-3430sdp.c +++ b/arch/arm/mach-omap2/board-3430sdp.c @@ -328,6 +328,7 @@ static void __init omap_3430sdp_init_irq(void) omap3_pm_init_cpuidle(omap3_cpuidle_params_table); omap2_init_common_hw(hyb18m512160af6_sdrc_params, NULL); omap_init_irq(); + gpmc_init(); omap_gpio_init(); } diff --git a/arch/arm/mach-omap2/board-3630sdp.c b/arch/arm/mach-omap2/board-3630sdp.c index bbcf580..17983ed 100644 --- a/arch/arm/mach-omap2/board-3630sdp.c +++ b/arch/arm/mach-omap2/board-3630sdp.c @@ -76,6 +76,7 @@ static void __init omap_sdp_init_irq(void) omap2_init_common_hw(h8mbx00u0mer0em_sdrc_params, h8mbx00u0mer0em_sdrc_params); omap_init_irq(); + gpmc_init(); omap_gpio_init(); } diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index df5a425..8d15604 100644 --- a/arch/arm/mach-omap2/board-4430sdp.c +++ b/arch/arm/mach-omap2/board-4430sdp.c @@ -34,6 +34,7 @@ #include #include #include +#include #include "hsmmc.h" #include "timer-gp.h" @@ -222,6 +223,7 @@ static void __init omap_4430sdp_init_irq(void) omap2_gp_clockevent_set_gptimer(1); #endif gic_init_irq(); + gpmc_init(); omap_gpio_init(); } diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach-omap2/board-am3517evm.c index 0739950..460e3d1 100644 --- a/arch/arm/mach-omap2/board-am3517evm.c +++ b/arch/arm/mach-omap2/board-am3517evm.c @@ -35,6 +35,7 @@ #include #include #include +#include #include "mux.h" #include "control.h" @@ -392,6 +393,7 @@ static void __init am3517_evm_init_irq(void) omap2_init_common_hw(NULL, NULL); omap_init_irq(); + gpmc_init(); omap_gpio_init(); } diff --git a/arch/arm/mach-omap2/board-apollon.c b/arch/arm/mach-omap2/board-apollon.c index 2c6db1a..8264e7a 100644 --- a/arch/arm/mach-omap2/board-apollon.c +++ b/arch/arm/mach-omap2/board-apollon.c @@ -280,6 +280,7 @@ static void __init omap_apollon_init_irq(void) omap_board_config_size = ARRAY_SIZE(apollon_config); omap2_init_common_hw(NULL, NULL); omap_init_irq(); + gpmc_init(); omap_gpio_init(); apollon_init_smc91x(); } diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c index 63f764e..7c9a834 100644 --- a/arch/arm/mach-omap2/board-cm-t35.c +++ b/arch/arm/mach-omap2/board-cm-t35.c @@ -686,6 +686,7 @@ static void __init cm_t35_init_irq(void) omap2_init_common_hw(mt46h32m32lf6_sdrc_params, mt46h32m32lf6_sdrc_params); omap_init_irq(); + gpmc_init(); omap_gpio_init(); } diff --git a/arch/arm/mach-omap2/b
