Re: [PATCH] mlx4: Change a warning message to debug

[Roland Dreier]

OK, I just got rid of the message entirely.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: Change a warning message to debug

[Roland Dreier]

   Not sure I agree ... surely the point of this message is for the user to
   see it and know to update firmware?  Otherwise why print anything at
   all, since I'm sure you guys have already fixed the firmware and have a
   regression test so this bug doesn't reappear?

  Right :-)

So what do you think -- remove the message entirely or leave it?

 - R.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mlx4: Change a warning message to debug

[Eli Cohen]

This workaround presented in 58d74bb is not something we should alert the user
on.  Debug level message is enough.

Signed-off-by: Eli Cohen e...@mellanox.co.il
---
 drivers/net/mlx4/fw.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mlx4/fw.c b/drivers/net/mlx4/fw.c
index 7a7e18b..9f415df 100644
--- a/drivers/net/mlx4/fw.c
+++ b/drivers/net/mlx4/fw.c
@@ -290,7 +290,7 @@ int mlx4_QUERY_DEV_CAP(struct mlx4_dev *dev, struct 
mlx4_dev_cap *dev_cap)
dev_cap-bf_reg_size = 1  (field  0x1f);
MLX4_GET(field, outbox, 
QUERY_DEV_CAP_LOG_MAX_BF_REGS_PER_PAGE_OFFSET);
if ((1  (field  0x3f))  (PAGE_SIZE / dev_cap-bf_reg_size)) 
{
-   mlx4_warn(dev, firmware bug: log2 # of blue flame regs 
is invalid (%d), forcing 3\n, field  0x1f);
+   mlx4_dbg(dev, firmware bug: log2 # of blue flame regs 
is invalid (%d), forcing 3\n, field  0x1f);
field = 3;
}
dev_cap-bf_regs_per_page = 1  (field  0x3f);
-- 
1.7.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: Change a warning message to debug

[Roland Dreier]

  This workaround presented in 58d74bb is not something we should alert the 
  user
  on.  Debug level message is enough.

Not sure I agree ... surely the point of this message is for the user to
see it and know to update firmware?  Otherwise why print anything at
all, since I'm sure you guys have already fixed the firmware and have a
regression test so this bug doesn't reappear?

 - R.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html