Re: [PATCH v2 05/18] arm64: dts: h3ulcb-kf: ES1.x SoC initial device tree
On Thu, Sep 14, 2017 at 05:18:58PM +0300, Vladimir Barinov wrote: > Add the initial device tree for the H3ULCB ES1.x SoC with Kingfisher > extension infotainment board. > > Signed-off-by: Vladimir Barinov > --- > Changes in version 2: > - added own compatible value "shimafuji,kingfisher" Thanks, I have applied. There was some fuzz when doing so. Please check that what I have applied is correct when I push the next branch pf the renesas tree later today.
Re: [PATCH v2] usb: renesas_usbhs: Add compatible string for r8a7743/5
Hi Simon, On Mon, Oct 9, 2017 at 7:59 AM, Simon Horman wrote: > On Fri, Oct 06, 2017 at 05:49:34PM +0100, Biju Das wrote: >> This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME] >> (R8A7743/5) usbhs is identical to the R-Car Gen2 family. >> >> No driver change is needed due to the fallback compatible value >> "renesas,rcar-gen2-usbhs". >> Adding the SoC-specific compatible values here has two purposes: >> 1. Document which SoCs have this hardware module, >> 2. Allow checkpatch to validate compatible values. > > 3. Allow the driver to support SoC specific implementations in future >as necessary. Thanks for amending! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH v2] usb: renesas_usbhs: Add compatible string for r8a7743/5
On Fri, Oct 06, 2017 at 05:49:34PM +0100, Biju Das wrote: > This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME] > (R8A7743/5) usbhs is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,rcar-gen2-usbhs". > Adding the SoC-specific compatible values here has two purposes: > 1. Document which SoCs have this hardware module, > 2. Allow checkpatch to validate compatible values. 3. Allow the driver to support SoC specific implementations in future as necessary. Acked-by: Simon Horman > Signed-off-by: Biju Das > Signed-off-by: Chris Paterson > Reviewed-by: Yoshihiro Shimoda > Reviewed-by: Geert Uytterhoeven > --- > v1-->v2 >* Modified the patch description >* Rebased on the below R-Car D3 patch > https://patchwork.kernel.org/patch/9982267/ > > This patch is tested against Linux next tag next-20170929 + > https://patchwork.kernel.org/patch/9982267/ > > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index e79f6e4..47394ab 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > @@ -3,6 +3,8 @@ Renesas Electronics USBHS driver > Required properties: >- compatible: Must contain one or more of the following: > > + - "renesas,usbhs-r8a7743" for r8a7743 (RZ/G1M) compatible device > + - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device > - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device > - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device > - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device > @@ -11,7 +13,7 @@ Required properties: > - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device > - "renesas,usbhs-r8a7796" for r8a7796 (R-Car M3-W) compatible device > - "renesas,usbhs-r8a77995" for r8a77995 (R-Car D3) compatible device > - - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device > + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 or RZ/G1 compatible devices > - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device > > When compatible with the generic version, nodes must list the > -- > 1.9.1 >
Re: [PATCH 3/3] ARM: dts: gr-peach: Add ETHER pin group
On Fri, Oct 06, 2017 at 02:25:23PM +0200, jacopo mondi wrote: > Hi Simon, > > On Thu, Oct 05, 2017 at 10:58:20AM +0200, Jacopo Mondi wrote: > > Add pin configuration subnode for ETHER pin group and enable the interface. > > > > Signed-off-by: Jacopo Mondi > > --- > > arch/arm/boot/dts/r7s72100-gr-peach.dts | 38 > > + > > 1 file changed, 38 insertions(+) > > > > Can you confirm you have not applied this yet? Confirmed.
Re: [PATCH] dt-bindings: irqchip: renesas-irqc: Document R-Car M3-W, V3M, D3 support
On Fri, Oct 06, 2017 at 01:51:32PM +0200, Geert Uytterhoeven wrote: > Document support for the Interrupt Controller for Externel Devices > (INTC-EX) in the Renesas M3-W (r8a7796), V3M (r8a77970), and D3 > (r8a77995) SoCs. > > No driver update is needed. > > Signed-off-by: Geert Uytterhoeven Acked-by: Simon Horman
[RFC PATCH] mmc: sunxi: drop superfluous error message
This error message can go because a) currently nothing else than EPROBE_DEFER is returned and b) if this is going to change a much more detailed error message should come from mmc_regulator_get_supply() anyhow. Signed-off-by: Wolfram Sang --- While I think this patch is correct as is (because of this discussion [1]), I still wonder about the intention of the now removed message. Because a not supplied vmmc is not determined by the return value of *_get_supply(), but by a check if mmc->supply.vmmc is populated afterwards. So, if this was the original intention such a check would need to be implemented on top of this patch. [1] https://patchwork.kernel.org/patch/9965823/ drivers/mmc/host/sunxi-mmc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c index 53c970fe087397..cc98355dbdb9cc 100644 --- a/drivers/mmc/host/sunxi-mmc.c +++ b/drivers/mmc/host/sunxi-mmc.c @@ -1175,11 +1175,8 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host, return -EINVAL; ret = mmc_regulator_get_supply(host->mmc); - if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, "Could not get vmmc supply\n"); + if (ret) return ret; - } host->reg_base = devm_ioremap_resource(&pdev->dev, platform_get_resource(pdev, IORESOURCE_MEM, 0)); -- 2.11.0
Re: [PATCH v2] dmaengine: usb-dmac: Add compatible string for r8a7743/5
On Fri, Oct 06, 2017 at 06:15:17PM +0100, Biju Das wrote: > This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME] > (R8A7743/5) usbdmac engine is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,r8a7743-usb-dmac". > Adding the SoC-specific compatible values here has two purposes: > 1. Document which SoCs have this hardware module, > 2. Allow checkpatch to validate compatible values. Applied, thanks -- ~Vinod