Re: [PATCH] arm64: dts: r8a7795-es1: Drop extra zero from usb unit address
On Fri, Aug 18, 2017 at 10:07:26AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Fri, Aug 18, 2017 at 10:02 AM, Simon Horman wrote:
> > On Thu, Aug 17, 2017 at 01:29:14PM +0200, Geert Uytterhoeven wrote:
> >> With W=1:
> >>
> >> arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning
> >> (simple_bus_reg): Node /soc/usb@ee040 simple-bus unit address format
> >> error, expected "ee04"
> >> arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dtb: Warning
> >> (simple_bus_reg): Node /soc/usb@ee040 simple-bus unit address format
> >> error, expected "ee04"
> >>
> >> Fixes: 291e0c4994d0813f ("arm64: dts: r8a7795: Add support for R-Car H3
> >> ES2.0")
> >> Fixes: 171f2ef82284f61b ("arm64: dts: r8a7795: Add USB3.0 host device
> >> nodes")
> >> Signed-off-by: Geert Uytterhoeven
> >> ---
> >> The second fixes tag is for the original r8a7795.dtsi, before
> >> r8a7795-es1.dtsi was split off.
> >
> > Do you want this treated as a fix for v4.13 or v4.14, or a regular patch
> > for v4.15? It looks like the problem has been present in some form since
> > v4.12.
>
> It's not a critical fix (no impact at all?), so v4.15 is fine.
Thanks for the clarification. I have applied it for v4.15.
I guess some sort of auto-backporting will take place at some point
due to the fixes tags.
Re: [PATCH] arm64: dts: r8a7795-es1: Drop extra zero from usb unit address
Hi Simon,
On Fri, Aug 18, 2017 at 10:02 AM, Simon Horman wrote:
> On Thu, Aug 17, 2017 at 01:29:14PM +0200, Geert Uytterhoeven wrote:
>> With W=1:
>>
>> arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning
>> (simple_bus_reg): Node /soc/usb@ee040 simple-bus unit address format
>> error, expected "ee04"
>> arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dtb: Warning
>> (simple_bus_reg): Node /soc/usb@ee040 simple-bus unit address format
>> error, expected "ee04"
>>
>> Fixes: 291e0c4994d0813f ("arm64: dts: r8a7795: Add support for R-Car H3
>> ES2.0")
>> Fixes: 171f2ef82284f61b ("arm64: dts: r8a7795: Add USB3.0 host device nodes")
>> Signed-off-by: Geert Uytterhoeven
>> ---
>> The second fixes tag is for the original r8a7795.dtsi, before
>> r8a7795-es1.dtsi was split off.
>
> Do you want this treated as a fix for v4.13 or v4.14, or a regular patch
> for v4.15? It looks like the problem has been present in some form since
> v4.12.
It's not a critical fix (no impact at all?), so v4.15 is fine.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] arm64: dts: r8a7795-es1: Drop extra zero from usb unit address
On Thu, Aug 17, 2017 at 01:29:14PM +0200, Geert Uytterhoeven wrote:
> With W=1:
>
> arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning
> (simple_bus_reg): Node /soc/usb@ee040 simple-bus unit address format
> error, expected "ee04"
> arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dtb: Warning
> (simple_bus_reg): Node /soc/usb@ee040 simple-bus unit address format
> error, expected "ee04"
>
> Fixes: 291e0c4994d0813f ("arm64: dts: r8a7795: Add support for R-Car H3
> ES2.0")
> Fixes: 171f2ef82284f61b ("arm64: dts: r8a7795: Add USB3.0 host device nodes")
> Signed-off-by: Geert Uytterhoeven
> ---
> The second fixes tag is for the original r8a7795.dtsi, before
> r8a7795-es1.dtsi was split off.
Do you want this treated as a fix for v4.13 or v4.14, or a regular patch
for v4.15? It looks like the problem has been present in some form since
v4.12.
> ---
> arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
> index aaa5e67a963ea9ff..655dd30639c55027 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
> @@ -11,7 +11,7 @@
> #include "r8a7795.dtsi"
>
> &soc {
> - xhci1: usb@ee040 {
> + xhci1: usb@ee04 {
> compatible = "renesas,xhci-r8a7795", "renesas,rcar-gen3-xhci";
> reg = <0 0xee04 0 0xc00>;
> interrupts = ;
> --
> 2.7.4
>
[PATCH] arm64: dts: r8a7795-es1: Drop extra zero from usb unit address
With W=1:
arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dtb: Warning
(simple_bus_reg): Node /soc/usb@ee040 simple-bus unit address format error,
expected "ee04"
arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dtb: Warning
(simple_bus_reg): Node /soc/usb@ee040 simple-bus unit address format error,
expected "ee04"
Fixes: 291e0c4994d0813f ("arm64: dts: r8a7795: Add support for R-Car H3 ES2.0")
Fixes: 171f2ef82284f61b ("arm64: dts: r8a7795: Add USB3.0 host device nodes")
Signed-off-by: Geert Uytterhoeven
---
The second fixes tag is for the original r8a7795.dtsi, before
r8a7795-es1.dtsi was split off.
---
arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
b/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
index aaa5e67a963ea9ff..655dd30639c55027 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
@@ -11,7 +11,7 @@
#include "r8a7795.dtsi"
&soc {
- xhci1: usb@ee040 {
+ xhci1: usb@ee04 {
compatible = "renesas,xhci-r8a7795", "renesas,rcar-gen3-xhci";
reg = <0 0xee04 0 0xc00>;
interrupts = ;
--
2.7.4
