[PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
From: Kuninori Morimoto
Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
Signed-off-by: Kuninori Morimoto
---
drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 1434a6f..cb55a9a 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -556,6 +556,9 @@ static const u16 pinmux_data[] = {
PINMUX_SINGLE(AVS2),
PINMUX_SINGLE(HDMI0_CEC),
PINMUX_SINGLE(HDMI1_CEC),
+ PINMUX_SINGLE(I2C_SEL_0_1),
+ PINMUX_SINGLE(I2C_SEL_3_1),
+ PINMUX_SINGLE(I2C_SEL_5_1),
PINMUX_SINGLE(MSIOF0_RXD),
PINMUX_SINGLE(MSIOF0_SCK),
PINMUX_SINGLE(MSIOF0_TXD),
@@ -1405,11 +1408,6 @@ static const u16 pinmux_data[] = {
PINMUX_IPSR_MSEL(IP17_7_4, STP_ISSYNC_0_E, SEL_SSP1_0_4),
PINMUX_IPSR_MSEL(IP17_7_4, RIF2_D1_B, SEL_DRIF2_1),
PINMUX_IPSR_GPSR(IP17_7_4, TPU0TO3),
-
- /* I2C */
- PINMUX_IPSR_NOGP(0, I2C_SEL_0_1),
- PINMUX_IPSR_NOGP(0, I2C_SEL_3_1),
- PINMUX_IPSR_NOGP(0, I2C_SEL_5_1),
};
static const struct sh_pfc_pin pinmux_pins[] = {
--
1.9.1
[PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
From: Kuninori Morimoto
Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
Signed-off-by: Kuninori Morimoto
Reviewed-by: Geert Uytterhoeven
---
drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 1434a6f..cb55a9a 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -556,6 +556,9 @@ static const u16 pinmux_data[] = {
PINMUX_SINGLE(AVS2),
PINMUX_SINGLE(HDMI0_CEC),
PINMUX_SINGLE(HDMI1_CEC),
+ PINMUX_SINGLE(I2C_SEL_0_1),
+ PINMUX_SINGLE(I2C_SEL_3_1),
+ PINMUX_SINGLE(I2C_SEL_5_1),
PINMUX_SINGLE(MSIOF0_RXD),
PINMUX_SINGLE(MSIOF0_SCK),
PINMUX_SINGLE(MSIOF0_TXD),
@@ -1405,11 +1408,6 @@ static const u16 pinmux_data[] = {
PINMUX_IPSR_MSEL(IP17_7_4, STP_ISSYNC_0_E, SEL_SSP1_0_4),
PINMUX_IPSR_MSEL(IP17_7_4, RIF2_D1_B, SEL_DRIF2_1),
PINMUX_IPSR_GPSR(IP17_7_4, TPU0TO3),
-
- /* I2C */
- PINMUX_IPSR_NOGP(0, I2C_SEL_0_1),
- PINMUX_IPSR_NOGP(0, I2C_SEL_3_1),
- PINMUX_IPSR_NOGP(0, I2C_SEL_5_1),
};
static const struct sh_pfc_pin pinmux_pins[] = {
--
1.9.1
Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
Hi Geert Thank you for your review > > From: Kuninori Morimoto > > > > Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP() > > > > Signed-off-by: Kuninori Morimoto > > Reviewed-by: Geert Uytterhoeven Oops, I didn't Cc to gpio ML I will send this patch again (with Geert's Reviewed-by)
Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
Hi Geert > >> > From: Kuninori Morimoto > >> > > >> > Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP() > >> > > >> > Signed-off-by: Kuninori Morimoto > >> > >> Reviewed-by: Geert Uytterhoeven > > > > Oops, I didn't Cc to gpio ML > > I will send this patch again (with Geert's Reviewed-by) > > No problem, it's trivial, and it will go through my sh-pfc-for-v4.8 anyway... OK, Thank you !
Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
Hi Morimoto-san,
On Tue, Jun 21, 2016 at 9:19 AM, Kuninori Morimoto
wrote:
>> > From: Kuninori Morimoto
>> >
>> > Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
>> >
>> > Signed-off-by: Kuninori Morimoto
>>
>> Reviewed-by: Geert Uytterhoeven
>
> Oops, I didn't Cc to gpio ML
> I will send this patch again (with Geert's Reviewed-by)
No problem, it's trivial, and it will go through my sh-pfc-for-v4.8 anyway...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
On Tue, Jun 21, 2016 at 4:46 AM, Kuninori Morimoto
wrote:
> From: Kuninori Morimoto
>
> Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
>
> Signed-off-by: Kuninori Morimoto
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
On Tue, Jun 21, 2016 at 9:21 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP() > > Signed-off-by: Kuninori Morimoto > Reviewed-by: Geert Uytterhoeven Acked-by: Linus Walleij Geert, are you queuing this? Yours, Linus Walleij
Re: [PATCH] pinctrl: sh-pfc: r8a7795: use PINMUX_SINGLE() for I2C
Hi Linus,
On Thu, Jun 23, 2016 at 10:47 AM, Linus Walleij
wrote:
> On Tue, Jun 21, 2016 at 9:21 AM, Kuninori Morimoto
> wrote:
>
>> From: Kuninori Morimoto
>>
>> Now we have PINMUX_SINGLE(). Let's use it instead of PINMUX_IPSR_NOGP()
>>
>> Signed-off-by: Kuninori Morimoto
>> Reviewed-by: Geert Uytterhoeven
>
> Acked-by: Linus Walleij
Thx!
> Geert, are you queuing this?
Sure, it's time to prepare a pull request soon...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
