Re: [PATCHv7 04/15] HID: add HDMI CEC specific keycodes
On 06/29/15 21:25, Dmitry Torokhov wrote: On Mon, Jun 29, 2015 at 12:14:49PM +0200, Hans Verkuil wrote: From: Kamil Debski ka...@wypas.org Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski ka...@wypas.org Signed-off-by: Hans Verkuil hans.verk...@cisco.com Could you please describe the intended use for these keycodes for people who do not live and breathe CEC specs? Do you want this as comments in the patch or as the commit description? I realized that this patch needs to be updated anyway since there are a few keys missing that were added for CEC 2.0. Regards, Hans Thanks! --- include/uapi/linux/input.h | 12 1 file changed, 12 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index 731417c..7430a3f 100644 --- a/include/uapi/linux/input.h +++ b/include/uapi/linux/input.h @@ -752,6 +752,18 @@ struct input_keymap_entry { #define KEY_KBDINPUTASSIST_ACCEPT 0x264 #define KEY_KBDINPUTASSIST_CANCEL 0x265 +#define KEY_RIGHT_UP0x266 +#define KEY_RIGHT_DOWN 0x267 +#define KEY_LEFT_UP 0x268 +#define KEY_LEFT_DOWN 0x269 + +#define KEY_NEXT_FAVORITE 0x270 +#define KEY_STOP_RECORD 0x271 +#define KEY_PAUSE_RECORD0x272 +#define KEY_VOD 0x273 +#define KEY_UNMUTE 0x274 +#define KEY_DVB 0x275 + #define BTN_TRIGGER_HAPPY 0x2c0 #define BTN_TRIGGER_HAPPY1 0x2c0 #define BTN_TRIGGER_HAPPY2 0x2c1 -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] spi/s3c24xx: remove unnecessary memset of s3c24xx_spi
On Wed, Jul 1, 2015 at 2:03 AM, Alexey Klimov klimov.li...@gmail.com wrote: Memory for this struct is allocated by spi_alloc_master() using kzalloc() so it doesn't need to be set to 0 one more time. Signed-off-by: Alexey Klimov klimov.li...@gmail.com Yup, I just noticed this too when reviewing the mediatek SPI driver. For both patches: Reviewed-by: Daniel Kurtz djku...@chromium.org --- drivers/spi/spi-s3c24xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c index f747ca2..f36bc32 100644 --- a/drivers/spi/spi-s3c24xx.c +++ b/drivers/spi/spi-s3c24xx.c @@ -501,7 +501,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) } hw = spi_master_get_devdata(master); - memset(hw, 0, sizeof(struct s3c24xx_spi)); hw-master = master; hw-pdata = pdata = dev_get_platdata(pdev-dev); -- 1.9.1 ___ Linux-rockchip mailing list linux-rockc...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv7 04/15] HID: add HDMI CEC specific keycodes
On Tue, Jun 30, 2015 at 09:36:49AM +0200, Hans Verkuil wrote: On 06/29/15 21:25, Dmitry Torokhov wrote: On Mon, Jun 29, 2015 at 12:14:49PM +0200, Hans Verkuil wrote: From: Kamil Debski ka...@wypas.org Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski ka...@wypas.org Signed-off-by: Hans Verkuil hans.verk...@cisco.com Could you please describe the intended use for these keycodes for people who do not live and breathe CEC specs? Do you want this as comments in the patch or as the commit description? In the patch would be preferable. Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
Hello Bartlomiej, On 06/30/2015 07:17 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote: On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Krzysztof has noted that I should use your @dowhile0.org e-mail address instead of @collabora.co.uk one, is this right? I don't know what is the policy for tags but Krzysztof is correct that this email address is going away this week so for future patches please use my personal @dowhile0.org address instead. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
Hi, On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote: On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Krzysztof has noted that I should use your @dowhile0.org e-mail address instead of @collabora.co.uk one, is this right? Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
On Tuesday, June 30, 2015 07:45:15 PM Javier Martinez Canillas wrote: Hello Bartlomiej, On 06/30/2015 07:17 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote: On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Krzysztof has noted that I should use your @dowhile0.org e-mail address instead of @collabora.co.uk one, is this right? I don't know what is the policy for tags but Krzysztof is correct that this email address is going away this week so for future patches please use my personal @dowhile0.org address instead. OK, I'll update my patches scripts then. Thank you for review. Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] spi/rockchip: remove unnecessary memset of rockchip_spi
Memory for struct rockchip_spi is allocated by spi_alloc_master() using kzalloc() so it doesn't need to be set to 0 one more time. Signed-off-by: Alexey Klimov klimov.li...@gmail.com --- drivers/spi/spi-rockchip.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 68e7efe..79a8bc4 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -645,7 +645,6 @@ static int rockchip_spi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, master); rs = spi_master_get_devdata(master); - memset(rs, 0, sizeof(struct rockchip_spi)); /* Get basic io resource and map it */ mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/2] spi/s3c24xx: remove unnecessary memset of s3c24xx_spi
Memory for this struct is allocated by spi_alloc_master() using kzalloc() so it doesn't need to be set to 0 one more time. Signed-off-by: Alexey Klimov klimov.li...@gmail.com --- drivers/spi/spi-s3c24xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c index f747ca2..f36bc32 100644 --- a/drivers/spi/spi-s3c24xx.c +++ b/drivers/spi/spi-s3c24xx.c @@ -501,7 +501,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) } hw = spi_master_get_devdata(master); - memset(hw, 0, sizeof(struct s3c24xx_spi)); hw-master = master; hw-pdata = pdata = dev_get_platdata(pdev-dev); -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Krzysztof Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM
[Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 (Thu 10:44) Javier Martinez Canillas wrote: Hello Lee, On 06/25/2015 10:38 AM, Lee Jones wrote: On Thu, 25 Jun 2015, Javier Martinez Canillas wrote: A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM) This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but that dependency was removed since there isn't a reason why the option can not be selected on other architectures. So now the above warning will not happen and the MFD_CROS_EC dependency can be removed since is not needed. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/mfd/Kconfig | 1 - 1 file changed, 1 deletion(-) Applied for v4.3, thanks. Thanks a lot. Olof, Could you please ack patch 1/3 so Lee can pick it through the mfd tree? Since both patches 1/3 and 2/3 are needed to fix the build warning for !X86 and !ARM architectures. Checking this didn't fall through the cracks ; still seeing the issue in xtensa (and other arch) builds of linux-next currently: http://kisskb.ellerman.id.au/kisskb/buildresult/12452368/ Paul. -- Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] pinctrl: samsung: Remove old unused defines
On Mon, Jun 15, 2015 at 6:54 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Since 9a2c1c3b91aa (pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes) the defines for GPIO group and function names are not used anywhere in the driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Inspired-by: Dan Carpenter dan.carpen...@oracle.com Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html