[PATCH] thermal: exynos: fix register read in TMU
The value of emul_con was getting overwritten if the selected soc is SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong register in the case of SOC_ARCH_EXYNOS5260. Signed-off-by: Sudip Mukherjee --- drivers/thermal/samsung/exynos_tmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 0bae8cc..ca920b0 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data, if (data->soc == SOC_ARCH_EXYNOS5260) emul_con = EXYNOS5260_EMUL_CON; - if (data->soc == SOC_ARCH_EXYNOS5433) + else if (data->soc == SOC_ARCH_EXYNOS5433) emul_con = EXYNOS5433_TMU_EMUL_CON; else if (data->soc == SOC_ARCH_EXYNOS7) emul_con = EXYNOS7_TMU_REG_EMUL_CON; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] thermal: exynos: Fix register read in TMU
From: Sudip Mukherjee The value of emul_con was getting overwritten if the selected soc is SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong register in the case of SOC_ARCH_EXYNOS5260. Signed-off-by: Sudip Mukherjee Reviewed-by: Krzysztof Kozlowski Reviewed-by: Chanwoo Choi Acked-by: Lukasz Majewski Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU") Signed-off-by: Krzysztof Kozlowski --- drivers/thermal/samsung/exynos_tmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 0bae8cc6c23a..ca920b0ecf8f 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data, if (data->soc == SOC_ARCH_EXYNOS5260) emul_con = EXYNOS5260_EMUL_CON; - if (data->soc == SOC_ARCH_EXYNOS5433) + else if (data->soc == SOC_ARCH_EXYNOS5433) emul_con = EXYNOS5433_TMU_EMUL_CON; else if (data->soc == SOC_ARCH_EXYNOS7) emul_con = EXYNOS7_TMU_REG_EMUL_CON; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: fix register read in TMU
2015-10-01 20:39 GMT+09:00 Sudip Mukherjee : > The value of emul_con was getting overwritten if the selected soc is > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong > register in the case of SOC_ARCH_EXYNOS5260. How the value is overwritten if the soc is Exynos5260? I can't see it (although the "else if" is still more obvious than "if" but how does the description match the code?). Best regards, Krzysztof > > Signed-off-by: Sudip Mukherjee > --- > drivers/thermal/samsung/exynos_tmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c > index 0bae8cc..ca920b0 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct > exynos_tmu_data *data, > > if (data->soc == SOC_ARCH_EXYNOS5260) > emul_con = EXYNOS5260_EMUL_CON; > - if (data->soc == SOC_ARCH_EXYNOS5433) > + else if (data->soc == SOC_ARCH_EXYNOS5433) > emul_con = EXYNOS5433_TMU_EMUL_CON; > else if (data->soc == SOC_ARCH_EXYNOS7) > emul_con = EXYNOS7_TMU_REG_EMUL_CON; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: fix register read in TMU
On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote: > 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee : > > The value of emul_con was getting overwritten if the selected soc is > > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong > > register in the case of SOC_ARCH_EXYNOS5260. > > How the value is overwritten if the soc is Exynos5260? I can't see it > (although the "else if" is still more obvious than "if" but how does > the description match the code?). The code here is: if (data->soc == SOC_ARCH_EXYNOS5260) emul_con = EXYNOS5260_EMUL_CON; if (data->soc == SOC_ARCH_EXYNOS5433) emul_con = EXYNOS5433_TMU_EMUL_CON; else if (data->soc == SOC_ARCH_EXYNOS7) emul_con = EXYNOS7_TMU_REG_EMUL_CON; else emul_con = EXYNOS_EMUL_CON; So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes EXYNOS5260_EMUL_CON. But again for the else part it will become EXYNOS_EMUL_CON. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: fix register read in TMU
2015-10-01 23:12 GMT+09:00 Sudip Mukherjee : > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote: >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee : >> > The value of emul_con was getting overwritten if the selected soc is >> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong >> > register in the case of SOC_ARCH_EXYNOS5260. >> >> How the value is overwritten if the soc is Exynos5260? I can't see it >> (although the "else if" is still more obvious than "if" but how does >> the description match the code?). > The code here is: > if (data->soc == SOC_ARCH_EXYNOS5260) > emul_con = EXYNOS5260_EMUL_CON; > if (data->soc == SOC_ARCH_EXYNOS5433) > emul_con = EXYNOS5433_TMU_EMUL_CON; > else if (data->soc == SOC_ARCH_EXYNOS7) > emul_con = EXYNOS7_TMU_REG_EMUL_CON; > else > emul_con = EXYNOS_EMUL_CON; > > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes > EXYNOS5260_EMUL_CON. But again for the else part it will become > EXYNOS_EMUL_CON. Indeed! Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU") Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: fix register read in TMU
On 2015년 10월 01일 20:39, Sudip Mukherjee wrote: > The value of emul_con was getting overwritten if the selected soc is > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong > register in the case of SOC_ARCH_EXYNOS5260. > > Signed-off-by: Sudip Mukherjee > --- > drivers/thermal/samsung/exynos_tmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c > index 0bae8cc..ca920b0 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct > exynos_tmu_data *data, > > if (data->soc == SOC_ARCH_EXYNOS5260) > emul_con = EXYNOS5260_EMUL_CON; > - if (data->soc == SOC_ARCH_EXYNOS5433) > + else if (data->soc == SOC_ARCH_EXYNOS5433) > emul_con = EXYNOS5433_TMU_EMUL_CON; > else if (data->soc == SOC_ARCH_EXYNOS7) > emul_con = EXYNOS7_TMU_REG_EMUL_CON; > Thanks for your point out. Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: fix register read in TMU
On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote: > 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee : > > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote: > >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee : > >> > The value of emul_con was getting overwritten if the selected soc is > >> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong > >> > register in the case of SOC_ARCH_EXYNOS5260. > >> > >> How the value is overwritten if the soc is Exynos5260? I can't see it > >> (although the "else if" is still more obvious than "if" but how does > >> the description match the code?). > > The code here is: > > if (data->soc == SOC_ARCH_EXYNOS5260) > > emul_con = EXYNOS5260_EMUL_CON; > > if (data->soc == SOC_ARCH_EXYNOS5433) > > emul_con = EXYNOS5433_TMU_EMUL_CON; > > else if (data->soc == SOC_ARCH_EXYNOS7) > > emul_con = EXYNOS7_TMU_REG_EMUL_CON; > > else > > emul_con = EXYNOS_EMUL_CON; > > > > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes > > EXYNOS5260_EMUL_CON. But again for the else part it will become > > EXYNOS_EMUL_CON. > > Indeed! > > Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU") > > Reviewed-by: Krzysztof Kozlowski Hi Krzysztof, Who will pick this one up? I still do not see it in linux-next. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: fix register read in TMU
2015-10-08 23:21 GMT+09:00 Sudip Mukherjee : > On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote: >> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee : >> > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote: >> >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee : >> >> > The value of emul_con was getting overwritten if the selected soc is >> >> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong >> >> > register in the case of SOC_ARCH_EXYNOS5260. >> >> >> >> How the value is overwritten if the soc is Exynos5260? I can't see it >> >> (although the "else if" is still more obvious than "if" but how does >> >> the description match the code?). >> > The code here is: >> > if (data->soc == SOC_ARCH_EXYNOS5260) >> > emul_con = EXYNOS5260_EMUL_CON; >> > if (data->soc == SOC_ARCH_EXYNOS5433) >> > emul_con = EXYNOS5433_TMU_EMUL_CON; >> > else if (data->soc == SOC_ARCH_EXYNOS7) >> > emul_con = EXYNOS7_TMU_REG_EMUL_CON; >> > else >> > emul_con = EXYNOS_EMUL_CON; >> > >> > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes >> > EXYNOS5260_EMUL_CON. But again for the else part it will become >> > EXYNOS_EMUL_CON. >> >> Indeed! >> >> Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU") >> >> Reviewed-by: Krzysztof Kozlowski > > Hi Krzysztof, > Who will pick this one up? I still do not see it in linux-next. Hi! I guess it is a patch for Lukasz. Lukasz, Do you plan to pick it up or maybe this should go through samsung-soc tree? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: fix register read in TMU
Hi Krzysztof, > 2015-10-08 23:21 GMT+09:00 Sudip Mukherjee > : > > On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote: > >> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee > >> : > >> > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski > >> > wrote: > >> >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee > >> >> : > >> >> > The value of emul_con was getting overwritten if the selected > >> >> > soc is SOC_ARCH_EXYNOS5260. And so as a result we were > >> >> > reading from the wrong register in the case of > >> >> > SOC_ARCH_EXYNOS5260. > >> >> > >> >> How the value is overwritten if the soc is Exynos5260? I can't > >> >> see it (although the "else if" is still more obvious than "if" > >> >> but how does the description match the code?). > >> > The code here is: > >> > if (data->soc == SOC_ARCH_EXYNOS5260) > >> > emul_con = EXYNOS5260_EMUL_CON; > >> > if (data->soc == SOC_ARCH_EXYNOS5433) > >> > emul_con = EXYNOS5433_TMU_EMUL_CON; > >> > else if (data->soc == SOC_ARCH_EXYNOS7) > >> > emul_con = EXYNOS7_TMU_REG_EMUL_CON; > >> > else > >> > emul_con = EXYNOS_EMUL_CON; > >> > > >> > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes > >> > EXYNOS5260_EMUL_CON. But again for the else part it will become > >> > EXYNOS_EMUL_CON. > >> > >> Indeed! > >> > >> Fixes: 488c7455d74c ("thermal: exynos: Add the support for > >> Exynos5433 TMU") > >> > >> Reviewed-by: Krzysztof Kozlowski > > > > Hi Krzysztof, > > Who will pick this one up? I still do not see it in linux-next. > > Hi! > > I guess it is a patch for Lukasz. > > Lukasz, > Do you plan to pick it up or maybe this should go through samsung-soc > tree? This is the only one patch, which is waiting in my queue. Since no more fixes available, please feel free to grab this patch to samsung-soc. Acked-by: Lukasz Majewski > > Best regards, > Krzysztof -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: fix register read in TMU
W dniu 09.10.2015 o 21:07, Lukasz Majewski pisze: > Hi Krzysztof, > >> 2015-10-08 23:21 GMT+09:00 Sudip Mukherjee >> : >>> On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote: 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee : > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski > wrote: >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee >> : >>> The value of emul_con was getting overwritten if the selected >>> soc is SOC_ARCH_EXYNOS5260. And so as a result we were >>> reading from the wrong register in the case of >>> SOC_ARCH_EXYNOS5260. >> >> How the value is overwritten if the soc is Exynos5260? I can't >> see it (although the "else if" is still more obvious than "if" >> but how does the description match the code?). > The code here is: > if (data->soc == SOC_ARCH_EXYNOS5260) > emul_con = EXYNOS5260_EMUL_CON; > if (data->soc == SOC_ARCH_EXYNOS5433) > emul_con = EXYNOS5433_TMU_EMUL_CON; > else if (data->soc == SOC_ARCH_EXYNOS7) > emul_con = EXYNOS7_TMU_REG_EMUL_CON; > else > emul_con = EXYNOS_EMUL_CON; > > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes > EXYNOS5260_EMUL_CON. But again for the else part it will become > EXYNOS_EMUL_CON. Indeed! Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU") Reviewed-by: Krzysztof Kozlowski >>> >>> Hi Krzysztof, >>> Who will pick this one up? I still do not see it in linux-next. >> >> Hi! >> >> I guess it is a patch for Lukasz. >> >> Lukasz, >> Do you plan to pick it up or maybe this should go through samsung-soc >> tree? > > This is the only one patch, which is waiting in my queue. Since no more > fixes available, please feel free to grab this patch to samsung-soc. > > Acked-by: Lukasz Majewski Okay, thanks! Applied to fixes for current cycle. I'll it send later to Kukjin (unless he picks it as well). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: Fix register read in TMU
On 10/13/15 08:51, Krzysztof Kozlowski wrote: > From: Sudip Mukherjee > > The value of emul_con was getting overwritten if the selected soc is > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong > register in the case of SOC_ARCH_EXYNOS5260. > > Signed-off-by: Sudip Mukherjee > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: Chanwoo Choi > Acked-by: Lukasz Majewski > Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU") > Signed-off-by: Krzysztof Kozlowski > --- > drivers/thermal/samsung/exynos_tmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c > index 0bae8cc6c23a..ca920b0ecf8f 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct > exynos_tmu_data *data, > > if (data->soc == SOC_ARCH_EXYNOS5260) > emul_con = EXYNOS5260_EMUL_CON; > - if (data->soc == SOC_ARCH_EXYNOS5433) > + else if (data->soc == SOC_ARCH_EXYNOS5433) > emul_con = EXYNOS5433_TMU_EMUL_CON; > else if (data->soc == SOC_ARCH_EXYNOS7) > emul_con = EXYNOS7_TMU_REG_EMUL_CON; Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html