[PATCH] [SCSI] mvsas: Fix warning in mvs_update_phyinfo

2012-10-20 Thread Tom Rini
In mvs_update_phyinfo we were comparing phy->identify.device_type
against enum sas_dev_type instead of enum sas_device_type

Cc: Xiangliang Yu 
Cc: Dan Williams 
Cc: James Bottomley 
Signed-off-by: Tom Rini 
---
 drivers/scsi/mvsas/mv_sas.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index a3776d6..9f91359 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -1153,10 +1153,10 @@ void mvs_update_phyinfo(struct mvs_info *mvi, int i, 
int get_st)
phy->identify.device_type =
phy->att_dev_info & PORT_DEV_TYPE_MASK;
 
-   if (phy->identify.device_type == SAS_END_DEV)
+   if (phy->identify.device_type == SAS_END_DEVICE)
phy->identify.target_port_protocols =
SAS_PROTOCOL_SSP;
-   else if (phy->identify.device_type != NO_DEVICE)
+   else if (phy->identify.device_type != SAS_PHY_UNUSED)
phy->identify.target_port_protocols =
SAS_PROTOCOL_SMP;
if (oob_done)
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


WARNING: at fs/sysfs/inode.c:324 sysfs_hash_and_remove+0xa9/0xb0()

2012-10-20 Thread Richard Weinberger

Hi!

I can reliably trigger the following warning by physically detaching my disk 
array after
stopping md1.

---cut---
[  149.780554] md: md1 stopped.
[  149.780559] md: unbind
[  149.782025] md: export_rdev(sdh1)
[  149.782039] md: unbind
[  149.786026] md: export_rdev(sdg1)
[  149.786038] md: unbind
[  149.786122] md: export_rdev(sdf1)
[  149.786135] md: unbind
[  149.786220] md: export_rdev(sde1)
[  149.786232] md: unbind
[  149.786320] md: export_rdev(sdd1)
[  149.786332] md: unbind
[  149.786414] md: export_rdev(sdc1)
[  162.884735] sd 6:0:1:0: [sdc] Synchronizing SCSI cache
[  162.884778] sd 6:0:1:0: [sdc]
[  162.884781] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK
[  162.885424] mpt2sas0: removing handle(0x000b), sas_addr(0x5003048001804ded)
[  162.887671] sd 6:0:2:0: [sdd] Synchronizing SCSI cache
[  162.887715] sd 6:0:2:0: [sdd]
[  162.887719] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK
[  162.888733] mpt2sas0: removing handle(0x000c), sas_addr(0x5003048001804dee)
[  162.890003] sd 6:0:3:0: [sde] Synchronizing SCSI cache
[  162.890041] sd 6:0:3:0: [sde]
[  162.890044] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK
[  162.890676] mpt2sas0: removing handle(0x000d), sas_addr(0x5003048001804df0)
[  162.891345] sd 6:0:4:0: [sdf] Synchronizing SCSI cache
[  162.891383] sd 6:0:4:0: [sdf]
[  162.891385] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK
[  162.892590] mpt2sas0: removing handle(0x000e), sas_addr(0x5003048001804df1)
[  162.896152] sd 6:0:5:0: [sdg] Synchronizing SCSI cache
[  162.896197] sd 6:0:5:0: [sdg]
[  162.896201] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK
[  162.896891] mpt2sas0: removing handle(0x000f), sas_addr(0x5003048001804df4)
[  162.896896] mpt2sas0: removing handle(0x000a), sas_addr(0x5003048001804dfd)
[  162.896899] mpt2sas0: removing handle(0x0010), sas_addr(0x5003048001804df7)
[  162.898097] [ cut here ]
[  162.898105] WARNING: at /home/abuild/rpmbuild/BUILD/kernel-vanilla-3.6.2/linux-3.6/fs/sysfs/inode.c:324 
sysfs_hash_and_remove+0xa9/0xb0()

[  162.898107] Hardware name: X9SCL/X9SCM
[  162.898108] sysfs: can not remove 'device', no directory
[  162.898110] Modules linked in: ses enclosure cpufreq_conservative cpufreq_userspace cpufreq_powersave acpi_cpufreq 
mperf coretemp crc32c_intel ghash_clmulni_intel i2c_i801 iTCO_wdt kvm_intel sg iTCO_vendor_support e1000e lpc_ich 
mfd_core serio_raw joydev sr_mod kvm aesni_intel button cdrom ablk_helper cryptd video aes_x86_64 pcspkr microcode 
autofs4 raid456 async_raid6_recov async_pq raid6_pq async_xor xor async_memcpy async_tx raid10 raid1 hid_generic usbhid 
raid0 mgag200 ttm drm_kms_helper drm ehci_hcd i2c_algo_bit sysimgblt sysfillrect syscopyarea usbcore usb_common thermal 
fan processor thermal_sys scsi_dh_emc scsi_dh_rdac scsi_dh_alua scsi_dh_hp_sw scsi_dh mpt2sas scsi_transport_sas raid_class

[  162.898159] Pid: 84, comm: kworker/u:7 Not tainted 3.6.2-7-vanilla #1
[  162.898161] Call Trace:
[  162.898166]  [] ? sysfs_hash_and_remove+0xa0/0xb0
[  162.898172]  [] warn_slowpath_common+0x7a/0xb0
[  162.898176]  [] warn_slowpath_fmt+0x41/0x50
[  162.898180]  [] sysfs_hash_and_remove+0xa9/0xb0
[  162.898184]  [] sysfs_remove_link+0x21/0x30
[  162.898189]  [] enclosure_remove_links+0x68/0x80 
[enclosure]
[  162.898192]  [] ? remove_dir+0x2e/0x40
[  162.898196]  [] enclosure_component_release+0x1f/0x40 
[enclosure]
[  162.898200]  [] device_release+0x22/0x90
[  162.898205]  [] kobject_cleanup+0x82/0x1b0
[  162.898209]  [] kobject_put+0x2b/0x60
[  162.898212]  [] put_device+0x12/0x20
[  162.898215]  [] device_unregister+0x25/0x60
[  162.898218]  [] enclosure_unregister+0x82/0xb0 [enclosure]
[  162.898222]  [] ses_intf_remove+0x7d/0xe0 [ses]
[  162.898226]  [] device_del+0xc9/0x1b0
[  162.898230]  [] device_unregister+0x1d/0x60
[  162.898236]  [] __scsi_remove_device+0xa5/0xc0
[  162.898241]  [] scsi_remove_device+0x2a/0x40
[  162.898246]  [] scsi_remove_target+0x148/0x200
[  162.898256]  [] sas_rphy_remove+0x55/0x60 
[scsi_transport_sas]
[  162.898264]  [] sas_rphy_delete+0x11/0x20 
[scsi_transport_sas]
[  162.898273]  [] sas_port_delete+0x25/0x130 
[scsi_transport_sas]
[  162.898281]  [] ? sas_port_delete+0x130/0x130 
[scsi_transport_sas]
[  162.898290]  [] do_sas_phy_delete+0x45/0x50 
[scsi_transport_sas]
[  162.898294]  [] device_for_each_child+0x36/0x70
[  162.898302]  [] sas_remove_children+0x1a/0x40 
[scsi_transport_sas]
[  162.898310]  [] sas_rphy_remove+0x4a/0x60 
[scsi_transport_sas]
[  162.898318]  [] sas_rphy_delete+0x11/0x20 
[scsi_transport_sas]
[  162.898325]  [] sas_port_delete+0x25/0x130 
[scsi_transport_sas]
[  162.898337]  [] mpt2sas_transport_port_remove+0x1b9/0x1d0 
[mpt2sas]
[  162.898348]  [] _scsih_expander_node_remove+0x80/0xc0 
[mpt2sas]
[  162.898357]  [] mpt2sas_expander_remove+0xcc/0xe0 [mpt2sas]
[  162.898367]  [] _firmware_event_work+0x11e7/0x14b0 
[mpt2sas]
[  162.898372]  [] ? cwq_activate_delayed_work+0x38/0x80
[  162.898376]  [] proc