Re: [PATCH] bnx2i: missing error code in bnx2i_ep_connect()
Dan, > If bnx2i_map_ep_dbell_regs() then we accidentally return NULL instead > of an error pointer. It results in a NULL dereference in > iscsi_if_ep_connect(). Applied to 4.13/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] bnx2i: missing error code in bnx2i_ep_connect()
On Fri, Jun 23, 2017 at 10:02:00AM +0300, Dan Carpenter wrote: > If bnx2i_map_ep_dbell_regs() then we accidentally return NULL instead > of an error pointer. It results in a NULL dereference in > iscsi_if_ep_connect(). > > Fixes: cf4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.") > Signed-off-by: Dan Carpenter > Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[PATCH] bnx2i: missing error code in bnx2i_ep_connect()
If bnx2i_map_ep_dbell_regs() then we accidentally return NULL instead of an error pointer. It results in a NULL dereference in iscsi_if_ep_connect(). Fixes: cf4e6363859d ("[SCSI] bnx2i: Add bnx2i iSCSI driver.") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c index f32a66f89d25..03c104b47f31 100644 --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c @@ -1909,7 +1909,8 @@ static struct iscsi_endpoint *bnx2i_ep_connect(struct Scsi_Host *shost, bnx2i_ep_active_list_add(hba, bnx2i_ep); - if (bnx2i_map_ep_dbell_regs(bnx2i_ep)) + rc = bnx2i_map_ep_dbell_regs(bnx2i_ep); + if (rc) goto del_active_ep; mutex_unlock(&hba->net_dev_lock);