Re: [PATCH] scsi: lpfc: Replace pci_pool_alloc by pci_pool_zalloc

[Martin K. Petersen]

> "Souptick" == Souptick Joarder  writes:

Souptick> In lpfc_new_scsi_buf_s3() and lpfc_new_scsi_buf_s4()
Souptick> pci_pool_alloc followed by memset will be replaced by
Souptick> pci_pool_zalloc()

Applied to 4.10/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: lpfc: Replace pci_pool_alloc by pci_pool_zalloc

[Martin K. Petersen]

> "Souptick" == Souptick Joarder  writes:

Souptick> In lpfc_new_scsi_buf_s3() and lpfc_new_scsi_buf_s4()
Souptick> pci_pool_alloc followed by memset will be replaced by
Souptick> pci_pool_zalloc()

James, Dick: Please review!

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: lpfc: Replace pci_pool_alloc by pci_pool_zalloc

[Johannes Thumshirn]

On Mon, Nov 28, 2016 at 03:22:37PM +0530, Souptick Joarder wrote:
> In lpfc_new_scsi_buf_s3() and lpfc_new_scsi_buf_s4() pci_pool_alloc
> followed by memset will be replaced by pci_pool_zalloc()
> 
> Signed-off-by: Souptick joarder 
> ---

Looks good,
Reviewed-by: Johannes Thumshirn 

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] scsi: lpfc: Replace pci_pool_alloc by pci_pool_zalloc

[Souptick Joarder]

In lpfc_new_scsi_buf_s3() and lpfc_new_scsi_buf_s4() pci_pool_alloc
followed by memset will be replaced by pci_pool_zalloc()

Signed-off-by: Souptick joarder 
---
 drivers/scsi/lpfc/lpfc_scsi.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index d197aa1..58851c7 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -413,15 +413,13 @@ struct scsi_dif_tuple {
 * struct fcp_cmnd, struct fcp_rsp and the number of bde's
 * necessary to support the sg_tablesize.
 */
-   psb->data = pci_pool_alloc(phba->lpfc_scsi_dma_buf_pool,
+   psb->data = pci_pool_zalloc(phba->lpfc_scsi_dma_buf_pool,
GFP_KERNEL, >dma_handle);
if (!psb->data) {
kfree(psb);
break;
}
 
-   /* Initialize virtual ptrs to dma_buf region. */
-   memset(psb->data, 0, phba->cfg_sg_dma_buf_size);
 
/* Allocate iotag for psb->cur_iocbq. */
iotag = lpfc_sli_next_iotag(phba, >cur_iocbq);
@@ -821,13 +819,12 @@ struct scsi_dif_tuple {
 * for the struct fcp_cmnd, struct fcp_rsp and the number
 * of bde's necessary to support the sg_tablesize.
 */
-   psb->data = pci_pool_alloc(phba->lpfc_scsi_dma_buf_pool,
+   psb->data = pci_pool_zalloc(phba->lpfc_scsi_dma_buf_pool,
GFP_KERNEL, >dma_handle);
if (!psb->data) {
kfree(psb);
break;
}
-   memset(psb->data, 0, phba->cfg_sg_dma_buf_size);
 
/*
 * 4K Page alignment is CRITICAL to BlockGuard, double check
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html