Re: [PATCH 2.6.24] sym53c8xx_2 modpost section mismatch fix

2008-01-26 Thread Mikael Pettersson 
Sam Ravnborg writes:
 > On Sat, Jan 26, 2008 at 07:03:15PM +0100, Mikael Pettersson wrote:
 > > Building 2.6.24 with
 > > 
 > > # CONFIG_HOTPLUG is not set
 > > CONFIG_SCSI_SYM53C8XX_2=y
 > > 
 > > results in the following during modpost:
 > > 
 > > WARNING: vmlinux.o(.text+0x14b36c): Section mismatch: reference to 
 > > .exit.text:sym2_remove (between 'sym2_io_error_detected' and 
 > > 'sym_set_cam_result_error')
 > > 
 > > because sym2_io_error_detected() calls sym2_remove(), which is marked 
 > > __devexit.
 > > 
 > > Fixed by removing the __devexit from sym2_remove().
 > > 
 > > Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
 > > ---
 > > Resend. Previously reported against 2.6.24-rc6 on 2007-12-15.
 > 
 > Fixed in upstream kernel by
 > commit: 864473cbe99e95a57ad496894768cd77a567

Great, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.24] sym53c8xx_2 modpost section mismatch fix

2008-01-26 Thread Sam Ravnborg 
On Sat, Jan 26, 2008 at 07:03:15PM +0100, Mikael Pettersson wrote:
> Building 2.6.24 with
> 
> # CONFIG_HOTPLUG is not set
> CONFIG_SCSI_SYM53C8XX_2=y
> 
> results in the following during modpost:
> 
> WARNING: vmlinux.o(.text+0x14b36c): Section mismatch: reference to 
> .exit.text:sym2_remove (between 'sym2_io_error_detected' and 
> 'sym_set_cam_result_error')
> 
> because sym2_io_error_detected() calls sym2_remove(), which is marked 
> __devexit.
> 
> Fixed by removing the __devexit from sym2_remove().
> 
> Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
> ---
> Resend. Previously reported against 2.6.24-rc6 on 2007-12-15.

Fixed in upstream kernel by
commit: 864473cbe99e95a57ad496894768cd77a567

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2.6.24] sym53c8xx_2 modpost section mismatch fix

2008-01-26 Thread Mikael Pettersson 
Building 2.6.24 with

# CONFIG_HOTPLUG is not set
CONFIG_SCSI_SYM53C8XX_2=y

results in the following during modpost:

WARNING: vmlinux.o(.text+0x14b36c): Section mismatch: reference to 
.exit.text:sym2_remove (between 'sym2_io_error_detected' and 
'sym_set_cam_result_error')

because sym2_io_error_detected() calls sym2_remove(), which is marked __devexit.

Fixed by removing the __devexit from sym2_remove().

Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
---
Resend. Previously reported against 2.6.24-rc6 on 2007-12-15.

--- linux-2.6.24-rc5/drivers/scsi/sym53c8xx_2/sym_glue.c.~1~2007-12-15 
15:37:04.0 +0100
+++ linux-2.6.24-rc5/drivers/scsi/sym53c8xx_2/sym_glue.c2007-12-15 
16:22:08.0 +0100
@@ -1744,7 +1744,7 @@ static int __devinit sym2_probe(struct p
return -ENODEV;
 }
 
-static void __devexit sym2_remove(struct pci_dev *pdev)
+static void sym2_remove(struct pci_dev *pdev)
 {
struct Scsi_Host *shost = pci_get_drvdata(pdev);
 
@@ -2056,7 +2056,7 @@ static struct pci_driver sym2_driver = {
.name   = NAME53C8XX,
.id_table   = sym2_id_table,
.probe  = sym2_probe,
-   .remove = __devexit_p(sym2_remove),
+   .remove = sym2_remove,
.err_handler= &sym2_err_handler,
 };
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html