Re: [PATCH] be2iscsi: add an missing goto in error path
On Jun 6, 2014, at 7:06 AM, Tomas Henzl wrote: > a jump to 'free_memory' is apparently missing > > Signed-off-by: Tomas Henzl > --- > diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c > index ac54cf5..442982d 100644 > --- a/drivers/scsi/be2iscsi/be_main.c > +++ b/drivers/scsi/be2iscsi/be_main.c > @@ -4209,6 +4209,8 @@ static int hba_setup_cid_tbls(struct beiscsi_hba *phba) > kfree(phba->ep_array); > phba->ep_array = NULL; > ret = -ENOMEM; > + > + goto free_memory; > } > > for (i = 0; i < phba->params.cxns_per_ctrl; i++) { > — Thanks. Reviewed-by: Mike Christie -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] be2iscsi: add an missing goto in error path
On Fri, Jun 06, 2014 at 02:06:30PM +0200, Tomas Henzl wrote: > a jump to 'free_memory' is apparently missing > > Signed-off-by: Tomas Henzl Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] be2iscsi: add an missing goto in error path
a jump to 'free_memory' is apparently missing Signed-off-by: Tomas Henzl --- diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index ac54cf5..442982d 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -4209,6 +4209,8 @@ static int hba_setup_cid_tbls(struct beiscsi_hba *phba) kfree(phba->ep_array); phba->ep_array = NULL; ret = -ENOMEM; + + goto free_memory; } for (i = 0; i < phba->params.cxns_per_ctrl; i++) { -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html