Re: [PATCH] megaraid_sas: Add support for MegaRAID Aero controllers

[Shivasharan Srikanteshwara]

On Fri, Nov 9, 2018 at 7:43 AM Martin K. Petersen
 wrote:
> Shivasharan,
>
> > This patch adds support for MegaRAID Aero controller PCI IDs.
> > Throw a warning message when a Configurable secure type controller is
> > encountered.
>
> > + dev_warn(&pdev->dev, "Adapter is in configurable secure 
> > mode\n");
>
> Why warn and not info?

Hi Martin,
Agree that a dev_info would be the better choice here instead of warn.
Will send out v2 of this patch with the change.

Thanks,
Shivasharan
>
> --
> Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] megaraid_sas: Add support for MegaRAID Aero controllers

[Martin K. Petersen]

Shivasharan,

> This patch adds support for MegaRAID Aero controller PCI IDs.
> Throw a warning message when a Configurable secure type controller is
> encountered.

> + dev_warn(&pdev->dev, "Adapter is in configurable secure 
> mode\n");

Why warn and not info?

-- 
Martin K. Petersen  Oracle Linux Engineering

[PATCH] megaraid_sas: Add support for MegaRAID Aero controllers

[Shivasharan S]

This patch adds support for MegaRAID Aero controller PCI IDs.
Throw a warning message when a Configurable secure type controller is
encountered.

Signed-off-by: Shivasharan S 
---
 drivers/scsi/megaraid/megaraid_sas.h  |  4 
 drivers/scsi/megaraid/megaraid_sas_base.c | 15 +++
 2 files changed, 19 insertions(+)

diff --git a/drivers/scsi/megaraid/megaraid_sas.h 
b/drivers/scsi/megaraid/megaraid_sas.h
index 8edba2227cd3..55f6662ceb55 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -60,6 +60,10 @@
 #define PCI_DEVICE_ID_LSI_TOMCAT   0x0017
 #define PCI_DEVICE_ID_LSI_VENTURA_4PORT0x001B
 #define PCI_DEVICE_ID_LSI_CRUSADER_4PORT   0x001C
+#define PCI_DEVICE_ID_LSI_AERO_10E10x10e1
+#define PCI_DEVICE_ID_LSI_AERO_10E20x10e2
+#define PCI_DEVICE_ID_LSI_AERO_10E50x10e5
+#define PCI_DEVICE_ID_LSI_AERO_10E60x10e6
 
 /*
  * Intel HBA SSDIDs
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c 
b/drivers/scsi/megaraid/megaraid_sas_base.c
index 27fab13c55ea..bc8e4d91d34b 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -162,6 +162,10 @@ static struct pci_device_id megasas_pci_table[] = {
{PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_TOMCAT)},
{PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_VENTURA_4PORT)},
{PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_CRUSADER_4PORT)},
+   {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_AERO_10E1)},
+   {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_AERO_10E2)},
+   {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_AERO_10E5)},
+   {PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_AERO_10E6)},
{}
 };
 
@@ -6235,6 +6239,10 @@ static inline void megasas_set_adapter_type(struct 
megasas_instance *instance)
instance->adapter_type = MFI_SERIES;
} else {
switch (instance->pdev->device) {
+   case PCI_DEVICE_ID_LSI_AERO_10E1:
+   case PCI_DEVICE_ID_LSI_AERO_10E2:
+   case PCI_DEVICE_ID_LSI_AERO_10E5:
+   case PCI_DEVICE_ID_LSI_AERO_10E6:
case PCI_DEVICE_ID_LSI_VENTURA:
case PCI_DEVICE_ID_LSI_CRUSADER:
case PCI_DEVICE_ID_LSI_HARPOON:
@@ -6598,6 +6606,13 @@ static int megasas_probe_one(struct pci_dev *pdev,
struct megasas_instance *instance;
u16 control = 0;
 
+   switch (pdev->device) {
+   case PCI_DEVICE_ID_LSI_AERO_10E1:
+   case PCI_DEVICE_ID_LSI_AERO_10E5:
+   dev_warn(&pdev->dev, "Adapter is in configurable secure 
mode\n");
+   break;
+   }
+
/* Reset MSI-X in the kdump kernel */
if (reset_devices) {
pos = pci_find_capability(pdev, PCI_CAP_ID_MSIX);
-- 
2.16.1