Re: [PATCH 02/11] target_core_alua: Store supported ALUA states
On 10/16/2013 11:19 PM, Nicholas A. Bellinger wrote:
> On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote:
>> The supported ALUA states might be different for individual
>> devices, so store it in a separate field.
>>
>> Signed-off-by: Hannes Reinecke
>> ---
>> drivers/target/target_core_alua.c | 14 --
>> drivers/target/target_core_alua.h | 11 +++
>> include/target/target_core_base.h | 1 +
>> 3 files changed, 20 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/target/target_core_alua.c
>> b/drivers/target/target_core_alua.c
>> index 8297d37..255e83c 100644
>> --- a/drivers/target/target_core_alua.c
>> +++ b/drivers/target/target_core_alua.c
>> @@ -117,12 +117,7 @@ target_emulate_report_target_port_groups(struct se_cmd
>> *cmd)
>> /*
>> * Set supported ASYMMETRIC ACCESS State bits
>> */
>> -buf[off] = 0x80; /* T_SUP */
>> -buf[off] |= 0x40; /* O_SUP */
>> -buf[off] |= 0x8; /* U_SUP */
>> -buf[off] |= 0x4; /* S_SUP */
>> -buf[off] |= 0x2; /* AN_SUP */
>> -buf[off++] |= 0x1; /* AO_SUP */
>> +buf[off++] |= tg_pt_gp->tg_pt_gp_alua_supported_states;
>> /*
>> * TARGET PORT GROUP
>> */
>> @@ -1367,6 +1362,13 @@ struct t10_alua_tg_pt_gp
>> *core_alua_allocate_tg_pt_gp(struct se_device *dev,
>> tg_pt_gp->tg_pt_gp_trans_delay_msecs = ALUA_DEFAULT_TRANS_DELAY_MSECS;
>> tg_pt_gp->tg_pt_gp_implicit_trans_secs =
>> ALUA_DEFAULT_IMPLICIT_TRANS_SECS;
>>
>> +/*
>> + * Enable all supported states
>> + */
>> +tg_pt_gp->tg_pt_gp_alua_supported_states =
>> +ALUA_T_SUP | ALUA_O_SUP | \
>> +ALUA_U_SUP | ALUA_S_SUP | ALUA_AN_SUP | ALUA_AO_SUP;
>> +
>> if (def_group) {
>> spin_lock(&dev->t10_alua.tg_pt_gps_lock);
>> tg_pt_gp->tg_pt_gp_id =
>> diff --git a/drivers/target/target_core_alua.h
>> b/drivers/target/target_core_alua.h
>> index 74cf0c0..e826a65 100644
>> --- a/drivers/target/target_core_alua.h
>> +++ b/drivers/target/target_core_alua.h
>> @@ -23,6 +23,17 @@
>> #define ALUA_ACCESS_STATE_TRANSITION0xf
>>
>> /*
>> + * from spc4r36j section 6.37 Table 306
>> + */
>> +#define ALUA_T_SUP 0x80
>> +#define ALUA_O_SUP 0x40
>> +#define ALUA_LBD_SUP0x10
>> +#define ALUA_U_SUP 0x08
>> +#define ALUA_S_SUP 0x04
>> +#define ALUA_AN_SUP 0x02
>> +#define ALUA_AO_SUP 0x01
>> +
>> +/*
>
> How about making these the supported bits, TPGS mode, and ALUA access
> state definitions common between target_core_alua.c and
> scsi_dh_alua.c..?
>
Sure. Good idea.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 02/11] target_core_alua: Store supported ALUA states
On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote:
> The supported ALUA states might be different for individual
> devices, so store it in a separate field.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/target/target_core_alua.c | 14 --
> drivers/target/target_core_alua.h | 11 +++
> include/target/target_core_base.h | 1 +
> 3 files changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/target/target_core_alua.c
> b/drivers/target/target_core_alua.c
> index 8297d37..255e83c 100644
> --- a/drivers/target/target_core_alua.c
> +++ b/drivers/target/target_core_alua.c
> @@ -117,12 +117,7 @@ target_emulate_report_target_port_groups(struct se_cmd
> *cmd)
> /*
>* Set supported ASYMMETRIC ACCESS State bits
>*/
> - buf[off] = 0x80; /* T_SUP */
> - buf[off] |= 0x40; /* O_SUP */
> - buf[off] |= 0x8; /* U_SUP */
> - buf[off] |= 0x4; /* S_SUP */
> - buf[off] |= 0x2; /* AN_SUP */
> - buf[off++] |= 0x1; /* AO_SUP */
> + buf[off++] |= tg_pt_gp->tg_pt_gp_alua_supported_states;
> /*
>* TARGET PORT GROUP
>*/
> @@ -1367,6 +1362,13 @@ struct t10_alua_tg_pt_gp
> *core_alua_allocate_tg_pt_gp(struct se_device *dev,
> tg_pt_gp->tg_pt_gp_trans_delay_msecs = ALUA_DEFAULT_TRANS_DELAY_MSECS;
> tg_pt_gp->tg_pt_gp_implicit_trans_secs =
> ALUA_DEFAULT_IMPLICIT_TRANS_SECS;
>
> + /*
> + * Enable all supported states
> + */
> + tg_pt_gp->tg_pt_gp_alua_supported_states =
> + ALUA_T_SUP | ALUA_O_SUP | \
> + ALUA_U_SUP | ALUA_S_SUP | ALUA_AN_SUP | ALUA_AO_SUP;
> +
> if (def_group) {
> spin_lock(&dev->t10_alua.tg_pt_gps_lock);
> tg_pt_gp->tg_pt_gp_id =
> diff --git a/drivers/target/target_core_alua.h
> b/drivers/target/target_core_alua.h
> index 74cf0c0..e826a65 100644
> --- a/drivers/target/target_core_alua.h
> +++ b/drivers/target/target_core_alua.h
> @@ -23,6 +23,17 @@
> #define ALUA_ACCESS_STATE_TRANSITION 0xf
>
> /*
> + * from spc4r36j section 6.37 Table 306
> + */
> +#define ALUA_T_SUP 0x80
> +#define ALUA_O_SUP 0x40
> +#define ALUA_LBD_SUP 0x10
> +#define ALUA_U_SUP 0x08
> +#define ALUA_S_SUP 0x04
> +#define ALUA_AN_SUP 0x02
> +#define ALUA_AO_SUP 0x01
> +
> +/*
How about making these the supported bits, TPGS mode, and ALUA access
state definitions common between target_core_alua.c and
scsi_dh_alua.c..?
--nab
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 02/11] target_core_alua: Store supported ALUA states
The supported ALUA states might be different for individual
devices, so store it in a separate field.
Signed-off-by: Hannes Reinecke
---
drivers/target/target_core_alua.c | 14 --
drivers/target/target_core_alua.h | 11 +++
include/target/target_core_base.h | 1 +
3 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/drivers/target/target_core_alua.c
b/drivers/target/target_core_alua.c
index 8297d37..255e83c 100644
--- a/drivers/target/target_core_alua.c
+++ b/drivers/target/target_core_alua.c
@@ -117,12 +117,7 @@ target_emulate_report_target_port_groups(struct se_cmd
*cmd)
/*
* Set supported ASYMMETRIC ACCESS State bits
*/
- buf[off] = 0x80; /* T_SUP */
- buf[off] |= 0x40; /* O_SUP */
- buf[off] |= 0x8; /* U_SUP */
- buf[off] |= 0x4; /* S_SUP */
- buf[off] |= 0x2; /* AN_SUP */
- buf[off++] |= 0x1; /* AO_SUP */
+ buf[off++] |= tg_pt_gp->tg_pt_gp_alua_supported_states;
/*
* TARGET PORT GROUP
*/
@@ -1367,6 +1362,13 @@ struct t10_alua_tg_pt_gp
*core_alua_allocate_tg_pt_gp(struct se_device *dev,
tg_pt_gp->tg_pt_gp_trans_delay_msecs = ALUA_DEFAULT_TRANS_DELAY_MSECS;
tg_pt_gp->tg_pt_gp_implicit_trans_secs =
ALUA_DEFAULT_IMPLICIT_TRANS_SECS;
+ /*
+* Enable all supported states
+*/
+ tg_pt_gp->tg_pt_gp_alua_supported_states =
+ ALUA_T_SUP | ALUA_O_SUP | \
+ ALUA_U_SUP | ALUA_S_SUP | ALUA_AN_SUP | ALUA_AO_SUP;
+
if (def_group) {
spin_lock(&dev->t10_alua.tg_pt_gps_lock);
tg_pt_gp->tg_pt_gp_id =
diff --git a/drivers/target/target_core_alua.h
b/drivers/target/target_core_alua.h
index 74cf0c0..e826a65 100644
--- a/drivers/target/target_core_alua.h
+++ b/drivers/target/target_core_alua.h
@@ -23,6 +23,17 @@
#define ALUA_ACCESS_STATE_TRANSITION 0xf
/*
+ * from spc4r36j section 6.37 Table 306
+ */
+#define ALUA_T_SUP 0x80
+#define ALUA_O_SUP 0x40
+#define ALUA_LBD_SUP 0x10
+#define ALUA_U_SUP 0x08
+#define ALUA_S_SUP 0x04
+#define ALUA_AN_SUP0x02
+#define ALUA_AO_SUP0x01
+
+/*
* REPORT_TARGET_PORT_GROUP STATUS CODE
*
* from spc4r17 section 6.27 Table 246
diff --git a/include/target/target_core_base.h
b/include/target/target_core_base.h
index 1c6e54d..21f4bd5 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -282,6 +282,7 @@ struct t10_alua_lu_gp_member {
struct t10_alua_tg_pt_gp {
u16 tg_pt_gp_id;
int tg_pt_gp_valid_id;
+ int tg_pt_gp_alua_supported_states;
int tg_pt_gp_alua_access_status;
int tg_pt_gp_alua_access_type;
int tg_pt_gp_nonop_delay_msecs;
--
1.7.12.4
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
