Re: [PATCH 1/4] gdth: Split out EISA and ISA register code

2007-07-21 Thread Andi Kleen 
Jeff Garzik <[EMAIL PROTECTED]> writes:

> No code changes, only indentation and blank line additions, plus code to
> call the new split-out functions.

Could you put the ISA code into #ifdef CONFIG_ISA while you're on it? 

That would allow dropping it on x86-64 

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] gdth: Split out EISA and ISA register code

2007-07-21 Thread Christoph Hellwig 
On Fri, Jul 20, 2007 at 10:20:32PM -0400, Jeff Garzik wrote:
> 
> No code changes, only indentation and blank line additions, plus code to
> call the new split-out functions.

I have patches that do this and do a few things better (e.g. proper CONFIG_ISA
ifdefs instead of the ia64 hacks).  I'll send it out in a minute.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] gdth: Split out EISA and ISA register code

2007-07-20 Thread Jeff Garzik 

Notes:

1) If this is stomping on Christoph's work or anyone else's, feel free 
to discard.  This is some "I was bored" PCI hotplug prep work, not a 
high priority at all.


2) This is to be applied on top of the previous gdth patch "remove 
redundant PCI stuff".


3) These changes can be found via git at 
git://git.kernel.org/.../jgarzik/misc-2.6.git#gdth



-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html