Re: [PATCH v2] xhci: extend quirk for Renesas cards
On Wed, 2014-03-12 at 10:59 -0700, Sarah Sharp wrote: > Mathias, this is fine to apply as-is. Since it's after -rc6, Greg's > tree is probably now frozen. Stick this patch in your queue for > usb-linus, mark it for stable, and send it off once 3.15-rc1 is out. > > Igor, please do not add Signed-off-by lines unless the developer > explicitly types those words. Same with Acked-by lines. Ok. sorry about this. > Sarah Sharp > > On Wed, Mar 12, 2014 at 11:16:24AM +0400, Igor Gnatenko wrote: > > After suspend another Renesas PCI-X USB 3.0 card doesn't work. > > [root@fedora-20 ~]# lspci -vmnnd 1912: > > Device: 03:00.0 > > Class: USB controller [0c03] > > Vendor: Renesas Technology Corp. [1912] > > Device: uPD720202 USB 3.0 Host Controller [0015] > > SVendor:Renesas Technology Corp. [1912] > > SDevice:uPD720202 USB 3.0 Host Controller [0015] > > Rev:02 > > ProgIf: 30 > > > > Reported-and-tested-by: Anatoly Kharchenko > > Reference: http://redmine.russianfedora.pro/issues/1315 > > Signed-off-by: Igor Gnatenko > > Signed-off-by: Mathias Nyman > > --- > > drivers/usb/host/xhci-pci.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > > index 04f986d..13d4add 100644 > > --- a/drivers/usb/host/xhci-pci.c > > +++ b/drivers/usb/host/xhci-pci.c > > @@ -143,9 +143,7 @@ static void xhci_pci_quirks(struct device *dev, struct > > xhci_hcd *xhci) > > xhci->quirks |= XHCI_TRUST_TX_LENGTH; > > } > > if (pdev->vendor == PCI_VENDOR_ID_RENESAS && > > - pdev->device == 0x0015 && > > - pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG && > > - pdev->subsystem_device == 0xc0cd) > > + pdev->device == 0x0015) > > xhci->quirks |= XHCI_RESET_ON_RESUME; > > if (pdev->vendor == PCI_VENDOR_ID_VIA) > > xhci->quirks |= XHCI_RESET_ON_RESUME; > > -- > > 1.9.0 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > > the body of a message to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- -Igor Gnatenko -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] xhci: extend quirk for Renesas cards
After suspend another Renesas PCI-X USB 3.0 card doesn't work. [root@fedora-20 ~]# lspci -vmnnd 1912: Device: 03:00.0 Class: USB controller [0c03] Vendor: Renesas Technology Corp. [1912] Device: uPD720202 USB 3.0 Host Controller [0015] SVendor:Renesas Technology Corp. [1912] SDevice:uPD720202 USB 3.0 Host Controller [0015] Rev:02 ProgIf: 30 Reported-and-tested-by: Anatoly Kharchenko Reference: http://redmine.russianfedora.pro/issues/1315 Signed-off-by: Igor Gnatenko Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 04f986d..13d4add 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -143,9 +143,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) xhci->quirks |= XHCI_TRUST_TX_LENGTH; } if (pdev->vendor == PCI_VENDOR_ID_RENESAS && - pdev->device == 0x0015 && - pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG && - pdev->subsystem_device == 0xc0cd) + pdev->device == 0x0015) xhci->quirks |= XHCI_RESET_ON_RESUME; if (pdev->vendor == PCI_VENDOR_ID_VIA) xhci->quirks |= XHCI_RESET_ON_RESUME; -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] xhci: extend quirk for Renesas cards
On Tue, 2014-03-11 at 18:50 +0200, Mathias Nyman wrote: > On 03/11/2014 04:54 PM, Anatoly C.K. wrote: > > Igor do not have this card. > > > > [root@fedora-20 ~]# lspci -vmnnd 1912: > > Device: 03:00.0 > > Class: USB controller [0c03] > > Vendor: Renesas Technology Corp. [1912] > > Device: uPD720202 USB 3.0 Host Controller [0015] > > SVendor:Renesas Technology Corp. [1912] > > SDevice:uPD720202 USB 3.0 Host Controller [0015] > > Rev:02 > > ProgIf: 30 > > > > Thanks, > > I think that as the host chip and add-on card are both made by Renesas > we can assume this quirk is needed for all renesas uPD720202 hosts. > > If this is ok with Sarah I think we can apply the patch as is. Thank you. I'll resend patch in 1-2m with updated description, fixed reporter Last Name and added signed-off for you. > -Mathias > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- -Igor Gnatenko -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] xhci: extend quirk for Renesas cards
On Mon, 2014-03-10 at 15:06 +0200, Mathias Nyman wrote: > On 03/09/2014 04:20 PM, Igor Gnatenko wrote: > > After suspend another Renesas PCI-X USB 3.0 card doesn't work. > > 03:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720202 USB 3.0 > > Host Controller [1912:0015] (rev 02) (prog-if 30 [XHCI]) > > > > Reported-and-tested-by: Anatoly K. > > Reference: http://redmine.russianfedora.pro/issues/1315 > > Signed-off-by: Igor Gnatenko > > --- > > drivers/usb/host/xhci-pci.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > > index 04f986d..13d4add 100644 > > --- a/drivers/usb/host/xhci-pci.c > > +++ b/drivers/usb/host/xhci-pci.c > > @@ -143,9 +143,7 @@ static void xhci_pci_quirks(struct device *dev, struct > > xhci_hcd *xhci) > > xhci->quirks |= XHCI_TRUST_TX_LENGTH; > > } > > if (pdev->vendor == PCI_VENDOR_ID_RENESAS && > > - pdev->device == 0x0015 && > > - pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG && > > - pdev->subsystem_device == 0xc0cd) > > + pdev->device == 0x0015) > > xhci->quirks |= XHCI_RESET_ON_RESUME; > > if (pdev->vendor == PCI_VENDOR_ID_VIA) > > xhci->quirks |= XHCI_RESET_ON_RESUME; > > > > This will set the resume quirk for all devices with a Renesas uPD720202 > host. > > Do they all need this quirk, or should just this card manufacturer be > added to the quirk? (subsystem vendor/device) I can't determine whay subsystem_(vendor|device) is needed for this card. If you can help me determine this info - I can resend patch with adding new quirk only for this device. > > -Mathias -- -Igor Gnatenko -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] xhci: extend quirk for Renesas cards
After suspend another Renesas PCI-X USB 3.0 card doesn't work. 03:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720202 USB 3.0 Host Controller [1912:0015] (rev 02) (prog-if 30 [XHCI]) Reported-and-tested-by: Anatoly K. Reference: http://redmine.russianfedora.pro/issues/1315 Signed-off-by: Igor Gnatenko --- drivers/usb/host/xhci-pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 04f986d..13d4add 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -143,9 +143,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) xhci->quirks |= XHCI_TRUST_TX_LENGTH; } if (pdev->vendor == PCI_VENDOR_ID_RENESAS && - pdev->device == 0x0015 && - pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG && - pdev->subsystem_device == 0xc0cd) + pdev->device == 0x0015) xhci->quirks |= XHCI_RESET_ON_RESUME; if (pdev->vendor == PCI_VENDOR_ID_VIA) xhci->quirks |= XHCI_RESET_ON_RESUME; -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: asix: fix bad header length bug
On Thu, 2014-02-06 at 13:56 +0100, Emil Goode wrote: > The AX88772B occasionally send rx packets that cross urb boundaries > and the remaining partial packet is sent with no header. > When the buffer with a partial packet is of less number of octets > than the value of hard_header_len the buffer is discarded by the > usbnet module. This is causing dropped packages and error messages > in dmesg. > > This can be reproduced by using ping with a packet size > between 1965-1976. > > The bug has been reported here: > > https://bugzilla.kernel.org/show_bug.cgi?id=29082 > > Signed-off-by: Emil Goode Reported-and-tested-by: Igor Gnatenko > --- > drivers/net/usb/asix_devices.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c > index 9765a7d..120bb29 100644 > --- a/drivers/net/usb/asix_devices.c > +++ b/drivers/net/usb/asix_devices.c > @@ -455,6 +455,7 @@ static int ax88772_bind(struct usbnet *dev, struct > usb_interface *intf) > dev->net->ethtool_ops = &ax88772_ethtool_ops; > dev->net->needed_headroom = 4; /* cf asix_tx_fixup() */ > dev->net->needed_tailroom = 4; /* cf asix_tx_fixup() */ > + dev->net->hard_header_len = 0; /* Partial packets have no header */ > > embd_phy = ((dev->mii.phy_id & 0x1f) == 0x10 ? 1 : 0); > -- -Igor Gnatenko -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
