Re: [PATCH] usb: chipidea: imx: Use dev_name() for ci_hdrc name to distinguish USBs
On Mon, Feb 24, 2014 at 11:49:40AM +0800, Peter Chen wrote:
> On Mon, Feb 24, 2014 at 08:32:14AM +0400, Alexander Shiyan wrote:
> > Понедельник, 24 февраля 2014, 10:02 +08:00 от Peter Chen
> > :
> > > On Sat, Feb 22, 2014 at 05:17:58PM +0400, Alexander Shiyan wrote:
> > > > Signed-off-by: Alexander Shiyan
> > > > ---
> > > > drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
> > > > b/drivers/usb/chipidea/ci_hdrc_imx.c
> > > > index c00f772..2e58f8d 100644
> > > > --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> > > > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> > > > @@ -96,7 +96,7 @@ static int ci_hdrc_imx_probe(struct platform_device
> > > > *pdev)
> > > > {
> > > > struct ci_hdrc_imx_data *data;
> > > > struct ci_hdrc_platform_data pdata = {
> > > > - .name = "ci_hdrc_imx",
> > > > + .name = dev_name(&pdev->dev),
> > > > .capoffset = DEF_CAPOFFSET,
> > > > .flags = CI_HDRC_REQUIRE_TRANSCEIVER |
> > > > CI_HDRC_DISABLE_STREAMING,
> > > > --
> > ...
> > >
> > > I don't see too much meaningful for this change, and I don't see
> > > the meaning of this entry (.name) and no user is using it.
> >
> > Field "name" is used in the function ci_hdrc_probe() (core.c) for
> > request_irq().
> > That's what will result:
> > # cat /proc.interrupts
> > ...
> > 71: 0 mxc-avic 55 10024400.usb
> > 72: 0 mxc-avic 56 10024000.usb
> >
> > ---
>
> Get it, thanks.
>
Please add commit log for this patch, then I can apply it.
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: chipidea: imx: Use dev_name() for ci_hdrc name to distinguish USBs
On Mon, Feb 24, 2014 at 08:32:14AM +0400, Alexander Shiyan wrote:
> Понедельник, 24 февраля 2014, 10:02 +08:00 от Peter Chen
> :
> > On Sat, Feb 22, 2014 at 05:17:58PM +0400, Alexander Shiyan wrote:
> > > Signed-off-by: Alexander Shiyan
> > > ---
> > > drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
> > > b/drivers/usb/chipidea/ci_hdrc_imx.c
> > > index c00f772..2e58f8d 100644
> > > --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> > > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> > > @@ -96,7 +96,7 @@ static int ci_hdrc_imx_probe(struct platform_device
> > > *pdev)
> > > {
> > > struct ci_hdrc_imx_data *data;
> > > struct ci_hdrc_platform_data pdata = {
> > > - .name = "ci_hdrc_imx",
> > > + .name = dev_name(&pdev->dev),
> > > .capoffset = DEF_CAPOFFSET,
> > > .flags = CI_HDRC_REQUIRE_TRANSCEIVER |
> > > CI_HDRC_DISABLE_STREAMING,
> > > --
> ...
> >
> > I don't see too much meaningful for this change, and I don't see
> > the meaning of this entry (.name) and no user is using it.
>
> Field "name" is used in the function ci_hdrc_probe() (core.c) for
> request_irq().
> That's what will result:
> # cat /proc.interrupts
> ...
> 71: 0 mxc-avic 55 10024400.usb
> 72: 0 mxc-avic 56 10024000.usb
>
> ---
Get it, thanks.
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: chipidea: imx: Use dev_name() for ci_hdrc name to distinguish USBs
Понедельник, 24 февраля 2014, 10:02 +08:00 от Peter Chen
:
> On Sat, Feb 22, 2014 at 05:17:58PM +0400, Alexander Shiyan wrote:
> > Signed-off-by: Alexander Shiyan
> > ---
> > drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
> > b/drivers/usb/chipidea/ci_hdrc_imx.c
> > index c00f772..2e58f8d 100644
> > --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> > @@ -96,7 +96,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> > {
> > struct ci_hdrc_imx_data *data;
> > struct ci_hdrc_platform_data pdata = {
> > - .name = "ci_hdrc_imx",
> > + .name = dev_name(&pdev->dev),
> > .capoffset = DEF_CAPOFFSET,
> > .flags = CI_HDRC_REQUIRE_TRANSCEIVER |
> > CI_HDRC_DISABLE_STREAMING,
> > --
...
>
> I don't see too much meaningful for this change, and I don't see
> the meaning of this entry (.name) and no user is using it.
Field "name" is used in the function ci_hdrc_probe() (core.c) for request_irq().
That's what will result:
# cat /proc.interrupts
...
71: 0 mxc-avic 55 10024400.usb
72: 0 mxc-avic 56 10024000.usb
---
Re: [PATCH] usb: chipidea: imx: Use dev_name() for ci_hdrc name to distinguish USBs
On Sat, Feb 22, 2014 at 05:17:58PM +0400, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
> b/drivers/usb/chipidea/ci_hdrc_imx.c
> index c00f772..2e58f8d 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -96,7 +96,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> {
> struct ci_hdrc_imx_data *data;
> struct ci_hdrc_platform_data pdata = {
> - .name = "ci_hdrc_imx",
> + .name = dev_name(&pdev->dev),
> .capoffset = DEF_CAPOFFSET,
> .flags = CI_HDRC_REQUIRE_TRANSCEIVER |
> CI_HDRC_DISABLE_STREAMING,
> --
> 1.8.3.2
>
>
>
I don't see too much meaningful for this change, and I don't see
the meaning of this entry (.name) and no user is using it.
Care to delete it for chipidea driver, and submit a patch?
Peter
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: chipidea: imx: Use dev_name() for ci_hdrc name to distinguish USBs
Signed-off-by: Alexander Shiyan
---
drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index c00f772..2e58f8d 100644
--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -96,7 +96,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
{
struct ci_hdrc_imx_data *data;
struct ci_hdrc_platform_data pdata = {
- .name = "ci_hdrc_imx",
+ .name = dev_name(&pdev->dev),
.capoffset = DEF_CAPOFFSET,
.flags = CI_HDRC_REQUIRE_TRANSCEIVER |
CI_HDRC_DISABLE_STREAMING,
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
