Re: [PATCH 0/3] usb: remove duplicate & operation
Lukasz Majewski writes: > Hi Jaejoong, > >> usb_endpoint_maxp() has an inline keyword and searches for bits[10:0] >> by & operation with 0x7ff. So, we can remove the duplicate & operation >> with 0x7ff. >> >> Jaejoong Kim (3): >> usb: gadget: udc: remove duplicate & operation >> usb: gadget: udc: gr: remove duplicate & operation >> usb: misc: usbtest: remove duplicate & operation >> >> drivers/usb/gadget/udc/core.c | 2 +- >> drivers/usb/gadget/udc/gr_udc.c | 2 +- >> drivers/usb/misc/usbtest.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> > > I think that it would be better if you could squash those 3 patches > into one. no, it would not. It's good as it is ;-) -- balbi signature.asc Description: PGP signature
Re: [PATCH 0/3] usb: remove duplicate & operation
Hi Jaejoong, > usb_endpoint_maxp() has an inline keyword and searches for bits[10:0] > by & operation with 0x7ff. So, we can remove the duplicate & operation > with 0x7ff. > > Jaejoong Kim (3): > usb: gadget: udc: remove duplicate & operation > usb: gadget: udc: gr: remove duplicate & operation > usb: misc: usbtest: remove duplicate & operation > > drivers/usb/gadget/udc/core.c | 2 +- > drivers/usb/gadget/udc/gr_udc.c | 2 +- > drivers/usb/misc/usbtest.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > I think that it would be better if you could squash those 3 patches into one. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] usb: remove duplicate & operation
usb_endpoint_maxp() has an inline keyword and searches for bits[10:0] by & operation with 0x7ff. So, we can remove the duplicate & operation with 0x7ff. Jaejoong Kim (3): usb: gadget: udc: remove duplicate & operation usb: gadget: udc: gr: remove duplicate & operation usb: misc: usbtest: remove duplicate & operation drivers/usb/gadget/udc/core.c | 2 +- drivers/usb/gadget/udc/gr_udc.c | 2 +- drivers/usb/misc/usbtest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html