[patch 1/2] macintosh: wrong test in fan_{read,write}_reg()
From: roel kluin roel.kl...@gmail.com Fix error test in fan_{read,write}_reg() Signed-off-by: Roel Kluin roel.kl...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Andrew Morton a...@linux-foundation.org --- drivers/macintosh/therm_pm72.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/macintosh/therm_pm72.c~macintosh-wrong-test-in-fan_readwrite_reg drivers/macintosh/therm_pm72.c --- a/drivers/macintosh/therm_pm72.c~macintosh-wrong-test-in-fan_readwrite_reg +++ a/drivers/macintosh/therm_pm72.c @@ -443,7 +443,7 @@ static int fan_read_reg(int reg, unsigne tries = 0; for (;;) { nr = i2c_master_recv(fcu, buf, nb); - if (nr 0 || (nr 0 nr != ENODEV) || tries = 100) + if (nr 0 || (nr 0 nr != -ENODEV) || tries = 100) break; msleep(10); ++tries; @@ -464,7 +464,7 @@ static int fan_write_reg(int reg, const tries = 0; for (;;) { nw = i2c_master_send(fcu, buf, nb); - if (nw 0 || (nw 0 nw != EIO) || tries = 100) + if (nw 0 || (nw 0 nw != -EIO) || tries = 100) break; msleep(10); ++tries; _ ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [patch 1/2] macintosh: wrong test in fan_{read,write}_reg()
On Tue, 2011-01-18 at 13:09 -0800, a...@linux-foundation.org wrote: From: roel kluin roel.kl...@gmail.com Fix error test in fan_{read,write}_reg() Thanks, I'll pick that up. Cheers, Ben. Signed-off-by: Roel Kluin roel.kl...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Andrew Morton a...@linux-foundation.org --- drivers/macintosh/therm_pm72.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/macintosh/therm_pm72.c~macintosh-wrong-test-in-fan_readwrite_reg drivers/macintosh/therm_pm72.c --- a/drivers/macintosh/therm_pm72.c~macintosh-wrong-test-in-fan_readwrite_reg +++ a/drivers/macintosh/therm_pm72.c @@ -443,7 +443,7 @@ static int fan_read_reg(int reg, unsigne tries = 0; for (;;) { nr = i2c_master_recv(fcu, buf, nb); - if (nr 0 || (nr 0 nr != ENODEV) || tries = 100) + if (nr 0 || (nr 0 nr != -ENODEV) || tries = 100) break; msleep(10); ++tries; @@ -464,7 +464,7 @@ static int fan_write_reg(int reg, const tries = 0; for (;;) { nw = i2c_master_send(fcu, buf, nb); - if (nw 0 || (nw 0 nw != EIO) || tries = 100) + if (nw 0 || (nw 0 nw != -EIO) || tries = 100) break; msleep(10); ++tries; _ ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev