Re: [PATCH 02/14] dwc/otg: Structure declaration for shared data
On Fri, Sep 02, 2011 at 05:19:17PM +0530, Pratyush Anand wrote: > On Thu, Sep 1, 2011 at 4:06 AM, Greg KH wrote: > > On Tue, Aug 30, 2011 at 05:27:49PM +0530, Pratyush Anand wrote: > >> There are some DWC OTG parameters which might be passed by a platform. > >> Declaration for structure of those parameters have been provided in this > >> include file. > >> > >> Signed-off-by: Pratyush Anand > >> --- > >> include/linux/usb/dwc_otg.h | 274 > >> +++ > >> 1 files changed, 274 insertions(+), 0 deletions(-) > >> create mode 100644 include/linux/usb/dwc_otg.h > >> > >> diff --git a/include/linux/usb/dwc_otg.h b/include/linux/usb/dwc_otg.h > > > > Shouldn't this be in include/linux/platform/ instead? > > do you mean linux/platform_data/? Yes, sorry. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH 02/14] dwc/otg: Structure declaration for shared data
пишет: < <> I will send you those patches. <> But, how to go about it? Will you send next revision of your patces <> soon, and will also include comments for current review? <> <> Or, <> <> I replly all the comments from community and get agreed about <> modifications first. <> Then I will release next revision with all these modifications and get <> it included. Once these patches are included then we can keep on <> sending further patches over those included. This will shorten review <> time and will be easier for inclusion. < https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH 02/14] dwc/otg: Structure declaration for shared data
< From your changes. Regards, Marri ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 02/14] dwc/otg: Structure declaration for shared data
В Fri, 2 Sep 2011 17:12:17 +0530 Pratyush Anand пишет: > I will send you those patches. > But, how to go about it? Will you send next revision of your patces soon, and > will also include comments for current review? > > Or, > > I replly all the comments from community and get agreed about > modifications first. > Then I will release next revision with all these modifications and get > it included. Once these patches are > included then we can keep on sending further patches over those > included. This will shorten review time > and will be easier for inclusion. What do you think about making a public git repository on github, for example? I'm using dwc_otg on several MIPS boards and would be happy to contribute too (at least, fix things pointed out by reviewers to speed up inclusion). -- Alexander signature.asc Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 02/14] dwc/otg: Structure declaration for shared data
On Thu, Sep 1, 2011 at 4:06 AM, Greg KH wrote: > On Tue, Aug 30, 2011 at 05:27:49PM +0530, Pratyush Anand wrote: >> There are some DWC OTG parameters which might be passed by a platform. >> Declaration for structure of those parameters have been provided in this >> include file. >> >> Signed-off-by: Pratyush Anand >> --- >> include/linux/usb/dwc_otg.h | 274 >> +++ >> 1 files changed, 274 insertions(+), 0 deletions(-) >> create mode 100644 include/linux/usb/dwc_otg.h >> >> diff --git a/include/linux/usb/dwc_otg.h b/include/linux/usb/dwc_otg.h > > Shouldn't this be in include/linux/platform/ instead? do you mean linux/platform_data/? seems better place. Regards Pratyush > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 02/14] dwc/otg: Structure declaration for shared data
I will send you those patches. But, how to go about it? Will you send next revision of your patces soon, and will also include comments for current review? Or, I replly all the comments from community and get agreed about modifications first. Then I will release next revision with all these modifications and get it included. Once these patches are included then we can keep on sending further patches over those included. This will shorten review time and will be easier for inclusion. Regards Pratyush On Wed, Aug 31, 2011 at 10:47 PM, Tirumala Marri wrote: > < > < >[Tirumala Marri] Sounds like a plan. Could you send the changes, I will > take > A look at the changes. > > --marri > ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 02/14] dwc/otg: Structure declaration for shared data
On Wed, Aug 31, 2011 at 08:18:12PM -0400, Josh Boyer wrote: > On Wed, Aug 31, 2011 at 6:36 PM, Greg KH wrote: > > On Tue, Aug 30, 2011 at 08:29:21AM -0700, Tirumala Marri wrote: > >> <-Original Message- > >> mailto:pratyush.an...@st.com] > >> >> >> >> >> >> >> >> >> < > >> >> >> >> < > >> > >> <--- > >> < include/linux/usb/dwc_otg.h | 274 > >> > >> [Tirumala Marri] I am not sure how to separate your changes. But we need > >> More time as our initial patches are still pending. > > > > pending where? Have you submitted them for inclusion? > > > > 13 times in fact. Each time, more comments and fixes need. Par for > the course with a vendor driver, but in this case Pratyush thought the > APM guys had let it die and tried to carry it forward. I guess APM > has been sitting on it for more than 4 months now. > > Anyway, hope that clears up some of the confusion. It does, thanks. greg k-h ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 02/14] dwc/otg: Structure declaration for shared data
On Wed, Aug 31, 2011 at 6:36 PM, Greg KH wrote: > On Tue, Aug 30, 2011 at 08:29:21AM -0700, Tirumala Marri wrote: >> <-Original Message- >> mailto:pratyush.an...@st.com] >> > > > > > > > > < >> > > > < >> >> <--- >> < include/linux/usb/dwc_otg.h | 274 >> >> [Tirumala Marri] I am not sure how to separate your changes. But we need >> More time as our initial patches are still pending. > > pending where? Have you submitted them for inclusion? > 13 times in fact. Each time, more comments and fixes need. Par for the course with a vendor driver, but in this case Pratyush thought the APM guys had let it die and tried to carry it forward. I guess APM has been sitting on it for more than 4 months now. Anyway, hope that clears up some of the confusion. josh ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 02/14] dwc/otg: Structure declaration for shared data
On Tue, Aug 30, 2011 at 08:29:21AM -0700, Tirumala Marri wrote: > <-Original Message- > mailto:pratyush.an...@st.com] > < >< > > <--- > < include/linux/usb/dwc_otg.h | 274 > > [Tirumala Marri] I am not sure how to separate your changes. But we need > More time as our initial patches are still pending. pending where? Have you submitted them for inclusion? confused, greg k-h ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 02/14] dwc/otg: Structure declaration for shared data
On Tue, Aug 30, 2011 at 05:27:49PM +0530, Pratyush Anand wrote: > There are some DWC OTG parameters which might be passed by a platform. > Declaration for structure of those parameters have been provided in this > include file. > > Signed-off-by: Pratyush Anand > --- > include/linux/usb/dwc_otg.h | 274 > +++ > 1 files changed, 274 insertions(+), 0 deletions(-) > create mode 100644 include/linux/usb/dwc_otg.h > > diff --git a/include/linux/usb/dwc_otg.h b/include/linux/usb/dwc_otg.h Shouldn't this be in include/linux/platform/ instead? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH 02/14] dwc/otg: Structure declaration for shared data
< https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 02/14] dwc/otg: Structure declaration for shared data
On Tue, Aug 30, 2011 at 8:59 PM, Tirumala Marri wrote: > <-Original Message- > mailto:pratyush.an...@st.com] > < >< > > <--- > < include/linux/usb/dwc_otg.h | 274 > > [Tirumala Marri] I am not sure how to separate your changes. But we need > More time as our initial patches are still pending. > --marri Tirumala, If you agree , then I can send you modifications which I did over your patches(v13) separately, and then you can decide the final inclusion of only these modifications. Regards Pratyush > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH 02/14] dwc/otg: Structure declaration for shared data
<-Original Message- mailto:pratyush.an...@st.com] <--- < include/linux/usb/dwc_otg.h | 274 [Tirumala Marri] I am not sure how to separate your changes. But we need More time as our initial patches are still pending. --marri ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
