sfx.c driver build failure
Hi Michael ! The sfx driver (which happens to be part of some of our test configs) fails to build in current Linus tree on powerpc with this error: /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’: /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ oper and Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: sfx.c driver build failure
On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > The sfx driver (which happens to be part of some of our test configs) > fails to build in current Linus tree on powerpc with this error: > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function > ‘efx_probe_interrupts’: > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue > required as unary ‘&’ operand Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around topology_core_siblings() breakage" in linux-next (from the cpus4096 tree) comments out the offending lines ... With the comment "the topology API is a mess right now". -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpmfbW5J1PAU.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: sfx.c driver build failure
* Stephen Rothwell <[EMAIL PROTECTED]> wrote: > On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> > wrote: > > > > The sfx driver (which happens to be part of some of our test configs) > > fails to build in current Linus tree on powerpc with this error: > > > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function > > ‘efx_probe_interrupts’: > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue > > required as unary ‘&’ operand > > Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around > topology_core_siblings() breakage" in linux-next (from the cpus4096 > tree) comments out the offending lines ... With the comment "the > topology API is a mess right now". there's a patch from Mike Travis that solves it all from grounds up and which approach has the ack of Rusty as well, but it's not fully tested through yet - i will get to it later today. Ingo ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: sfx.c driver build failure
On Fri, 2008-07-25 at 08:35 +0100, Michael Brown wrote: > On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote: > > The sfx driver (which happens to be part of some of our test configs) > > fails to build in current Linus tree on powerpc with this error: > > > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function > > ÿÿefx_probe_interruptsÿÿ: > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue > > required as unary ÿÿ&ÿÿ oper > > and > > I'm not the maintainer of that code; I wrote the original version, but > it's now maintained by Solarflare. > > I don't see anything on that line that ought to be architecture-specific. > Could you send me the preprocessed efx.c from your powerpc build? Apparently, it's a know generic breakage of the topology stuff, it's beeing sorted out. Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: sfx.c driver build failure
On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote: > The sfx driver (which happens to be part of some of our test configs) > fails to build in current Linus tree on powerpc with this error: > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function > ÿÿefx_probe_interruptsÿÿ: > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue > required as unary ÿÿ&ÿÿ oper > and I'm not the maintainer of that code; I wrote the original version, but it's now maintained by Solarflare. I don't see anything on that line that ought to be architecture-specific. Could you send me the preprocessed efx.c from your powerpc build? Michael___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
