[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod
This revision was automatically updated to reflect the committed changes. Closed by commit rG3fbc89048517: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248/new/ https://reviews.llvm.org/D139248 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h @@ -100,7 +100,13 @@ return ExtractValueFromPythonObject(py_return, error); } - Status GetStatusFromMethod(llvm::StringRef method_name); + template + Status GetStatusFromMethod(llvm::StringRef method_name, Args &&...args) { +Status error; +Dispatch(method_name, error, std::forward(args)...); + +return error; + } template T Transform(T object) { // No Transformation for generic usage Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp @@ -27,14 +27,6 @@ ScriptInterpreterPythonImpl &interpreter) : ScriptedInterface(), m_interpreter(interpreter) {} -Status -ScriptedPythonInterface::GetStatusFromMethod(llvm::StringRef method_name) { - Status error; - Dispatch(method_name, error); - - return error; -} - template <> StructuredData::ArraySP ScriptedPythonInterface::ExtractValueFromPythonObject( Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h @@ -100,7 +100,13 @@ return ExtractValueFromPythonObject(py_return, error); } - Status GetStatusFromMethod(llvm::StringRef method_name); + template + Status GetStatusFromMethod(llvm::StringRef method_name, Args &&...args) { +Status error; +Dispatch(method_name, error, std::forward(args)...); + +return error; + } template T Transform(T object) { // No Transformation for generic usage Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp @@ -27,14 +27,6 @@ ScriptInterpreterPythonImpl &interpreter) : ScriptedInterface(), m_interpreter(interpreter) {} -Status -ScriptedPythonInterface::GetStatusFromMethod(llvm::StringRef method_name) { - Status error; - Dispatch(method_name, error); - - return error; -} - template <> StructuredData::ArraySP ScriptedPythonInterface::ExtractValueFromPythonObject( ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod
mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch makes `ScriptedPythonInterface::GetStatusFromMethod` take a parameter pack as an argument. That will allow it to pass arbitrary arguments to the python method. Signed-off-by: Med Ismail Bennani Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139248 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h @@ -99,7 +99,13 @@ return ExtractValueFromPythonObject(py_return, error); } - Status GetStatusFromMethod(llvm::StringRef method_name); + template + Status GetStatusFromMethod(llvm::StringRef method_name, Args &&...args) { +Status error; +Dispatch(method_name, error, args...); + +return error; + } template T Transform(T object) { // No Transformation for generic usage Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp @@ -26,14 +26,6 @@ ScriptInterpreterPythonImpl &interpreter) : ScriptedInterface(), m_interpreter(interpreter) {} -Status -ScriptedPythonInterface::GetStatusFromMethod(llvm::StringRef method_name) { - Status error; - Dispatch(method_name, error); - - return error; -} - template <> StructuredData::ArraySP ScriptedPythonInterface::ExtractValueFromPythonObject( Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h @@ -99,7 +99,13 @@ return ExtractValueFromPythonObject(py_return, error); } - Status GetStatusFromMethod(llvm::StringRef method_name); + template + Status GetStatusFromMethod(llvm::StringRef method_name, Args &&...args) { +Status error; +Dispatch(method_name, error, args...); + +return error; + } template T Transform(T object) { // No Transformation for generic usage Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp @@ -26,14 +26,6 @@ ScriptInterpreterPythonImpl &interpreter) : ScriptedInterface(), m_interpreter(interpreter) {} -Status -ScriptedPythonInterface::GetStatusFromMethod(llvm::StringRef method_name) { - Status error; - Dispatch(method_name, error); - - return error; -} - template <> StructuredData::ArraySP ScriptedPythonInterface::ExtractValueFromPythonObject( ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248/new/ https://reviews.llvm.org/D139248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod
labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h:105 +Status error; +Dispatch(method_name, error, args...); + `std::forward(args)...` maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248/new/ https://reviews.llvm.org/D139248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod
mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h:105 +Status error; +Dispatch(method_name, error, args...); + labath wrote: > `std::forward(args)...` maybe? Indeed, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248/new/ https://reviews.llvm.org/D139248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod
mib updated this revision to Diff 484527. mib marked an inline comment as done. mib added a comment. Use `std::forward` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248/new/ https://reviews.llvm.org/D139248 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h @@ -99,7 +99,13 @@ return ExtractValueFromPythonObject(py_return, error); } - Status GetStatusFromMethod(llvm::StringRef method_name); + template + Status GetStatusFromMethod(llvm::StringRef method_name, Args &&...args) { +Status error; +Dispatch(method_name, error, std::forward(args)...); + +return error; + } template T Transform(T object) { // No Transformation for generic usage Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp @@ -26,14 +26,6 @@ ScriptInterpreterPythonImpl &interpreter) : ScriptedInterface(), m_interpreter(interpreter) {} -Status -ScriptedPythonInterface::GetStatusFromMethod(llvm::StringRef method_name) { - Status error; - Dispatch(method_name, error); - - return error; -} - template <> StructuredData::ArraySP ScriptedPythonInterface::ExtractValueFromPythonObject( Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h @@ -99,7 +99,13 @@ return ExtractValueFromPythonObject(py_return, error); } - Status GetStatusFromMethod(llvm::StringRef method_name); + template + Status GetStatusFromMethod(llvm::StringRef method_name, Args &&...args) { +Status error; +Dispatch(method_name, error, std::forward(args)...); + +return error; + } template T Transform(T object) { // No Transformation for generic usage Index: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp === --- lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp +++ lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.cpp @@ -26,14 +26,6 @@ ScriptInterpreterPythonImpl &interpreter) : ScriptedInterface(), m_interpreter(interpreter) {} -Status -ScriptedPythonInterface::GetStatusFromMethod(llvm::StringRef method_name) { - Status error; - Dispatch(method_name, error); - - return error; -} - template <> StructuredData::ArraySP ScriptedPythonInterface::ExtractValueFromPythonObject( ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits