Re: r31062 - in lyx-devel/trunk/src: . frontends/qt4
Vincent van Ravesteijn wrote: > This is also in branch. > > ok? Yes, of course. Jürgen
Re: [patch] LyX server for Windows
Andre Poenitz wrote: What was the system Qt version shipped with the Windows distribution? 4.5.2 Joost
Re: Search pane assert
Pavel Sanda ha scritto: 1. new file 2. find and open (advanced) //open 3. close file 4. find and open (advanced) //close 5. kaboom As observed by Vincent, the assertion is not needed, and I verified that setCurrentWorkArea() tolerates a NULL argument (see attached patch). I can commit, unless objections are raised. T. Index: src/frontends/qt4/GuiWorkArea.cpp === --- src/frontends/qt4/GuiWorkArea.cpp (revisione 31338) +++ src/frontends/qt4/GuiWorkArea.cpp (copia locale) @@ -1279,7 +1279,7 @@ stopBlinkingCursor(); if (view().currentWorkArea() != this) return; - LASSERT(view().currentMainWorkArea(), /* */); + // setCurrentWorkArea() allows for a NULL argument view().setCurrentWorkArea(view().currentMainWorkArea()); }
Re: [patch] Keytest: One Screenshot per Key Press
On Mon, Sep 7, 2009 at 11:54 PM, Vincent van Ravesteijn - TNW wrote: >> I am thinking of adding links like: >> > http://www.lyx.org/trac/newticket?description=bar&summary=foo&keywords=c > rash& >> to make it easier for the submitter (me in this case) to submit bugs. >> Also a search option so they can check that it is not already > submitted. > > Please don't automatically add bugs. This does not automatically add bugs. It links to the search page, and fills out all the relevant entries for the user. > There will be unavoidable duplicates, and I don't want to have tons of > bugs that we can never reproduce and of which we won't gain any new > information. So, they won't be fixed ever, and if they are fixed, we > don't know that they are fixed. > > My opinion is that if we don't know how to reproduce, we don't add them > to trac. This was not in question. Currently, Keytest does not even report bugs that it cannot reproduce. Indeed a hypothetical "shiny gui" version of the program would more-or-less force the users to explain how to reproduce the bug manually before allowing them to even access the information in a Trac-friendly format. -- John C. McCabe-Dansted
Re: r31062 - in lyx-devel/trunk/src: . frontends/qt4
v...@lyx.org schreef: Author: vfr Date: Sat Aug 15 22:47:46 2009 New Revision: 31062 URL: http://www.lyx.org/trac/changeset/31062 Log: Fix a bunch of assertions. The first thing that bformat does is to check whether the string contains "%1$s". Otherwise it asserts. Why didn't we see this happen before ? This was revealed by the emergency saves that Richard introduced in the Buffer dtor. Modified: lyx-devel/trunk/src/Buffer.cpp lyx-devel/trunk/src/frontends/qt4/qt_helpers.cpp Modified: lyx-devel/trunk/src/Buffer.cpp == --- lyx-devel/trunk/src/Buffer.cpp Sat Aug 15 22:03:41 2009(r31061) +++ lyx-devel/trunk/src/Buffer.cpp Sat Aug 15 22:47:46 2009(r31062) @@ -967,7 +967,7 @@ LYXERR0(" " << s); if (writeFile(FileName(s))) { markClean(); - user_message += bformat(_(" Saved to %1$. Phew.\n"), from_utf8(s)); + user_message += bformat(_(" Saved to %1$s. Phew.\n"), from_utf8(s)); return user_message; } else { user_message += _(" Save failed! Trying again...\n"); @@ -980,7 +980,7 @@ lyxerr << ' ' << s << endl; if (writeFile(FileName(s))) { markClean(); - user_message += bformat(_(" Saved to %1$. Phew.\n"), from_utf8(s)); + user_message += bformat(_(" Saved to %1$s. Phew.\n"), from_utf8(s)); return user_message; } @@ -994,7 +994,7 @@ lyxerr << ' ' << s << endl; if (writeFile(FileName(s))) { markClean(); - user_message += bformat(_(" Saved to %1$. Phew.\n"), from_utf8(s)); + user_message += bformat(_(" Saved to %1$s. Phew.\n"), from_utf8(s)); return user_message; } Modified: lyx-devel/trunk/src/frontends/qt4/qt_helpers.cpp == --- lyx-devel/trunk/src/frontends/qt4/qt_helpers.cppSat Aug 15 22:03:41 2009(r31061) +++ lyx-devel/trunk/src/frontends/qt4/qt_helpers.cppSat Aug 15 22:47:46 2009(r31062) @@ -213,7 +213,7 @@ return; // FIXME UNICODE frontend::Alert::error(_("Could not update TeX information"), - bformat(_("The script `%s' failed."), from_utf8(command.absFilename(; + bformat(_("The script `%1$s' failed."), from_utf8(command.absFilename(; } Jurgen.. This is also in branch. ok? Vincent
Re: [patch] LyX server for Windows
On Mon, Sep 07, 2009 at 06:24:56PM +0200, Andre Poenitz wrote: > On Mon, Sep 07, 2009 at 12:38:25AM +0200, Enrico Forestieri wrote: > > On Sun, Sep 06, 2009 at 11:10:25PM +0200, Andre Poenitz wrote: > > > > > On Sun, Sep 06, 2009 at 05:50:28PM +, Enrico Forestieri wrote: > > > > Andre Poenitz writes: > > > > > > > > > > On Sun, Sep 06, 2009 at 05:36:44PM +0200, Enrico Forestieri wrote: > > > > > > The attached patch implements the LyX server for Windows in 1.6.x. > > > > > > > > > > Can anybody remind me why we need to use 500+ platform specific > > > > > lines code of our own instead of using, say, QLocalSocket? > > > > > > > > Because QLocalSocket::socketDescriptor() is not going to work > > > > with QSocketNotifier? > > > > > > Wouldn't we just connect to QLocalSocket::readyRead() or such? > > > > QLocalSocket requires Qt >= 4.4 > > That kind of reason... > > What was the system Qt version shipped with the Windows distribution? > We do have to depend on the system Qt there, right? Either it works for all platforms or it still is "500+ platform specific lines code". QLocalSocket uses named pipes on Windows but unix domain sockets on *nix, so it cannot be used for all platforms. -- Enrico
Re: [patch] LyX server for Windows
On Mon, Sep 07, 2009 at 09:24:13AM +0200, Abdelrazak Younes wrote: > Honestly, I was also uneasy about this platform specific code but I > didn't say anything because 1) you obviously spent quite some work on it > and 2) nobody else volunteered to implement the feature on Windows > before you 3) your code is quite clean (even though nobody else in the > list than you understands it) 4) it exists now. 5. It works. -- Enrico
Re: [patch] LyX server for Windows
On Mon, Sep 07, 2009 at 12:38:25AM +0200, Enrico Forestieri wrote: > On Sun, Sep 06, 2009 at 11:10:25PM +0200, Andre Poenitz wrote: > > > On Sun, Sep 06, 2009 at 05:50:28PM +, Enrico Forestieri wrote: > > > Andre Poenitz writes: > > > > > > > > On Sun, Sep 06, 2009 at 05:36:44PM +0200, Enrico Forestieri wrote: > > > > > The attached patch implements the LyX server for Windows in 1.6.x. > > > > > > > > Can anybody remind me why we need to use 500+ platform specific > > > > lines code of our own instead of using, say, QLocalSocket? > > > > > > Because QLocalSocket::socketDescriptor() is not going to work > > > with QSocketNotifier? > > > > Wouldn't we just connect to QLocalSocket::readyRead() or such? > > QLocalSocket requires Qt >= 4.4 That kind of reason... What was the system Qt version shipped with the Windows distribution? We do have to depend on the system Qt there, right? Andre'
Re: UserGuide and EmbeddedObjects compilations fail in French
Guenter Milde wrote: > A ticket for "enable custom insertions before the required packages", yes. which we already have: http://www.lyx.org/trac/ticket/5031 http://www.lyx.org/trac/ticket/5366 >Independent of this, there are cases where you want to pass an option >to an autoloaded package but cannot use the global document options for >this because this would affect other packages or the documentclass as >well. The LaTeX way to do this is \PassOptionToPackage before >loading the package in question. Sure. We need a package manager. Jürgen
RE: [patch] Keytest: One Screenshot per Key Press
> I am thinking of adding links like: > http://www.lyx.org/trac/newticket?description=bar&summary=foo&keywords=c rash& > to make it easier for the submitter (me in this case) to submit bugs. > Also a search option so they can check that it is not already submitted. Please don't automatically add bugs. There will be unavoidable duplicates, and I don't want to have tons of bugs that we can never reproduce and of which we won't gain any new information. So, they won't be fixed ever, and if they are fixed, we don't know that they are fixed. My opinion is that if we don't know how to reproduce, we don't add them to trac. Vincent
Re: UserGuide and EmbeddedObjects compilations fail in French
On 2009-09-07, Jürgen Spitzmüller wrote: > Jean-Pierre Chrétien wrote: >> http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg154250.html > Thanks. >> Should I file a ticket ? A ticket for "enable custom insertions before the required packages", yes. > How hard will it be for affected people to upgrade the respective packages? Independent of this, there are cases where you want to pass an option to an autoloaded package but cannot use the global document options for this because this would affect other packages or the documentclass as well. The LaTeX way to do this is \PassOptionToPackage *before* loading the package in question. Günter
Re: Initials
Hartmut Haase wrote: > Hi Pavel, > > i have no idea how to get the '[ante=\lglqq, loversize=0.1]' part into the > > output > your approach neglects the possibilities of lettrine. You can only print the > standard 2line initial, where lettrine has nine different parameters. A > better approach would be to put something like "[]{}{}" into the initial > field when coosing the textstyle Initial, and output it as "\lettrine[]{}{}" > to LaTeX. lettrine can handle empty brackets. as i said our layout/module machinery doesn't allow to handle [], at least i am not aware about it ;) secondly if you want something like []{}{} to be print on the lyx screen whats the merit compared to plain ERT? pavel
RE: r31328 - in lyx-devel/branches/BRANCH_1_6_X: . src/mathed
>Author: sanda >Date: Mon Sep 7 13:44:49 2009 >New Revision: 31328 >URL: http://www.lyx.org/trac/changeset/31328 > >Log: >Backport bugfix for #2045. > >+ case LFUN_FONT_UNDERLINE: >+ cur.recordUndo(); >+ cur.handleNest(createInsetMath("underline")); >+ break; > > >+- Handle LFUN_UNDERLINE in mathed too (bug 2045). > You probably mean LFUN_FONT_UNDERLINE. Vincent
Re: UserGuide and EmbeddedObjects compilations fail in French
Jürgen Spitzmüller writes: > > How hard will it be for affected people to upgrade the respective packages? Not hard, but needs patience. Here is the procedure on Linux to install TeXLive 2008: 1) Download the netinstaller (e.g. in /tmp) cd /tmp wget http://mirrors.ircam.fr/pub/CTAN/systems/texlive/tlnet/2008/install-tl-unx.tar.gz 2) Decompress and untar gunzip -c install-tl-unx.tar.gz | tar xof - 3) Run the installer (as root) cd install-tl sudo ./install-tl sevaral hours later, install procedure is achieved 4) Customize if needed (texconfig run, and texmf local stuff e.g.) 5) Change the PATH export PATH=/usr/local/texlive/2008/bin/i386-linux:$PATH in a test cammand window (or permanently in the .bashrc file or similar) Not a big deal then. -- Jean-Pierre
Re: Some Problem about Auto unselecting
rgheck wrote: On 09/06/2009 07:16 PM, 瑞生王 wrote: Thanks for your answer. I do have a clip manager running (Parcellite). After I close Parcellite, LyX works well (the problem disappears). OK, thanks. I'm not sure why this happens, but it presumably has something to do with how we interact with the X11 clipboard. This has more to do with how those X11 clipboard manager handle the X11 selection... They often merge the two concepts which is wrong. Abdel.
Re: UserGuide and EmbeddedObjects compilations fail in French
Jean-Pierre Chrétien wrote: > http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg154250.html Thanks. > Should I file a ticket ? I'm not sure. I do not much like the idea of adding a new package dependency to fix a bug which is solved since almost two years, especially since nameref does some rather extensive redefining of LaTeX macros. How hard will it be for affected people to upgrade the respective packages? Jürgen
Re: UserGuide and EmbeddedObjects compilations fail in French
Jürgen Spitzmüller writes: > > Jean-Pierre Chrétien wrote: > > OK, but this LaTeX bug affects 37.5% of the installations, from the > > statistics on the Users' list... > > It's a quite bold idea to call the response of 8 people "statistics" and to > deduce such a general percentage from that I know, but that's all I've got :-( > > BTW could you post again a pointer to your proposed patch? I cannot find it. http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg154250.html Should I file a ticket ? -- Jean-Pierre
Re: UserGuide and EmbeddedObjects compilations fail in French
Jean-Pierre Chrétien wrote: > OK, but this LaTeX bug affects 37.5% of the installations, from the > statistics on the Users' list... It's a quite bold idea to call the response of 8 people "statistics" and to deduce such a general percentage from that ;-) BTW could you post again a pointer to your proposed patch? I cannot find it. > but more generally to solve this kind of problem on a particular > document, LyX misses a way to insert part of the preamble before what > is automatically added from the analysis of the required packages. Yes, this is a long-time feature request. Jürgen
Re: UserGuide and EmbeddedObjects compilations fail in French
Uwe Stöhr a écrit : > Result in lyx-users: 5 success, 3 failures, clearly related to the TeXLive version (failure is > with TeXLive 2007). > > I myself upgraded TeXLive to 2008 with success (without and with my patch). OK so it is a bug in TeXLive 2007. TeXLive 2008 and MiKTeX 2.7 and 2.8 don't show the problem. Therefore I opt not to hardcode a solution for a bug of a special LaTeX distribution that is already fixed. OK, but this LaTeX bug affects 37.5% of the installations, from the statistics on the Users' list... Deactivating hyperref in the UserGuide solves the issue, but more generally to solve this kind of problem on a particular document, LyX misses a way to insert part of the preamble *before* what is automatically added from the analysis of the required packages. Unless there is a way that I missed ? -- Jean-Pierre
Re: Beware! Arsene is coming !
Le 07/09/2009 02:40, Paul A. Rubin a écrit : Man, he's got a pretty good set of hair follicles going there! And you have not seen his shoulders and forearms yet :) JMarc
Re: [patch] LyX server for Windows
Enrico Forestieri wrote: On Sun, Sep 06, 2009 at 11:10:25PM +0200, Andre Poenitz wrote: On Sun, Sep 06, 2009 at 05:50:28PM +, Enrico Forestieri wrote: Andre Poenitz writes: On Sun, Sep 06, 2009 at 05:36:44PM +0200, Enrico Forestieri wrote: The attached patch implements the LyX server for Windows in 1.6.x. Can anybody remind me why we need to use 500+ platform specific lines code of our own instead of using, say, QLocalSocket? Because QLocalSocket::socketDescriptor() is not going to work with QSocketNotifier? Wouldn't we just connect to QLocalSocket::readyRead() or such? QLocalSocket requires Qt >= 4.4 Windows packages (including cygwin AFAIK?) deliver with Qt4.5 ;-) Honestly, I was also uneasy about this platform specific code but I didn't say anything because 1) you obviously spent quite some work on it and 2) nobody else volunteered to implement the feature on Windows before you 3) your code is quite clean (even though nobody else in the list than you understands it) 4) it exists now. Abdel.