Re: [patch] bug 1214
Martin Vermeer wrote: > E.g., the real numbers R is sent as "mathbb R" and then dispatched as > "\mathbb" (creating a little blue font box), followed by "R" (to be put > inside it). > > This *used* to work, but doesn't anymore. Jürgen, is this what you are > fixing? Basically yes. Jürgen P.S.: If you select Insert->Math->Inline Formula, the Inset contains the string "on". This is unrelated to my patch, but certainly weird.
Re: [patch] bug 1214
On Thu, 2004-12-16 at 15:29, Jean-Marc Lasgouttes wrote: > > "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > > Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1214 This one fixes a > Juergen> bug in xforms' math panel. mathed should always get only one > Juergen> dispatch, not two separate ones. The qt frontend does this > Juergen> since genesis. > > What kind of values can latex_chosen_ have? > > Juergen> P.S.: This is also a 1.3.6 candidate > > Sure, provided you test it. > > JMarc Eh, what this does is test for the presence of a blank in the LaTeX string associated with a math panel item, and then dispatch the two words on both sides. E.g., the real numbers R is sent as "mathbb R" and then dispatched as "\mathbb" (creating a little blue font box), followed by "R" (to be put inside it). This *used* to work, but doesn't anymore. JÃrgen, is this what you are fixing? - Martin signature.asc Description: This is a digitally signed message part
Re: [patch] bug 1214
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1214 This one fixes a Juergen> bug in xforms' math panel. mathed should always get only one Juergen> dispatch, not two separate ones. The qt frontend does this Juergen> since genesis. >> What kind of values can latex_chosen_ have? Juergen> all strings from ControlMath.C. Thanks for the explanation. Jmarc
Re: [patch] bug 1214
Jean-Marc Lasgouttes wrote:
> Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1214 This one fixes a
> Juergen> bug in xforms' math panel. mathed should always get only one
> Juergen> dispatch, not two separate ones. The qt frontend does this
> Juergen> since genesis.
>
> What kind of values can latex_chosen_ have?
all strings from ControlMath.C.
The point is that xforms dispatched for the string "mathbb N"
math-insert \mathbb
math-insert \N
which gives in LaTeX
$\textrm{\mathbb{N}}$
(this produces a LaTeX error)
while qt (and the patched xforms) dispatches
math-insert \mathbb N
which gives in LaTeX
$\mathbb{N}$
as it should be.
> Juergen> P.S.: This is also a 1.3.6 candidate
>
> Sure, provided you test it.
Certainly. All cases that could fail are the textrm, mathbb and mathcal cases
(those who contain a blank), and those work well now.
Jürgen
Re: [patch] bug 1214
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1214 This one fixes a Juergen> bug in xforms' math panel. mathed should always get only one Juergen> dispatch, not two separate ones. The qt frontend does this Juergen> since genesis. What kind of values can latex_chosen_ have? Juergen> P.S.: This is also a 1.3.6 candidate Sure, provided you test it. JMarc
[patch] bug 1214
http://bugzilla.lyx.org/show_bug.cgi?id=1214
This one fixes a bug in xforms' math panel. mathed should always get only one
dispatch, not two separate ones. The qt frontend does this since genesis.
OK?
Jürgen
P.S.: This is also a 1.3.6 candidate
Index: FormMathsBitmap.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/xforms/FormMathsBitmap.C,v
retrieving revision 1.46
diff -u -r1.46 FormMathsBitmap.C
--- FormMathsBitmap.C 19 May 2004 15:11:35 - 1.46
+++ FormMathsBitmap.C 16 Dec 2004 12:59:39 -
@@ -173,13 +173,7 @@
void FormMathsBitmap::apply()
{
- string::size_type const i = latex_chosen_.find(' ');
- if (i != string::npos) {
- controller().dispatchFunc(LFUN_MATH_MODE);
- controller().dispatchInsert(latex_chosen_.substr(0,i));
- controller().dispatchInsert('\\' + latex_chosen_.substr(i + 1));
- } else
- controller().dispatchInsert(latex_chosen_);
+ controller().dispatchInsert(latex_chosen_);
}
