Re: [LyX/master] Add documentation for the new layout attributes.
It looks fine, thanks! Thibaut Cuvelier On Thu, 9 Jul 2020 at 00:46, Pavel Sanda wrote: > On Wed, Jul 08, 2020 at 08:34:30PM +0200, Thibaut Cuvelier wrote: > > > Good, do you have idea on top of which commit this was written (even > > > approximate date would be helpful). > > > > > > > The last commit before modifying this file dates back to October 2017: > > > https://github.com/dourouc05/LyX/commit/c39d673d2fc38ee4a42575f61df20fc64f84ce0f#diff-bbbc57f2b8834de0c9ec79c6b0167bc2 > > Thanks, Customization Manual should be hopefully ok now. P > -- > lyx-devel mailing list > lyx-devel@lists.lyx.org > http://lists.lyx.org/mailman/listinfo/lyx-devel > -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Add documentation for the new layout attributes.
On Wed, Jul 08, 2020 at 08:34:30PM +0200, Thibaut Cuvelier wrote: > > Good, do you have idea on top of which commit this was written (even > > approximate date would be helpful). > > > > The last commit before modifying this file dates back to October 2017: > https://github.com/dourouc05/LyX/commit/c39d673d2fc38ee4a42575f61df20fc64f84ce0f#diff-bbbc57f2b8834de0c9ec79c6b0167bc2 Thanks, Customization Manual should be hopefully ok now. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Add documentation for the new layout attributes.
On Wed, 8 Jul 2020 at 19:56, Pavel Sanda wrote: > On Wed, Jul 08, 2020 at 06:54:20PM +0200, Thibaut Cuvelier wrote: > > > > Here is the updated version of the manual and the corresponding > patch. It > > > > should apply cleanly, now (even though I don't get why it's that > > > large???)! > > > > > > I don't want updated version. I want some very old one where you did > not > > > made any > > > git merging or rebasing. > > > > > > > Here is a very old copy, I've updated it so that it reflects the current > > state of the code. Is it good enough? > > Good, do you have idea on top of which commit this was written (even > approximate > date would be helpful). > The last commit before modifying this file dates back to October 2017: https://github.com/dourouc05/LyX/commit/c39d673d2fc38ee4a42575f61df20fc64f84ce0f#diff-bbbc57f2b8834de0c9ec79c6b0167bc2 -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Add documentation for the new layout attributes.
On Wed, Jul 08, 2020 at 06:54:20PM +0200, Thibaut Cuvelier wrote: > > > Here is the updated version of the manual and the corresponding patch. It > > > should apply cleanly, now (even though I don't get why it's that > > large???)! > > > > I don't want updated version. I want some very old one where you did not > > made any > > git merging or rebasing. > > > > Here is a very old copy, I've updated it so that it reflects the current > state of the code. Is it good enough? Good, do you have idea on top of which commit this was written (even approximate date would be helpful). Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Add documentation for the new layout attributes.
On Wed, Jul 08, 2020 at 04:27:30PM +0200, Thibaut Cuvelier wrote: > On Wed, 8 Jul 2020 at 14:38, Pavel Sanda wrote: > > > On Wed, Jul 08, 2020 at 09:17:12AM +0200, Pavel Sanda wrote: > > > commit 7989ebca85ddf95d58dfb86e234a17e5470d62c2 > > > Author: Thibaut Cuvelier > > > Date: Fri May 10 02:54:44 2019 +0200 > > > > > > Add documentation for the new layout attributes. > > > > Thibaut, this patch broke the manual (likely wrong merge from some changes > > already committed to master.) I already reverted it. > > > > Can you send either pacth which works or old version of your manual > > which was fully working, I can do careful merge. > > > > Here is the updated version of the manual and the corresponding patch. It > should apply cleanly, now (even though I don't get why it's that large???)! I don't want updated version. I want some very old one where you did not made any git merging or rebasing. The current version spits on console stuff like Text.cpp (1939): Handling unknown body token: `\change_inserted' Text.cpp (1939): Handling unknown body token: `1075283030 1557448766' Text.cpp (1939): Handling unknown body token: `\end_layout' Paragraph ended in line 28725 Missing \end_layout. which means the patching mechanism sorted out things wrongly. Also if you look carefully you have doubled entries for DocBookRoot/DocBookForceAbstract. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Add documentation for the new layout attributes.
On Wed, Jul 08, 2020 at 09:17:12AM +0200, Pavel Sanda wrote: > commit 7989ebca85ddf95d58dfb86e234a17e5470d62c2 > Author: Thibaut Cuvelier > Date: Fri May 10 02:54:44 2019 +0200 > > Add documentation for the new layout attributes. Thibaut, this patch broke the manual (likely wrong merge from some changes already committed to master.) I already reverted it. Can you send either pacth which works or old version of your manual which was fully working, I can do careful merge. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
