[jira] [Commented] (MAPREDUCE-2643) Fixing typos/formatting/null checking in v2.app.speculate package
[ https://issues.apache.org/jira/browse/MAPREDUCE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13084557#comment-13084557 ] Arun C Murthy commented on MAPREDUCE-2643: -- Josh, thanks for updating the patch. Apologies for it going stale. One nit: you've removed a bunch of exception handling in DefaultSpeculator, that will affect exceptions sent to the job-client? Fixing typos/formatting/null checking in v2.app.speculate package - Key: MAPREDUCE-2643 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2643 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Reporter: Josh Wills Assignee: Josh Wills Priority: Minor Fix For: 0.23.0 Attachments: MAPREDUCE-2643-1.patch, MAPREDUCE-2643.patch No functional changes in this patch: just fixing some typos in the comments, fixing some formatting issues, renaming classes for consistency, and making the null checking around Jobs/Tasks more consistent. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2643) Fixing typos/formatting/null checking in v2.app.speculate package
[ https://issues.apache.org/jira/browse/MAPREDUCE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13082925#comment-13082925 ] Josh Wills commented on MAPREDUCE-2643: --- Re-generated, sorry about that. Fixing typos/formatting/null checking in v2.app.speculate package - Key: MAPREDUCE-2643 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2643 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Reporter: Josh Wills Assignee: Josh Wills Priority: Minor Fix For: 0.23.0 Attachments: MAPREDUCE-2643-1.patch, MAPREDUCE-2643.patch No functional changes in this patch: just fixing some typos in the comments, fixing some formatting issues, renaming classes for consistency, and making the null checking around Jobs/Tasks more consistent. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2643) Fixing typos/formatting/null checking in v2.app.speculate package
[ https://issues.apache.org/jira/browse/MAPREDUCE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063974#comment-13063974 ] Hadoop QA commented on MAPREDUCE-2643: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485295/MAPREDUCE-2643.patch against trunk revision 1145424. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/454//console This message is automatically generated. Fixing typos/formatting/null checking in v2.app.speculate package - Key: MAPREDUCE-2643 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2643 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: mrv2 Reporter: Josh Wills Assignee: Josh Wills Priority: Minor Attachments: MAPREDUCE-2643.patch No functional changes in this patch: just fixing some typos in the comments, fixing some formatting issues, renaming classes for consistency, and making the null checking around Jobs/Tasks more consistent. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
