[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557220#comment-13557220 ] Hudson commented on MAPREDUCE-4923: --- Integrated in Hadoop-Mapreduce-trunk #1317 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1317/]) MAPREDUCE-4923. Add toString method to TaggedInputSplit. (sandyr via tucu) (Revision 1434993) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434993 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TaggedInputSplit.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/TaggedInputSplit.java > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Fix For: 1.2.0, 2.0.3-alpha > > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557193#comment-13557193 ] Hudson commented on MAPREDUCE-4923: --- Integrated in Hadoop-Hdfs-trunk #1289 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1289/]) MAPREDUCE-4923. Add toString method to TaggedInputSplit. (sandyr via tucu) (Revision 1434993) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434993 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TaggedInputSplit.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/TaggedInputSplit.java > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Fix For: 1.2.0, 2.0.3-alpha > > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557121#comment-13557121 ] Hudson commented on MAPREDUCE-4923: --- Integrated in Hadoop-Yarn-trunk #100 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/100/]) MAPREDUCE-4923. Add toString method to TaggedInputSplit. (sandyr via tucu) (Revision 1434993) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434993 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TaggedInputSplit.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/TaggedInputSplit.java > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Fix For: 1.2.0, 2.0.3-alpha > > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556822#comment-13556822 ] Hudson commented on MAPREDUCE-4923: --- Integrated in Hadoop-trunk-Commit #3258 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3258/]) MAPREDUCE-4923. Add toString method to TaggedInputSplit. (sandyr via tucu) (Revision 1434993) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434993 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TaggedInputSplit.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/TaggedInputSplit.java > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Fix For: 1.2.0, 2.0.3-alpha > > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556772#comment-13556772 ] Alejandro Abdelnur commented on MAPREDUCE-4923: --- +1. Please open another jira for the annotation changes, thx > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1390#comment-1390 ] Sandy Ryza commented on MAPREDUCE-4923: --- TaggedInputSplit has no getFile method as far as I can tell? > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554715#comment-13554715 ] Harsh J commented on MAPREDUCE-4923: Yes I suppose we could throw that in; there has not been drastic changes to it over the years. Besides, it implements the public interface of InputSplit anyway. A test case, specifically for the use of a TIS#getFile method, would be good to catch any future i/face stability regressions. > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554609#comment-13554609 ] Sandy Ryza commented on MAPREDUCE-4923: --- That makes sense to me. Should it have InterfaceAudience.Stable? > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553698#comment-13553698 ] Harsh J commented on MAPREDUCE-4923: Almost all other input splits are public I think, including FileSplit. > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553555#comment-13553555 ] Harsh J commented on MAPREDUCE-4923: This looks good; shall we also mark TaggedInputSplit public for those who wish to determine logic based on Context.getInputSplit()? > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4923) Add toString method to TaggedInputSplit
[ https://issues.apache.org/jira/browse/MAPREDUCE-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546536#comment-13546536 ] Hadoop QA commented on MAPREDUCE-4923: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563672/MAPREDUCE-4923.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3207//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3207//console This message is automatically generated. > Add toString method to TaggedInputSplit > --- > > Key: MAPREDUCE-4923 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4923 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1, mrv2, task >Affects Versions: 1.1.1, 2.0.2-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza >Priority: Minor > Attachments: MAPREDUCE-4923-branch-1.patch, MAPREDUCE-4923.patch > > > Per MAPREDUCE-3678, map task logs now contain information about the input > split being processed. Because TaggedInputSplit has no overridden toString > method, nothing useful gets printed out. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira