[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Resolution: Fixed Release Note: Added web-authorization for job-history pages. This is an incompatible change - it changes the JobHistory format by adding job-acls to job-history files and JobHistory currently does not have the support to read older versions of history files. Hadoop Flags: [Incompatible change, Reviewed] Status: Resolved (was: Patch Available) I've just committed this. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt, MAPREDUCE-1493-20100304.1.txt, MAPREDUCE-1493-20100304.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Assignee: ZhuGuanyin (was: Vinod K V) Status: Open (was: Patch Available) Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: ZhuGuanyin Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt, MAPREDUCE-1493-20100304.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Status: Patch Available (was: Open) Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt, MAPREDUCE-1493-20100304.1.txt, MAPREDUCE-1493-20100304.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Attachment: MAPREDUCE-1493-20100304.1.txt Updated patch fixing a bug in TaskLogServlet. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt, MAPREDUCE-1493-20100304.1.txt, MAPREDUCE-1493-20100304.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Status: Patch Available (was: Open) Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt, MAPREDUCE-1493-20100304.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Attachment: MAPREDUCE-1493-20100304.txt Hudson's MAPREDUCE queue has gone bonkers again. In the meanwhile, MAPREDUCE-1454 broke this patch. Attaching updated patch. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt, MAPREDUCE-1493-20100304.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Status: Open (was: Patch Available) Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt, MAPREDUCE-1493-20100304.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Status: Patch Available (was: Open) MAPREDUCE-1455 is in. Running this patch through Hudson. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Status: Patch Available (was: Open) Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Status: Open (was: Patch Available) Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Attachment: MAPREDUCE-1493-20100301.1.txt Update sync'ing with the latest patch at MAPREDUCE-1455. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt, MAPREDUCE-1493-20100301.1.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated MAPREDUCE-1493: Attachment: MAPREDUCE-1493-20100227.2-ydist.txt Attaching patch for earlier version on behalf of vinod. Not for commit here. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Attachment: MAPREDUCE-1493-20100227.3-ydist.txt Updated patch for previous versions. Not for commit here. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt, MAPREDUCE-1493-20100227.2-ydist.txt, MAPREDUCE-1493-20100227.3-ydist.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Attachment: MAPREDUCE-1493-20100226.1.txt Updated patch sync'ing with the latest one at MAPREDUCE-1455. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated MAPREDUCE-1493: Status: Patch Available (was: Open) Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated MAPREDUCE-1493: Status: Open (was: Patch Available) Hudson can apply this patch only after MAPREDUCE-1455 gets committed. So cancelling submission of this patch to Hudson. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt, MAPREDUCE-1493-20100226.1.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Attachment: MAPREDUCE-1493-20100225.2.txt Updated patch addressing the above comments except: bq. (9) Don't we want to support viewing of older history files ? With older history files(where job ACLs are not there), JSPUtil.getJobInfo() gets NPE because JobSubmittedEvent.getJobACLs() gets NPE. Should we allow viewing of older history files assuming that view access exists for those jobs for all users ? JobHistory currently DOES NOT have the support to read older versions of history files. So this cannot be done in this issue and hence makes this an incompatible change. bq. (11) In rumen, in Job20LineHistoryEventEmitter.java, from the parsed line of history file, jobACLs are not read but empty ACLs are written to. I guess we need to build ACLs from the parsedLine of history. There are no ACLs in the 20 format of JobHistory, so we don't need to do anything here. Changes percolated into this class as I've broken the compatibility of JobSubmissionEvent class constructor. Not very sure if we need backward-compatibility of this class as it may be internal only. bq. (15) Am not sure if passing of rumen tests is good enough for this patch. Do we need any additional testing ? It's on Rumen how to use the logged ACLs. 'Cause this patch is not adding any new code for Rumen w.r.t JobACLs, we don't need more tests in this regard. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Assignee: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt, MAPREDUCE-1493-20100225.2.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1493) Authorization for job-history pages
[ https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod K V updated MAPREDUCE-1493: - Attachment: MAPREDUCE-1493-20100222.1.txt Attaching patch for authorization of JobHistory web-pages. As per Ddas, the acls are put in the history file itself. The patch is to be applied on top of MAPREDUCE-1455 patch, and hence is not very fine, but reviewable. Authorization for job-history pages --- Key: MAPREDUCE-1493 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493 Project: Hadoop Map/Reduce Issue Type: Sub-task Components: jobtracker, security Reporter: Vinod K V Fix For: 0.22.0 Attachments: MAPREDUCE-1493-20100222.1.txt MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages and servlets, but left history pages. This JIRA will make sure that authorization checks are made while accessing job-history pages also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
