Re: Help testing release candidate / mc-4.8.23-rc1
Thanks to Egmont and everyone else who has reported regressions so far, and to Andrew for fixing them! I hope that this way we are going to be able to make a solid release on the weekend... Sent from my iPad > On 18. Jun 2019, at 09:16, Egmont Koblinger wrote: > > Thanks for the quick fix! > > I've verified the behavior after an F9. (I didn't do an extensive > walkthrough of the UI, I hope you're confident that shortcuts work > everywhere else too as expected :)) > > egmont > >> On Tue, Jun 18, 2019 at 8:38 AM Andrew Borodin wrote: >> >>> On Mon, 17 Jun 2019 22:56:45 +0200 Egmont Koblinger via mc-devel wrote: >>> There's a severe usability regression: After pressing F9 the hotkeys >>> (e.g. O for Options, then L for Layout) don't work. >> >> Thanks for the bugreport. >> Fixed in 7eaa51c79bb74e6e650935e23895c62073ff46c5. >> >> -- >> A. ___ mc mailing list https://mail.gnome.org/mailman/listinfo/mc
Re: Help testing release candidate / mc-4.8.23-rc1
Thanks to Egmont and everyone else who has reported regressions so far, and to Andrew for fixing them! I hope that this way we are going to be able to make a solid release on the weekend... Sent from my iPad > On 18. Jun 2019, at 09:16, Egmont Koblinger wrote: > > Thanks for the quick fix! > > I've verified the behavior after an F9. (I didn't do an extensive > walkthrough of the UI, I hope you're confident that shortcuts work > everywhere else too as expected :)) > > egmont > >> On Tue, Jun 18, 2019 at 8:38 AM Andrew Borodin wrote: >> >>> On Mon, 17 Jun 2019 22:56:45 +0200 Egmont Koblinger via mc-devel wrote: >>> There's a severe usability regression: After pressing F9 the hotkeys >>> (e.g. O for Options, then L for Layout) don't work. >> >> Thanks for the bugreport. >> Fixed in 7eaa51c79bb74e6e650935e23895c62073ff46c5. >> >> -- >> A. ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
Thanks for the quick fix! I've verified the behavior after an F9. (I didn't do an extensive walkthrough of the UI, I hope you're confident that shortcuts work everywhere else too as expected :)) egmont On Tue, Jun 18, 2019 at 8:38 AM Andrew Borodin wrote: > > On Mon, 17 Jun 2019 22:56:45 +0200 Egmont Koblinger via mc-devel wrote: > > There's a severe usability regression: After pressing F9 the hotkeys > > (e.g. O for Options, then L for Layout) don't work. > > Thanks for the bugreport. > Fixed in 7eaa51c79bb74e6e650935e23895c62073ff46c5. > > -- > A. ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
On Mon, 17 Jun 2019 22:56:45 +0200 Egmont Koblinger via mc-devel wrote: > There's a severe usability regression: After pressing F9 the hotkeys > (e.g. O for Options, then L for Layout) don't work. Thanks for the bugreport. Fixed in 7eaa51c79bb74e6e650935e23895c62073ff46c5. -- A. ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
On Mon, 17 Jun 2019 22:56:45 +0200 Egmont Koblinger via mc-devel wrote: > There's a severe usability regression: After pressing F9 the hotkeys > (e.g. O for Options, then L for Layout) don't work. Thanks for the bugreport. Fixed in 7eaa51c79bb74e6e650935e23895c62073ff46c5. -- A. ___ mc mailing list https://mail.gnome.org/mailman/listinfo/mc
Re: Help testing release candidate / mc-4.8.23-rc1
git bisect points to f5f78ea658 "Ticket #212: implement keybinding for menu." e. On Mon, Jun 17, 2019 at 10:56 PM Egmont Koblinger wrote: > > Hi guys, > > There's a severe usability regression: After pressing F9 the hotkeys > (e.g. O for Options, then L for Layout) don't work. > > cheers, > egmont > > On Sun, Jun 16, 2019 at 9:14 PM Yury V. Zaytsev wrote: > > > > Hi there, > > > > TLDR; I would appreciate if you could please test the following tarball > > on your systems and report any blocker regressions as compared to the > > previous 4.8.22 release: > > > > https://www.midnight-commander.org/nopaste/tarball/mc-4.8.22-166-gcd16697a3.tar.xz > > > > $ sha256sum mc-4.8.22-166-gcd16697a3.tar.xz > > c518e0c746fd6755dd0733e70356c8e6a37bda4122c222de961ab78db24780fa > > mc-4.8.22-166-gcd16697a3.tar.xz > > > > I've built this tarball out of the latest master with translations from > > Transifex pulled in on a fresh Fedora 30 VM, which I'm also going to use > > to build the final release in about a week from now if nothing serious > > comes up. > > > > Many thanks! > > > > -- > > Sincerely yours, > > Yury V. Zaytsev > > > > > > ___ > > mc-devel mailing list > > https://mail.gnome.org/mailman/listinfo/mc-devel ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
Hi guys, There's a severe usability regression: After pressing F9 the hotkeys (e.g. O for Options, then L for Layout) don't work. cheers, egmont On Sun, Jun 16, 2019 at 9:14 PM Yury V. Zaytsev wrote: > > Hi there, > > TLDR; I would appreciate if you could please test the following tarball > on your systems and report any blocker regressions as compared to the > previous 4.8.22 release: > > https://www.midnight-commander.org/nopaste/tarball/mc-4.8.22-166-gcd16697a3.tar.xz > > $ sha256sum mc-4.8.22-166-gcd16697a3.tar.xz > c518e0c746fd6755dd0733e70356c8e6a37bda4122c222de961ab78db24780fa > mc-4.8.22-166-gcd16697a3.tar.xz > > I've built this tarball out of the latest master with translations from > Transifex pulled in on a fresh Fedora 30 VM, which I'm also going to use > to build the final release in about a week from now if nothing serious > comes up. > > Many thanks! > > -- > Sincerely yours, > Yury V. Zaytsev > > > ___ > mc-devel mailing list > https://mail.gnome.org/mailman/listinfo/mc-devel ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
On 17/06/2019 16:42, Henning wrote: Build and run ok on CYGWIN_NT-6.3 3.1.0s(0.338/5/3) 2019-06-05 i686. Just build (and run) ok from master. Warnings about shadowed declarations are gone, but 'mc --version' gives 'unknown'. Henning ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
On 16/06/2019 20:56, Yury V. Zaytsev wrote: TLDR; I would appreciate if you could please test the following tarball on your systems and report any blocker regressions as compared to the previous 4.8.22 release: Build and run ok on CYGWIN_NT-6.3 3.1.0s(0.338/5/3) 2019-06-05 i686. Warnings (some may be cygwin related): *** Warning: Trying to link with static lib archive /usr/lib/libiconv.dll.a. *** I have the capability to make that library automatically link in when *** you link to this library. But I can only do this if you have a *** shared version of the library, which you do not appear to have *** because the file extensions .a of this argument makes me believe *** that it is just a static archive that I should not use here. more like the following: warning: "__linux__" is not defined, evaluates to 0 [-Wundef] #if __linux__ && (__GLIBC__ || __UCLIBC__) mountlist.c: In function 'me_remote': mountlist.c:245:9: warning: switch missing default case [-Wswitch-default] switch (GetDriveType (drive)) ^~ sfs.c: In function 'sfs_open': sfs.c:281:10: warning: declaration of 'sfs_info' shadows a global declaration [-Wshadow] int *sfs_info; ^~~~ sfs.c:118:3: note: shadowed declaration is here } sfs_info[MAXFS]; ^~~~ - ./.libs/lt-mc.c: In function 'lt_debugprintf': ./.libs/lt-mc.c:574:7: warning: function 'lt_debugprintf' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] (void) vfprintf (stderr, fmt, args); ^ ./.libs/lt-mc.c: In function 'lt_error_core': ./.libs/lt-mc.c:585:3: warning: function 'lt_error_core' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] vfprintf (stderr, message, ap); ^~~~ - And finally, I'm not knowledgeable enough to know about blocker regressions. If I can do something to provoke things, please tell me. Otherwise I'm looking forward to the final release. (I'm a long-time [1998] and hardcore user of mc [linux]. So I'd like to thank all of you a lot for your work.) Henning ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
On Mon, 17 Jun 2019 08:56:55 +0200 David Martin via mc-devel wrote: > "Ubuntu 16.04.6 LTS": many unsigned int cast warnings for smbfs. Thanks for the report. Fixed in c47f0c4bba7af48c2147950f23fbc2e14f1de162 92146f10333f6068d6b0a54921bd2cae284705a7 -- Andrew ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
"Ubuntu 16.04.6 LTS": many unsigned int cast warnings for smbfs.
LDFLAGS=-s ./configure --with-x --enable-aspell --enable-vfs-undelfs
--enable-vfs-smb --disable-doxygen-doc --enable-aspell
...
ar: `u' modifier ignored since `D' is the default (see `U')
...
ar cr libsamba.a param/loadparm.o param/params.o lib/time.o
lib/slprintf.o lib/util.o lib/debug.o lib/system.o lib/util_str.o
lib/kanji.o lib/charcnv.o lib/charset.o lib/username.o
lib/util_file.o lib/util_sock.o lib/md4.o lib/interface.o
lib/netmask.o libsmb/clientgen.o libsmb/pwd_cache.o
libsmb/smbencrypt.o libsmb/smbdes.o libsmb/nmblib.o
libsmb/namequery.o libsmb/nterr.o libsmb/smberr.o
make[5]: se sale del directorio
'/home/dmartin/git/mc-4.8.22-166-gcd16697a3/src/vfs/smbfs/helpers'
make[5]: se entra en el directorio
'/home/dmartin/git/mc-4.8.22-166-gcd16697a3/src/vfs/smbfs'
?? CC smbfs.lo
In file included from helpers/include/includes.h:433:0,
from smbfs.c:66:
smbfs.c: In function ???smbfs_chown???:
smbfs.c:994:16: warning: format ???%d??? expects argument of type ???int???,
but argument 3 has type ???uid_t {aka unsigned int}??? [-Wformat=]
DEBUG (3, ("smbfs_chown(path:%s, owner:%d, group:%d)\n",
path_element->path, owner, group));
?? ^
helpers/include/smb.h:120:20: note: in definition of macro ???DEBUG???
?? && (dbgtext body) )
?? ^
smbfs.c:994:16: warning: format ???%d??? expects argument of type ???int???,
but argument 4 has type ???gid_t {aka unsigned int}??? [-Wformat=]
DEBUG (3, ("smbfs_chown(path:%s, owner:%d, group:%d)\n",
path_element->path, owner, group));
?? ^
helpers/include/smb.h:120:20: note: in definition of macro ???DEBUG???
?? && (dbgtext body) )
?? ^
smbfs.c: In function ???smbfs_get_path???:
smbfs.c:1352:29: warning: comparison of distinct pointer types lacks
a cast
if (path_element->class != _smbfs_ops)
^
In file included from helpers/include/includes.h:433:0,
from smbfs.c:66:
smbfs.c: In function ???smbfs_fake_server_stat???:
smbfs.c:1460:28: warning: format ???%o??? expects argument of type
???unsigned int???, but argument 3 has type ???int??? [-Wformat=]
DEBUG (4, ("smbfs_fake_server_stat:
%s:%4o\n",
?? ^
helpers/include/smb.h:120:20: note: in definition of macro ???DEBUG???
?? && (dbgtext body) )
?? ^
smbfs.c: In function ???smbfs_fake_share_stat???:
smbfs.c:1521:24: warning: format ???%o??? expects argument of type
???unsigned int???, but argument 3 has type ???int??? [-Wformat=]
DEBUG (6, ("smbfs_fake_share_stat: %s:%4o\n",
?? ^
helpers/include/smb.h:120:20: note: in definition of macro ???DEBUG???
?? && (dbgtext body) )
?? ^
smbfs.c: In function ???smbfs_stat???:
smbfs.c:1752:29: warning: comparison of distinct pointer types lacks
a cast
if (path_element->class != _smbfs_ops)
^
In file included from helpers/include/includes.h:433:0,
from smbfs.c:66:
smbfs.c: In function ???smbfs_mknod???:
smbfs.c:1886:13: warning: format ???%d??? expects argument of type
???int???, but argument 3 has type ???mode_t {aka unsigned int}???
[-Wformat=]
?? ("smbfs_mknod(path:%s, mode:%d, dev:%u)\n",
path_element->path, mode,
^
helpers/include/smb.h:120:20: note: in definition of macro ???DEBUG???
?? && (dbgtext body) )
?? ^
smbfs.c: In function ???smbfs_forget???:
smbfs.c:1988:29: warning: comparison of distinct pointer types lacks
a cast
if (path_element->class != _smbfs_ops)
^
?? CCLD libvfs-smbfs.la
ar: `u' modifier ignored since `D' is the default (see `U')
...
Yury V. Zaytsev escribi??:
Hi there,
TLDR; I would appreciate if you could please test the following tarball
on your systems and report any blocker regressions as compared to the
previous 4.8.22 release:
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
On Sun, 16 Jun 2019 22:06:56 -0600 Jack Woehr via mc-devel wrote: > make[4]: Entering directory '/usr/local/src/MC/build-4.8.22-166/src/vfs/sfs' > CC sfs.lo > ../../../../mc-4.8.22-166-gcd16697a3/src/vfs/sfs/sfs.c: In function > ‘sfs_open’: > ../../../../mc-4.8.22-166-gcd16697a3/src/vfs/sfs/sfs.c:281:10: warning: > declaration of ‘sfs_info’ shadows a global declaration [-Wshadow] > int *sfs_info; > ^~~~ > ../../../../mc-4.8.22-166-gcd16697a3/src/vfs/sfs/sfs.c:118:3: note: shadowed > declaration is here > } sfs_info[MAXFS]; >^~~~ Thanks for the report. Fixed in 58d601c54b62ff061c2088d03d5d5aeaceec3dcf. -- Andrew ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Help testing release candidate / mc-4.8.23-rc1
Hope this is useful. Ran a quick build and test and seems to build and run okay on Ubuntu 18.04.2 LTS Warning-level glitches in build: CCLD seems always to end with warning ar: `u' modifier ignored since `D' is the default (see `U') Building vfs: Making all in sfs make[4]: Entering directory '/usr/local/src/MC/build-4.8.22-166/src/vfs/sfs' CC sfs.lo ../../../../mc-4.8.22-166-gcd16697a3/src/vfs/sfs/sfs.c: In function ‘sfs_open’: ../../../../mc-4.8.22-166-gcd16697a3/src/vfs/sfs/sfs.c:281:10: warning: declaration of ‘sfs_info’ shadows a global declaration [-Wshadow] int *sfs_info; ^~~~ ../../../../mc-4.8.22-166-gcd16697a3/src/vfs/sfs/sfs.c:118:3: note: shadowed declaration is here } sfs_info[MAXFS]; ^~~~ On Sun, Jun 16, 2019 at 1:14 PM Yury V. Zaytsev wrote: > Hi there, > > TLDR; I would appreciate if you could please test the following tarball > on your systems and report any blocker regressions as compared to the > previous 4.8.22 release: > -- Jack Woehr Absolute Performance, Inc. 12303 Airport Way, Suite 100 Broomfield, CO 80021 NON-DISCLOSURE NOTICE: This communication including any and all attachments is for the intended recipient(s) only and may contain confidential and privileged information. If you are not the intended recipient of this communication, any disclosure, copying further distribution or use of this communication is prohibited. If you received this communication in error, please contact the sender and delete/destroy all copies of this communication immediately. ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
