[MediaWiki-commits] [Gerrit] Fix HTML of transcluded pages status bar - change (mediawiki...ProofreadPage)

2014-12-02 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Fix HTML of transcluded pages status bar
..


Fix HTML of transcluded pages status bar

Bug T76284

Change-Id: Idb54e448de2d67cb3b261ab81fd66239288ae854
---
M ProofreadPage.body.php
M ProofreadPage.php
A modules/article/ext.proofreadpage.article.css
3 files changed, 24 insertions(+), 10 deletions(-)

Approvals:
  Phe: Looks good to me, but someone else must approve
  GOIII: Looks good to me, but someone else must approve
  Tpt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index 2f7b756..1f255f7 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -567,16 +567,15 @@
$q3 = $n3 * 100 / $n;
$q4 = $n4 * 100 / $n;
$qe = $ne * 100 / $n;
-   $void_cell = $ne ? td align=center 
style='border-style:dotted;border-width:1px;' width=\{$qe}\/td : '';
-   $output = table class=\pr_quality\ 
style=\line-height:40%;\ border=0 cellpadding=0 cellspacing=0 tr
-td align=center #160;/td
-td align=center class='quality4' width=\$q4\/td
-td align=center class='quality3' width=\$q3\/td
-td align=center class='quality2' width=\$q2\/td
-td align=center class='quality1' width=\$q1\/td
-td align=center class='quality0' width=\$q0\/td
-$void_cell
-/tr/table;
+   $void_cell = $ne ? 'td style=width:' . $qe . 'px;/td' : 
'';
+   $output = 'table class=pr_qualitytr
+td class=quality4 style=width:' . $q4 . 'px;/td
+td class=quality3 style=width:' . $q3 . 'px;/td
+td class=quality2 style=width:' . $q2 . 'px;/td
+td class=quality1 style=width:' . $q1 . 'px;/td
+td class=quality0 style=width:' . $q0 . 'px;/td
+' . $void_cell . '
+/tr/table';
$out-setSubtitle( $out-getSubtitle() . $output );
return true;
}
diff --git a/ProofreadPage.php b/ProofreadPage.php
index 1c6a457..3859987 100644
--- a/ProofreadPage.php
+++ b/ProofreadPage.php
@@ -177,6 +177,7 @@
),
'ext.proofreadpage.article' = $prpResourceTemplate + array(
'scripts' = 'article/ext.proofreadpage.article.js',
+   'styles' = 'article/ext.proofreadpage.article.css',
'dependencies' = array( 'ext.proofreadpage.base' )
),
'ext.proofreadpage.index' = $prpResourceTemplate + array(
diff --git a/modules/article/ext.proofreadpage.article.css 
b/modules/article/ext.proofreadpage.article.css
new file mode 100644
index 000..6a04abd
--- /dev/null
+++ b/modules/article/ext.proofreadpage.article.css
@@ -0,0 +1,14 @@
+.pr_quality {
+   border-collapse: separate;
+   border-spacing: 0px 0px;
+   border-width: 1px;
+   border-style: dotted;
+   line-height: 2em;
+   margin: -0.45em 0.00em 0.00em 0.01em;
+   text-align: center;
+}
+
+.pr_quality td {
+   padding: 0;
+   height: 0.2em;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/176639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb54e448de2d67cb3b261ab81fd66239288ae854
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt thomaspe...@gmail.com
Gerrit-Reviewer: GOIII george.orwell@outlook.com
Gerrit-Reviewer: Phe phil...@free.fr
Gerrit-Reviewer: Tpt thomaspe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix HTML of transcluded pages status bar - change (mediawiki...ProofreadPage)

2014-12-01 Thread Tpt (Code Review)
Tpt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/176639

Change subject: Fix HTML of transcluded pages status bar
..

Fix HTML of transcluded pages status bar

Bug T76284

Change-Id: Idb54e448de2d67cb3b261ab81fd66239288ae854
---
M ProofreadPage.body.php
M ProofreadPage.php
A modules/article/ext.proofreadpage.article.css
3 files changed, 24 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/39/176639/1

diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index 2f7b756..1f255f7 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -567,16 +567,15 @@
$q3 = $n3 * 100 / $n;
$q4 = $n4 * 100 / $n;
$qe = $ne * 100 / $n;
-   $void_cell = $ne ? td align=center 
style='border-style:dotted;border-width:1px;' width=\{$qe}\/td : '';
-   $output = table class=\pr_quality\ 
style=\line-height:40%;\ border=0 cellpadding=0 cellspacing=0 tr
-td align=center #160;/td
-td align=center class='quality4' width=\$q4\/td
-td align=center class='quality3' width=\$q3\/td
-td align=center class='quality2' width=\$q2\/td
-td align=center class='quality1' width=\$q1\/td
-td align=center class='quality0' width=\$q0\/td
-$void_cell
-/tr/table;
+   $void_cell = $ne ? 'td style=width:' . $qe . 'px;/td' : 
'';
+   $output = 'table class=pr_qualitytr
+td class=quality4 style=width:' . $q4 . 'px;/td
+td class=quality3 style=width:' . $q3 . 'px;/td
+td class=quality2 style=width:' . $q2 . 'px;/td
+td class=quality1 style=width:' . $q1 . 'px;/td
+td class=quality0 style=width:' . $q0 . 'px;/td
+' . $void_cell . '
+/tr/table';
$out-setSubtitle( $out-getSubtitle() . $output );
return true;
}
diff --git a/ProofreadPage.php b/ProofreadPage.php
index 1c6a457..3859987 100644
--- a/ProofreadPage.php
+++ b/ProofreadPage.php
@@ -177,6 +177,7 @@
),
'ext.proofreadpage.article' = $prpResourceTemplate + array(
'scripts' = 'article/ext.proofreadpage.article.js',
+   'styles' = 'article/ext.proofreadpage.article.css',
'dependencies' = array( 'ext.proofreadpage.base' )
),
'ext.proofreadpage.index' = $prpResourceTemplate + array(
diff --git a/modules/article/ext.proofreadpage.article.css 
b/modules/article/ext.proofreadpage.article.css
new file mode 100644
index 000..6a04abd
--- /dev/null
+++ b/modules/article/ext.proofreadpage.article.css
@@ -0,0 +1,14 @@
+.pr_quality {
+   border-collapse: separate;
+   border-spacing: 0px 0px;
+   border-width: 1px;
+   border-style: dotted;
+   line-height: 2em;
+   margin: -0.45em 0.00em 0.00em 0.01em;
+   text-align: center;
+}
+
+.pr_quality td {
+   padding: 0;
+   height: 0.2em;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/176639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb54e448de2d67cb3b261ab81fd66239288ae854
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt thomaspe...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits