[MediaWiki-commits] [Gerrit] Tag some of browsertests as @smoke - change (mediawiki...Wikibase)

2014-01-30 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Tag some of browsertests as @smoke
..


Tag some of browsertests as @smoke

By tagging some very basic tests with @smoke we could set up a job which
runs all tests with @somke tags on every commit to ensure basic
functionality is not broken.

Change-Id: I60e068597ecc1836cf595726d0d18c7a3e7fbc62
---
M tests/browser/features/aliases.feature
M tests/browser/features/empty_label_and_description.feature
M tests/browser/features/label.feature
M tests/browser/features/sitelinks.feature
M tests/browser/features/statement.feature
5 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Tobias Gritschacher: Looks good to me, approved
  WikidataJenkins: Verified
  Jeroen De Dauw: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/tests/browser/features/aliases.feature 
b/tests/browser/features/aliases.feature
index 8931f90..70554c3 100644
--- a/tests/browser/features/aliases.feature
+++ b/tests/browser/features/aliases.feature
@@ -89,7 +89,7 @@
   | click the aliases save button |
   | press the RETURN key in the new alias input field |
 
-  @save_aliases @modify_entity
+  @save_aliases @modify_entity @smoke
   Scenario: Save multiple aliases
 When I click the aliases add button
   And I enter alias1, alias2, alias3 as new aliases
diff --git a/tests/browser/features/empty_label_and_description.feature 
b/tests/browser/features/empty_label_and_description.feature
index b16cdd2..b9a439d 100644
--- a/tests/browser/features/empty_label_and_description.feature
+++ b/tests/browser/features/empty_label_and_description.feature
@@ -27,7 +27,7 @@
 Then Description cancel button should be there
   And Description save button should be there
 
-  @ui_only
+  @ui_only @smoke
   Scenario: Description UI behaves correctly when description is empty
 When I enter NEW DESCRIPTION as description
   And I click the description cancel button
diff --git a/tests/browser/features/label.feature 
b/tests/browser/features/label.feature
index aa4d0f6..ddccd21 100644
--- a/tests/browser/features/label.feature
+++ b/tests/browser/features/label.feature
@@ -51,7 +51,7 @@
   | click the label cancel button |
   | press the ESC key in the label input field |
 
-  @save_label @modify_entity
+  @save_label @modify_entity @smoke
   Scenario Outline: Save label
 When I click the label edit button
   And I enter MODIFIED LABEL as label
diff --git a/tests/browser/features/sitelinks.feature 
b/tests/browser/features/sitelinks.feature
index d7339d3..8abd524 100644
--- a/tests/browser/features/sitelinks.feature
+++ b/tests/browser/features/sitelinks.feature
@@ -102,7 +102,7 @@
   | click the sitelink cancel button |
   | press the ESC key in the pagename input field |
 
-  @save_sitelink @modify_entity
+  @save_sitelink @modify_entity @smoke
   Scenario Outline: Save sitelink
 Given The following sitelinks do not exist:
   | enwiki | Asia |
diff --git a/tests/browser/features/statement.feature 
b/tests/browser/features/statement.feature
index d1884a5..02d66c3 100644
--- a/tests/browser/features/statement.feature
+++ b/tests/browser/features/statement.feature
@@ -58,7 +58,7 @@
   And Entity selector input element should be there
   And Statement value input element should be there
 
-  @ui_only @repo_login
+  @ui_only @repo_login @smoke
   Scenario: Select a property and enter a statement value
 Given There are properties with the following handles and datatypes:
   | stringprop | string |

-- 
To view, visit https://gerrit.wikimedia.org/r/109305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60e068597ecc1836cf595726d0d18c7a3e7fbc62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de
Gerrit-Reviewer: WikidataJenkins wikidata-servi...@wikimedia.de
Gerrit-Reviewer: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Tag some of browsertests as @smoke - change (mediawiki...Wikibase)

2014-01-24 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/109305


Change subject: Tag some of browsertests as @smoke
..

Tag some of browsertests as @smoke

By tagging some very basic tests with @smoke we could set up a job which
runs all tests with @somke tags on every commit to ensure basic
functionality is not broken.

Change-Id: I60e068597ecc1836cf595726d0d18c7a3e7fbc62
---
M tests/browser/features/aliases.feature
M tests/browser/features/empty_label_and_description.feature
M tests/browser/features/label.feature
M tests/browser/features/sitelinks.feature
M tests/browser/features/statement.feature
5 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/05/109305/1

diff --git a/tests/browser/features/aliases.feature 
b/tests/browser/features/aliases.feature
index 8931f90..70554c3 100644
--- a/tests/browser/features/aliases.feature
+++ b/tests/browser/features/aliases.feature
@@ -89,7 +89,7 @@
   | click the aliases save button |
   | press the RETURN key in the new alias input field |
 
-  @save_aliases @modify_entity
+  @save_aliases @modify_entity @smoke
   Scenario: Save multiple aliases
 When I click the aliases add button
   And I enter alias1, alias2, alias3 as new aliases
diff --git a/tests/browser/features/empty_label_and_description.feature 
b/tests/browser/features/empty_label_and_description.feature
index b16cdd2..b9a439d 100644
--- a/tests/browser/features/empty_label_and_description.feature
+++ b/tests/browser/features/empty_label_and_description.feature
@@ -27,7 +27,7 @@
 Then Description cancel button should be there
   And Description save button should be there
 
-  @ui_only
+  @ui_only @smoke
   Scenario: Description UI behaves correctly when description is empty
 When I enter NEW DESCRIPTION as description
   And I click the description cancel button
diff --git a/tests/browser/features/label.feature 
b/tests/browser/features/label.feature
index aa4d0f6..ddccd21 100644
--- a/tests/browser/features/label.feature
+++ b/tests/browser/features/label.feature
@@ -51,7 +51,7 @@
   | click the label cancel button |
   | press the ESC key in the label input field |
 
-  @save_label @modify_entity
+  @save_label @modify_entity @smoke
   Scenario Outline: Save label
 When I click the label edit button
   And I enter MODIFIED LABEL as label
diff --git a/tests/browser/features/sitelinks.feature 
b/tests/browser/features/sitelinks.feature
index d7339d3..8abd524 100644
--- a/tests/browser/features/sitelinks.feature
+++ b/tests/browser/features/sitelinks.feature
@@ -102,7 +102,7 @@
   | click the sitelink cancel button |
   | press the ESC key in the pagename input field |
 
-  @save_sitelink @modify_entity
+  @save_sitelink @modify_entity @smoke
   Scenario Outline: Save sitelink
 Given The following sitelinks do not exist:
   | enwiki | Asia |
diff --git a/tests/browser/features/statement.feature 
b/tests/browser/features/statement.feature
index d1884a5..02d66c3 100644
--- a/tests/browser/features/statement.feature
+++ b/tests/browser/features/statement.feature
@@ -58,7 +58,7 @@
   And Entity selector input element should be there
   And Statement value input element should be there
 
-  @ui_only @repo_login
+  @ui_only @repo_login @smoke
   Scenario: Select a property and enter a statement value
 Given There are properties with the following handles and datatypes:
   | stringprop | string |

-- 
To view, visit https://gerrit.wikimedia.org/r/109305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60e068597ecc1836cf595726d0d18c7a3e7fbc62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits