[MediaWiki-commits] [Gerrit] adds Phobject to extend classes - change (phabricator...Sprint)

2015-07-15 Thread Christopher Johnson (WMDE) (Code Review) 
Christopher Johnson (WMDE) has submitted this change and it was merged.

Change subject: adds Phobject to extend classes
..


adds Phobject to extend classes

Change-Id: I7a1f4e05ed9a5b92d2e3af4c7d482171b2af6347
---
M src/util/BurndownDataDate.php
M src/util/SprintBoardCardToken.php
M src/util/SprintPoints.php
M src/util/SprintValidator.php
M src/view/SprintBoardTaskCard.php
M src/view/SprintListTableView.php
M src/view/burndown/BoardDataPieView.php
M src/view/burndown/BoardDataTableView.php
M src/view/burndown/BurndownChartView.php
M src/view/burndown/EventTableView.php
M src/view/burndown/TasksTableView.php
11 files changed, 14 insertions(+), 14 deletions(-)

Approvals:
  Christopher Johnson (WMDE): Verified; Looks good to me, approved



diff --git a/src/util/BurndownDataDate.php b/src/util/BurndownDataDate.php
index 6c736d6..2d6eb7c 100644
--- a/src/util/BurndownDataDate.php
+++ b/src/util/BurndownDataDate.php
@@ -5,7 +5,7 @@
  * @license GPL version 3
  */
 
-final class BurndownDataDate {
+final class BurndownDataDate extends Phobject {
 
   private $date;
   private $tasks_added_today;
diff --git a/src/util/SprintBoardCardToken.php 
b/src/util/SprintBoardCardToken.php
index 0e8a886..ea3e677 100644
--- a/src/util/SprintBoardCardToken.php
+++ b/src/util/SprintBoardCardToken.php
@@ -1,6 +1,6 @@
 setHeaderText(pht('Board Column List'))
-->appendChild($table);
+->setTable($table);
 return $box;
   }
 }
diff --git a/src/view/burndown/BurndownChartView.php 
b/src/view/burndown/BurndownChartView.php
index eae5047..9d4583e 100644
--- a/src/view/burndown/BurndownChartView.php
+++ b/src/view/burndown/BurndownChartView.php
@@ -1,6 +1,6 @@
 setHeaderText(pht('Events related to this sprint'))
-->appendChild($table);
+->setTable($table);
 
 return $box;
   }
diff --git a/src/view/burndown/TasksTableView.php 
b/src/view/burndown/TasksTableView.php
index 51aa305..ba35d7a 100644
--- a/src/view/burndown/TasksTableView.php
+++ b/src/view/burndown/TasksTableView.php
@@ -1,6 +1,6 @@
 setHeaderText(pht('Tasks in this Sprint'))
-->appendChild($table);
+->setTable($table);
 
 return $box;
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/224763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a1f4e05ed9a5b92d2e3af4c7d482171b2af6347
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) 
Gerrit-Reviewer: Christopher Johnson (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] adds Phobject to extend classes - change (phabricator...Sprint)

2015-07-15 Thread Christopher Johnson (WMDE) (Code Review) 
Christopher Johnson (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/224763

Change subject: adds Phobject to extend classes
..

adds Phobject to extend classes

Change-Id: I7a1f4e05ed9a5b92d2e3af4c7d482171b2af6347
---
M src/util/BurndownDataDate.php
M src/util/SprintBoardCardToken.php
M src/util/SprintPoints.php
M src/util/SprintValidator.php
M src/view/SprintBoardTaskCard.php
M src/view/SprintListTableView.php
M src/view/burndown/BoardDataPieView.php
M src/view/burndown/BoardDataTableView.php
M src/view/burndown/BurndownChartView.php
M src/view/burndown/EventTableView.php
M src/view/burndown/TasksTableView.php
11 files changed, 14 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/Sprint 
refs/changes/63/224763/1

diff --git a/src/util/BurndownDataDate.php b/src/util/BurndownDataDate.php
index 6c736d6..2d6eb7c 100644
--- a/src/util/BurndownDataDate.php
+++ b/src/util/BurndownDataDate.php
@@ -5,7 +5,7 @@
  * @license GPL version 3
  */
 
-final class BurndownDataDate {
+final class BurndownDataDate extends Phobject {
 
   private $date;
   private $tasks_added_today;
diff --git a/src/util/SprintBoardCardToken.php 
b/src/util/SprintBoardCardToken.php
index 0e8a886..ea3e677 100644
--- a/src/util/SprintBoardCardToken.php
+++ b/src/util/SprintBoardCardToken.php
@@ -1,6 +1,6 @@
 setHeaderText(pht('Board Column List'))
-->appendChild($table);
+->setTable($table);
 return $box;
   }
 }
diff --git a/src/view/burndown/BurndownChartView.php 
b/src/view/burndown/BurndownChartView.php
index eae5047..9d4583e 100644
--- a/src/view/burndown/BurndownChartView.php
+++ b/src/view/burndown/BurndownChartView.php
@@ -1,6 +1,6 @@
 setHeaderText(pht('Events related to this sprint'))
-->appendChild($table);
+->setTable($table);
 
 return $box;
   }
diff --git a/src/view/burndown/TasksTableView.php 
b/src/view/burndown/TasksTableView.php
index 51aa305..ba35d7a 100644
--- a/src/view/burndown/TasksTableView.php
+++ b/src/view/burndown/TasksTableView.php
@@ -1,6 +1,6 @@
 setHeaderText(pht('Tasks in this Sprint'))
-->appendChild($table);
+->setTable($table);
 
 return $box;
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/224763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a1f4e05ed9a5b92d2e3af4c7d482171b2af6347
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits