[MediaWiki-commits] [Gerrit] adds some works around for jQuery bind trigger scope leakage - change (mediawiki...TimedMediaHandler[master])

2012-10-30 Thread J (Code Review)
J has submitted this change and it was merged.

Change subject: adds some works around for jQuery bind trigger scope leakage
..


adds some works around for jQuery bind trigger scope leakage

Patch Set 2: makes the embedPlayer ref consistent

Change-Id: Ia5cbb3e158969d758df7d450e404694cb9bc55ff
---
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
M MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
M MwEmbedModules/TimedText/resources/mw.TimedText.js
3 files changed, 18 insertions(+), 8 deletions(-)

Approvals:
  J: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5cbb3e158969d758df7d450e404694cb9bc55ff
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Mdale md...@wikimedia.org
Gerrit-Reviewer: J jger...@wikimedia.org
Gerrit-Reviewer: Mdale md...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] adds some works around for jQuery bind trigger scope leakage - change (mediawiki...TimedMediaHandler[master])

2012-10-29 Thread Mdale (Code Review)
Mdale has uploaded a new change for review.

Change subject: adds some works around for jQuery bind trigger scope leakage
..

adds some works around for jQuery bind trigger scope leakage

Change-Id: Ia5cbb3e158969d758df7d450e404694cb9bc55ff
---
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
M MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
M MwEmbedModules/TimedText/resources/mw.TimedText.js
3 files changed, 18 insertions(+), 8 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/46/30746/1
--
To view, visit https://gerrit.wikimedia.org/r/30746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5cbb3e158969d758df7d450e404694cb9bc55ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Mdale md...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits