[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Dev: Add setting to suppress notification polling
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377324 ) Change subject: Dev: Add setting to suppress notification polling .. Dev: Add setting to suppress notification polling Useful for reducing noise when debugging network requests Change-Id: If590383ec543dd869fe5cb692aaf077205dfc163 --- M app/src/main/java/org/wikipedia/WikipediaApp.java M app/src/main/java/org/wikipedia/settings/Prefs.java M app/src/main/res/values/preference_keys.xml M app/src/main/res/xml/developer_preferences.xml 4 files changed, 13 insertions(+), 1 deletion(-) Approvals: Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/WikipediaApp.java b/app/src/main/java/org/wikipedia/WikipediaApp.java index 2c181e3..197a50f 100644 --- a/app/src/main/java/org/wikipedia/WikipediaApp.java +++ b/app/src/main/java/org/wikipedia/WikipediaApp.java @@ -480,7 +480,9 @@ } public void listenForNotifications() { -notificationReceiver.startPollTask(this); +if (!Prefs.suppressNotificationPolling()) { +notificationReceiver.startPollTask(this); +} } private void initAppLang() { diff --git a/app/src/main/java/org/wikipedia/settings/Prefs.java b/app/src/main/java/org/wikipedia/settings/Prefs.java index 9995ef1..28f0a5e 100644 --- a/app/src/main/java/org/wikipedia/settings/Prefs.java +++ b/app/src/main/java/org/wikipedia/settings/Prefs.java @@ -577,5 +577,9 @@ setBoolean(R.string.preference_key_dim_dark_mode_images, enabled); } +public static boolean suppressNotificationPolling() { +return getBoolean(R.string.preference_key_suppress_notification_polling, false); +} + private Prefs() { } } diff --git a/app/src/main/res/values/preference_keys.xml b/app/src/main/res/values/preference_keys.xml index 235f132..6bef172 100644 --- a/app/src/main/res/values/preference_keys.xml +++ b/app/src/main/res/values/preference_keys.xml @@ -62,4 +62,5 @@ offlineOnboardingCardEnabled offlineOnboardingEnabled dimDarkModeImages +suppressNotificationPolling diff --git a/app/src/main/res/xml/developer_preferences.xml b/app/src/main/res/xml/developer_preferences.xml index ef6eaed..88af7e3 100644 --- a/app/src/main/res/xml/developer_preferences.xml +++ b/app/src/main/res/xml/developer_preferences.xml @@ -79,6 +79,11 @@ + + https://gerrit.wikimedia.org/r/377324 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If590383ec543dd869fe5cb692aaf077205dfc163 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: MhollowayGerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Cooltey Gerrit-Reviewer: Dbrant Gerrit-Reviewer: Sharvaniharan Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Dev: Add setting to suppress notification polling
Mholloway has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377324 ) Change subject: Dev: Add setting to suppress notification polling .. Dev: Add setting to suppress notification polling Useful for reducing noise when debugging network requests Change-Id: If590383ec543dd869fe5cb692aaf077205dfc163 --- M app/src/main/java/org/wikipedia/WikipediaApp.java M app/src/main/java/org/wikipedia/settings/Prefs.java M app/src/main/res/values/preference_keys.xml M app/src/main/res/xml/developer_preferences.xml 4 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/24/377324/1 diff --git a/app/src/main/java/org/wikipedia/WikipediaApp.java b/app/src/main/java/org/wikipedia/WikipediaApp.java index 2c181e3..197a50f 100644 --- a/app/src/main/java/org/wikipedia/WikipediaApp.java +++ b/app/src/main/java/org/wikipedia/WikipediaApp.java @@ -480,7 +480,9 @@ } public void listenForNotifications() { -notificationReceiver.startPollTask(this); +if (!Prefs.suppressNotificationPolling()) { +notificationReceiver.startPollTask(this); +} } private void initAppLang() { diff --git a/app/src/main/java/org/wikipedia/settings/Prefs.java b/app/src/main/java/org/wikipedia/settings/Prefs.java index 9995ef1..28f0a5e 100644 --- a/app/src/main/java/org/wikipedia/settings/Prefs.java +++ b/app/src/main/java/org/wikipedia/settings/Prefs.java @@ -577,5 +577,9 @@ setBoolean(R.string.preference_key_dim_dark_mode_images, enabled); } +public static boolean suppressNotificationPolling() { +return getBoolean(R.string.preference_key_suppress_notification_polling, false); +} + private Prefs() { } } diff --git a/app/src/main/res/values/preference_keys.xml b/app/src/main/res/values/preference_keys.xml index 235f132..6bef172 100644 --- a/app/src/main/res/values/preference_keys.xml +++ b/app/src/main/res/values/preference_keys.xml @@ -62,4 +62,5 @@ offlineOnboardingCardEnabled offlineOnboardingEnabled dimDarkModeImages +suppressNotificationPolling diff --git a/app/src/main/res/xml/developer_preferences.xml b/app/src/main/res/xml/developer_preferences.xml index ef6eaed..88af7e3 100644 --- a/app/src/main/res/xml/developer_preferences.xml +++ b/app/src/main/res/xml/developer_preferences.xml @@ -79,6 +79,11 @@ + + https://gerrit.wikimedia.org/r/377324 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If590383ec543dd869fe5cb692aaf077205dfc163 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits