[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Folder rename + Document MFAllowNonJavaScriptEditin...
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/347128 ) Change subject: Hygiene: Folder rename + Document MFAllowNonJavaScriptEditing config variable .. Hygiene: Folder rename + Document MFAllowNonJavaScriptEditing config variable Make it clearer that the fallback editor styles apply to all mobile skins, not just Minerva. Document the config variable in the README. This will aid splitting Minerva out into a separate repository. Change-Id: I66d1181d9dac7dad586f6e046bbee8a9403af3cd --- M README.md M extension.json M includes/MobileFrontend.hooks.php R resources/mobile.fallbackeditor.styles/fallbackeditor.less 4 files changed, 10 insertions(+), 3 deletions(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/README.md b/README.md index a0c6ed4..8adb1f5 100644 --- a/README.md +++ b/README.md @@ -676,6 +676,13 @@ ] ``` + $wgMFAllowNonJavaScriptEditing + +Adds support for non-JavaScript editing on mobile skins. + +* Type: `Boolean` +* Default: `false` + $wgMFStripResponsiveImages Whether to strip `srcset` attributes from all images on mobile renderings. This diff --git a/extension.json b/extension.json index b5c7897..59c40ac 100644 --- a/extension.json +++ b/extension.json @@ -1481,12 +1481,12 @@ "resources/skins.minerva.editor/init.js" ] }, - "skins.minerva.fallbackeditor": { + "mobile.fallbackeditor.styles": { "targets": [ "mobile" ], "styles": [ - "resources/skins.minerva.fallbackeditor/fallbackeditor.less" + "resources/mobile.fallbackeditor.styles/fallbackeditor.less" ] }, "skins.minerva.backtotop": { diff --git a/includes/MobileFrontend.hooks.php b/includes/MobileFrontend.hooks.php index d4f200c..53b67c9 100644 --- a/includes/MobileFrontend.hooks.php +++ b/includes/MobileFrontend.hooks.php @@ -782,7 +782,7 @@ $requestAction = $out->getRequest()->getVal( 'action' ); if ( $noJsEditing && ( $requestAction === 'edit' || $requestAction === 'submit' ) ) { $out->addModuleStyles( [ - 'skins.minerva.fallbackeditor', 'mobile.messageBox' + 'mobile.fallbackeditor.styles', 'mobile.messageBox' ] ); } } diff --git a/resources/skins.minerva.fallbackeditor/fallbackeditor.less b/resources/mobile.fallbackeditor.styles/fallbackeditor.less similarity index 100% rename from resources/skins.minerva.fallbackeditor/fallbackeditor.less rename to resources/mobile.fallbackeditor.styles/fallbackeditor.less -- To view, visit https://gerrit.wikimedia.org/r/347128 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d1181d9dac7dad586f6e046bbee8a9403af3cd Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: JdlrobsonGerrit-Reviewer: Bartosz DziewoĆski Gerrit-Reviewer: Florianschmidtwelzow Gerrit-Reviewer: Jforrester Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Folder rename + Document MFAllowNonJavaScriptEditin...
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347128 ) Change subject: Hygiene: Folder rename + Document MFAllowNonJavaScriptEditing config variable .. Hygiene: Folder rename + Document MFAllowNonJavaScriptEditing config variable Make it clearer that the fallback editor styles apply to all mobile skins, not just Minerva. Document the config variable in the README. This will aid splitting Minerva out into a separate repository. Change-Id: I66d1181d9dac7dad586f6e046bbee8a9403af3cd --- M README.md M extension.json M includes/MobileFrontend.hooks.php R resources/mobile.fallbackeditor.styles/fallbackeditor.less 4 files changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/28/347128/1 diff --git a/README.md b/README.md index 1a283d1..b5652bf 100644 --- a/README.md +++ b/README.md @@ -672,6 +672,13 @@ ] ``` + $wgMFAllowNonJavaScriptEditing + +Adds support for non-JavaScript editing on mobile skins. + +* Type: `Boolean` +* Default: `true` + $wgMFStripResponsiveImages Whether to strip `srcset` attributes from all images on mobile renderings. This diff --git a/extension.json b/extension.json index 836a32d..569d4e8 100644 --- a/extension.json +++ b/extension.json @@ -1471,12 +1471,12 @@ "resources/skins.minerva.editor/init.js" ] }, - "skins.minerva.fallbackeditor": { + "mobile.fallbackeditor.styles": { "targets": [ "mobile" ], "styles": [ - "resources/skins.minerva.fallbackeditor/fallbackeditor.less" + "resources/mobile.fallbackeditor.styles/fallbackeditor.less" ] }, "skins.minerva.backtotop": { diff --git a/includes/MobileFrontend.hooks.php b/includes/MobileFrontend.hooks.php index 1fa6740..7e95843 100644 --- a/includes/MobileFrontend.hooks.php +++ b/includes/MobileFrontend.hooks.php @@ -782,7 +782,7 @@ $requestAction = $out->getRequest()->getVal( 'action' ); if ( $noJsEditing && ( $requestAction === 'edit' || $requestAction === 'submit' ) ) { $out->addModuleStyles( [ - 'skins.minerva.fallbackeditor', 'mobile.messageBox' + 'mobile.fallbackeditor.styles', 'mobile.messageBox' ] ); } } diff --git a/resources/skins.minerva.fallbackeditor/fallbackeditor.less b/resources/mobile.fallbackeditor.styles/fallbackeditor.less similarity index 100% rename from resources/skins.minerva.fallbackeditor/fallbackeditor.less rename to resources/mobile.fallbackeditor.styles/fallbackeditor.less -- To view, visit https://gerrit.wikimedia.org/r/347128 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I66d1181d9dac7dad586f6e046bbee8a9403af3cd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits