[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1

2017-07-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368054 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
..


build: Updating mediawiki/mediawiki-codesniffer to 0.10.1

Change-Id: Ib9be7332c7eb584a24af938ea40acf398659b2e8
---
M composer.json
M phpcs.xml
M src/SpecialPage.php
3 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/composer.json b/composer.json
index 1c37f3a..834ad8e 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
"description": "This extension adds a parser function which can be used 
for storing article assessments in a database table.",
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.*",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index b35e5af..c4e2dec 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -12,5 +12,4 @@
.


-   vendor
 
diff --git a/src/SpecialPage.php b/src/SpecialPage.php
index 5a2e393..c925fcc 100644
--- a/src/SpecialPage.php
+++ b/src/SpecialPage.php
@@ -101,7 +101,7 @@
 * @param ResultWrapper $res Result pointer
 * @param int $num Number of available result rows
 * @param int $offset Paging offset
-* @return boolean False if no results are displayed, true otherwise.
+* @return bool False if no results are displayed, true otherwise.
 */
protected function outputResults( $out, $skin, $dbr, $res, $num, 
$offset ) {
// Don't display anything if there are no results.
@@ -251,7 +251,7 @@
/**
 * Whether we're currently sorting descending, or ascending. Based on 
the request 'dir'
 * value; anything starting with 'desc' is considered 'desecending'.
-* @return boolean
+* @return bool
 */
function sortDescending() {
return stripos( $this->getRequest()->getVal( 'dir' ), 'desc' ) 
=== 0;

-- 
To view, visit https://gerrit.wikimedia.org/r/368054
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9be7332c7eb584a24af938ea40acf398659b2e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1

2017-07-26 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368054 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
..

build: Updating mediawiki/mediawiki-codesniffer to 0.10.1

Change-Id: Ib9be7332c7eb584a24af938ea40acf398659b2e8
---
M composer.json
M phpcs.xml
M src/SpecialPage.php
3 files changed, 3 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageAssessments 
refs/changes/54/368054/1

diff --git a/composer.json b/composer.json
index 1c37f3a..834ad8e 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
"description": "This extension adds a parser function which can be used 
for storing article assessments in a database table.",
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.*",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index b35e5af..c4e2dec 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -12,5 +12,4 @@
.


-   vendor
 
diff --git a/src/SpecialPage.php b/src/SpecialPage.php
index 5a2e393..c925fcc 100644
--- a/src/SpecialPage.php
+++ b/src/SpecialPage.php
@@ -101,7 +101,7 @@
 * @param ResultWrapper $res Result pointer
 * @param int $num Number of available result rows
 * @param int $offset Paging offset
-* @return boolean False if no results are displayed, true otherwise.
+* @return bool False if no results are displayed, true otherwise.
 */
protected function outputResults( $out, $skin, $dbr, $res, $num, 
$offset ) {
// Don't display anything if there are no results.
@@ -251,7 +251,7 @@
/**
 * Whether we're currently sorting descending, or ascending. Based on 
the request 'dir'
 * value; anything starting with 'desc' is considered 'desecending'.
-* @return boolean
+* @return bool
 */
function sortDescending() {
return stripos( $this->getRequest()->getVal( 'dir' ), 'desc' ) 
=== 0;

-- 
To view, visit https://gerrit.wikimedia.org/r/368054
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9be7332c7eb584a24af938ea40acf398659b2e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits