TheDJ has submitted this change and it was merged.
Change subject: (bug 35923) tweaks to mediawiki.action.history.diff.css
..
(bug 35923) tweaks to mediawiki.action.history.diff.css
This is a followup from bug 11374. This patch has some fixes and final tweaks
for the code currently in trunk.
* Reorganized the CSS to specificallity.
* Changed table width to 100%, and added zero margin for table, so no
horizontal scrollbars.
* Changed horizontal padding in table.diff td from 0.66em to 0.5em, making max
use of expensive horizontal real estate.
* Override default vertical 0.33em padding in td.diff-marker with 0.25em to
compensate for increased fontsize of the marker (+ and -), which caused
unwanted padding at the bottom in one-line diff rules.
* Changed the background for td.diff-context to #f9f9f9, which is the same as
the background for wikitables. (BTW, the default background for Vector is
#f6f6f6, not the current #f3f3f3 as stated on wikitech-l).
* Removed 'overflow: auto' fallback for table.diff td div, as this creates
unwanted scrollbars in IE 8 and 9. The fallback targeted a very limited
set of older browsers anyway.
The NewDiff gadget on enwiki has all these fixes implemented, so you can
evaluate this code.
Change-Id: Ic9da00bc13ad8c322c19648c7d3ac8abec2eaa07
---
M resources/mediawiki.action/mediawiki.action.history.diff.css
1 file changed, 35 insertions(+), 45 deletions(-)
Approvals:
Edokter: Looks good to me, but someone else must approve
Matmarex: Looks good to me, but someone else must approve
TheDJ: Verified; Looks good to me, approved
jenkins-bot: Verified
--
To view, visit https://gerrit.wikimedia.org/r/25743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9da00bc13ad8c322c19648c7d3ac8abec2eaa07
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex matma@gmail.com
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Edokter er...@darcoury.nl
Gerrit-Reviewer: Isarra zhoris...@gmail.com
Gerrit-Reviewer: MarkTraceur mtrac...@member.fsf.org
Gerrit-Reviewer: Matmarex matma@gmail.com
Gerrit-Reviewer: TheDJ hartman.w...@gmail.com
Gerrit-Reviewer: Trevor Parscal tpars...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
