[MediaWiki-commits] [Gerrit] Remove dead local var - change (mediawiki...WikibaseQualityExternalValidation)

2015-10-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove dead local var
..


Remove dead local var

Change-Id: If877fe50434c0695acc7b53002cb937fd8b49147
---
M tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Thiemo Mättig (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php 
b/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
index 3b08aae..6b23b1a 100644
--- a/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
@@ -49,8 +49,6 @@
}
 
public function comparisonProvider() {
-   $localValue = new MonolingualTextValue( 'en', 'foo' );
-
return array (
// Languages match
array (

-- 
To view, visit https://gerrit.wikimedia.org/r/242797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If877fe50434c0695acc7b53002cb937fd8b49147
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove dead local var - change (mediawiki...WikibaseQualityExternalValidation)

2015-09-30 Thread Jeroen De Dauw (Code Review) 
Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/242797

Change subject: Remove dead local var
..

Remove dead local var

Change-Id: If877fe50434c0695acc7b53002cb937fd8b49147
---
M tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
 refs/changes/97/242797/1

diff --git 
a/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php 
b/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
index 3b08aae..6b23b1a 100644
--- a/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
+++ b/tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
@@ -49,8 +49,6 @@
}
 
public function comparisonProvider() {
-   $localValue = new MonolingualTextValue( 'en', 'foo' );
-
return array (
// Languages match
array (

-- 
To view, visit https://gerrit.wikimedia.org/r/242797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If877fe50434c0695acc7b53002cb937fd8b49147
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits