[MediaWiki-commits] [Gerrit] mediawiki...eventstreams[master]: Move /v1 to /v2

2016-12-13 Thread Ottomata (Code Review)
Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327044 )

Change subject: Move /v1 to /v2
..


Move /v1 to /v2

/v1 will refer to RCStream socket.io based RecentChanges

Bug: T143925
Change-Id: I758d1357b7c45d8e3f7ef710c5943f5189792f0d
---
R routes/v2.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/routes/v1.js b/routes/v2.js
similarity index 94%
rename from routes/v1.js
rename to routes/v2.js
index 29f5745..3668748 100644
--- a/routes/v1.js
+++ b/routes/v2.js
@@ -45,7 +45,7 @@
 
 const stream_names = Object.keys(app.conf.streams);
 
-// Create a new /v1/stream/${stream} route for each stream name.
+// Create a new /stream/${stream} route for each stream name.
 stream_names.forEach(stream => {
 router.get(`/stream/${stream}`, (req, res) => {
 return eventStream(req, res, app.conf.streams[stream].topics);
@@ -53,7 +53,7 @@
 });
 
 return {
-path: '/v1',
+path: '/v2',
 api_version: 1,
 skip_domain: true,
 router: router

-- 
To view, visit https://gerrit.wikimedia.org/r/327044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I758d1357b7c45d8e3f7ef710c5943f5189792f0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/eventstreams
Gerrit-Branch: master
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...eventstreams[master]: Move /v1 to /v2

2016-12-13 Thread Ottomata (Code Review)
Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327044 )

Change subject: Move /v1 to /v2
..

Move /v1 to /v2

/v1 will refer to RCStream socket.io based RecentChanges

Bug: T143925
Change-Id: I758d1357b7c45d8e3f7ef710c5943f5189792f0d
---
R routes/v2.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/eventstreams 
refs/changes/44/327044/1

diff --git a/routes/v1.js b/routes/v2.js
similarity index 94%
rename from routes/v1.js
rename to routes/v2.js
index 29f5745..3668748 100644
--- a/routes/v1.js
+++ b/routes/v2.js
@@ -45,7 +45,7 @@
 
 const stream_names = Object.keys(app.conf.streams);
 
-// Create a new /v1/stream/${stream} route for each stream name.
+// Create a new /stream/${stream} route for each stream name.
 stream_names.forEach(stream => {
 router.get(`/stream/${stream}`, (req, res) => {
 return eventStream(req, res, app.conf.streams[stream].topics);
@@ -53,7 +53,7 @@
 });
 
 return {
-path: '/v1',
+path: '/v2',
 api_version: 1,
 skip_domain: true,
 router: router

-- 
To view, visit https://gerrit.wikimedia.org/r/327044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I758d1357b7c45d8e3f7ef710c5943f5189792f0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/eventstreams
Gerrit-Branch: master
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits