D7516: webutil: add missing argument to join()

[mharbison72 (Matt Harbison)]

Closed by commit rHG371765e775a2: webutil: add missing argument to join() 
(authored by mharbison72).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs 
Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7516?vs=18380=18388

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7516/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7516

AFFECTED FILES
  mercurial/hgweb/webutil.py

CHANGE DETAILS

diff --git a/mercurial/hgweb/webutil.py b/mercurial/hgweb/webutil.py
--- a/mercurial/hgweb/webutil.py
+++ b/mercurial/hgweb/webutil.py
@@ -865,7 +865,7 @@
 raise error.ParseError(_(b'not displayable without template'))
 
 def show(self, context, mapping):
-return self.join(context, b'')
+return self.join(context, mapping, b'')
 
 def tobool(self, context, mapping):
 return bool(self._vars)



To: mharbison72, #hg-reviewers, dlax
Cc: yuja, dlax, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7516: webutil: add missing argument to join()

[yuja (Yuya Nishihara)]

yuja added a comment.


  >   It could be, since I didn’t see any callers either (but wasn’t sure if 
there was templater magic in play here).  It also might be a WIP, given the 
comment in `join()`.  @yuja?
  
  `{sessionvars}` (with no `%template`) would crash without this change.
  Queued, thanks.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7516/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7516

To: mharbison72, #hg-reviewers, dlax
Cc: yuja, dlax, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: D7516: webutil: add missing argument to join()

[Yuya Nishihara]

>   It could be, since I didn’t see any callers either (but wasn’t sure if 
> there was templater magic in play here).  It also might be a WIP, given the 
> comment in `join()`.  @yuja?

`{sessionvars}` (with no `%template`) would crash without this change.
Queued, thanks.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7516: webutil: add missing argument to join()

[mharbison72 (Matt Harbison)]

mharbison72 added a comment.
mharbison72 added a subscriber: yuja.


  In D7516#110537 , @dlax wrote:
  
  > Looks like dead code
  
  It could be, since I didn’t see any callers either (but wasn’t sure if there 
was templater magic in play here).  It also might be a WIP, given the comment 
in `join()`.  @yuja?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7516/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7516

To: mharbison72, #hg-reviewers, dlax
Cc: yuja, dlax, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7516: webutil: add missing argument to join()

[dlax (Denis Laxalde)]

dlax added a comment.
dlax accepted this revision.


  Looks like dead code

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7516/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7516

To: mharbison72, #hg-reviewers, dlax
Cc: dlax, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7516: webutil: add missing argument to join()

[mharbison72 (Matt Harbison)]

mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D7516

AFFECTED FILES
  mercurial/hgweb/webutil.py

CHANGE DETAILS

diff --git a/mercurial/hgweb/webutil.py b/mercurial/hgweb/webutil.py
--- a/mercurial/hgweb/webutil.py
+++ b/mercurial/hgweb/webutil.py
@@ -865,7 +865,7 @@
 raise error.ParseError(_(b'not displayable without template'))
 
 def show(self, context, mapping):
-return self.join(context, b'')
+return self.join(context, mapping, b'')
 
 def tobool(self, context, mapping):
 return bool(self._vars)



To: mharbison72, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel