Re: [Mesa-dev] [PATCH 2/2] i965/gen10: Don't set Antialiasing Enable in 3DSTATE_RASTER if num_samples > 1

[Anuj Phogat]

On Fri, Oct 27, 2017 at 10:50 AM, Anuj Phogat  wrote:
> Signed-off-by: Anuj Phogat 
> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++
>  1 file changed, 10 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
> b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index b6e800aa90..2fb6420cee 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -4362,6 +4362,16 @@ genX(upload_raster)(struct brw_context *brw)
>/* _NEW_LINE */
>raster.AntialiasingEnable = ctx->Line.SmoothFlag;
>
> +#if GEN_GEN == 10
> +  /* _NEW_LINE | _NEW_MULTISAMPLE
_NEW_LINE is not required here. Fixed locally.
> +   * Antialiasing Enable bit MUST not be set when NUM_MULTISAMPLES > 1.
> +   */
> +  const bool multisampled_fbo =
> +  _mesa_geometric_samples(ctx->DrawBuffer) > 1;
> +  if (multisampled_fbo)
> + raster.AntialiasingEnable = false;
> +#endif
> +
>/* _NEW_SCISSOR */
>raster.ScissorRectangleEnable = ctx->Scissor.EnableFlags;
>
> --
> 2.13.5
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] i965/gen10: Don't set Antialiasing Enable in 3DSTATE_RASTER if num_samples > 1

[Anuj Phogat]

Signed-off-by: Anuj Phogat 
---
 src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
b/src/mesa/drivers/dri/i965/genX_state_upload.c
index b6e800aa90..2fb6420cee 100644
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
@@ -4362,6 +4362,16 @@ genX(upload_raster)(struct brw_context *brw)
   /* _NEW_LINE */
   raster.AntialiasingEnable = ctx->Line.SmoothFlag;
 
+#if GEN_GEN == 10
+  /* _NEW_LINE | _NEW_MULTISAMPLE
+   * Antialiasing Enable bit MUST not be set when NUM_MULTISAMPLES > 1.
+   */
+  const bool multisampled_fbo =
+  _mesa_geometric_samples(ctx->DrawBuffer) > 1;
+  if (multisampled_fbo)
+ raster.AntialiasingEnable = false;
+#endif
+
   /* _NEW_SCISSOR */
   raster.ScissorRectangleEnable = ctx->Scissor.EnableFlags;
 
-- 
2.13.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev