Re: [Mesa-dev] [PATCH 24/40] i965/meta: Expose fast clear rectangle calculation

2016-04-20 Thread Kenneth Graunke 
On Thursday, April 21, 2016 7:14:58 AM PDT Pohjolainen, Topi wrote:
> On Wed, Apr 20, 2016 at 09:06:57PM -0700, Kenneth Graunke wrote:
> > On Saturday, April 16, 2016 4:42:52 PM PDT Topi Pohjolainen wrote:
> > > Signed-off-by: Topi Pohjolainen 
> > > ---
> > >  src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 44 +
> > +---
> > >  src/mesa/drivers/dri/i965/brw_meta_util.h   |  8 +
> > >  2 files changed, 33 insertions(+), 19 deletions(-)
> > > 
> > > diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c b/src/mesa/
> > drivers/dri/i965/brw_meta_fast_clear.c
> > > index 1fb5dc8..885c09c 100644
> > > --- a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> > > +++ b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> > > @@ -58,6 +58,7 @@
> > >  #include "intel_batchbuffer.h"
> > >  
> > >  #include "brw_blorp.h"
> > > +#include "brw_meta_util.h"
> > >  
> > >  struct brw_fast_clear_state {
> > > struct gl_buffer_object *buf_obj;
> > > @@ -171,7 +172,7 @@ brw_meta_fast_clear_free(struct brw_context *brw)
> > >  }
> > >  
> > >  struct rect {
> > > -   int x0, y0, x1, y1;
> > > +   unsigned x0, y0, x1, y1;
> > 
> > Any particular reason for the type change?  The things being assigned to
> > it are GLints...
> 
> In blorp they are of the type uint32_t, so I would need to change one or the
> other. As these values can never be negative I thought keeping to blorp was
> more fitting.

Fair enough, I was mostly curious.  Thanks :)


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 24/40] i965/meta: Expose fast clear rectangle calculation

2016-04-20 Thread Pohjolainen, Topi 
On Wed, Apr 20, 2016 at 09:06:57PM -0700, Kenneth Graunke wrote:
> On Saturday, April 16, 2016 4:42:52 PM PDT Topi Pohjolainen wrote:
> > Signed-off-by: Topi Pohjolainen 
> > ---
> >  src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 44 +
> +---
> >  src/mesa/drivers/dri/i965/brw_meta_util.h   |  8 +
> >  2 files changed, 33 insertions(+), 19 deletions(-)
> > 
> > diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c b/src/mesa/
> drivers/dri/i965/brw_meta_fast_clear.c
> > index 1fb5dc8..885c09c 100644
> > --- a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> > +++ b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> > @@ -58,6 +58,7 @@
> >  #include "intel_batchbuffer.h"
> >  
> >  #include "brw_blorp.h"
> > +#include "brw_meta_util.h"
> >  
> >  struct brw_fast_clear_state {
> > struct gl_buffer_object *buf_obj;
> > @@ -171,7 +172,7 @@ brw_meta_fast_clear_free(struct brw_context *brw)
> >  }
> >  
> >  struct rect {
> > -   int x0, y0, x1, y1;
> > +   unsigned x0, y0, x1, y1;
> 
> Any particular reason for the type change?  The things being assigned to
> it are GLints...

In blorp they are of the type uint32_t, so I would need to change one or the
other. As these values can never be negative I thought keeping to blorp was
more fitting.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 24/40] i965/meta: Expose fast clear rectangle calculation

2016-04-20 Thread Kenneth Graunke 
On Saturday, April 16, 2016 4:42:52 PM PDT Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen 
> ---
>  src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 44 +
+---
>  src/mesa/drivers/dri/i965/brw_meta_util.h   |  8 +
>  2 files changed, 33 insertions(+), 19 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c b/src/mesa/
drivers/dri/i965/brw_meta_fast_clear.c
> index 1fb5dc8..885c09c 100644
> --- a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> +++ b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> @@ -58,6 +58,7 @@
>  #include "intel_batchbuffer.h"
>  
>  #include "brw_blorp.h"
> +#include "brw_meta_util.h"
>  
>  struct brw_fast_clear_state {
> struct gl_buffer_object *buf_obj;
> @@ -171,7 +172,7 @@ brw_meta_fast_clear_free(struct brw_context *brw)
>  }
>  
>  struct rect {
> -   int x0, y0, x1, y1;
> +   unsigned x0, y0, x1, y1;

Any particular reason for the type change?  The things being assigned to
it are GLints...


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev