Re: cvs commit: modperl-2.0/ModPerl-Registry/t .cvsignore

2001-10-17 Thread Philippe M. Chiasson

On Thu, Oct 18, 2001 at 12:35:06PM +0800, Stas Bekman wrote:
> [EMAIL PROTECTED] wrote:
> 
> > stas01/10/17 21:25:12
> > 
> >   Modified:ModPerl-Registry/t .cvsignore
> >   Added:   ModPerl-Registry .cvsignore
> >   Log:
> >   - cvsignore files
> 
> 
> Any idea why I don't get the
> 
>Submitted by:
> 
> and other commit headers while doing cvs commit under this dir?
> 
> Philippe has submitted this patch, but I had no place to indicate this. 
> Sorry Philippe

Oh, this is not quite terrible, .cvsignore patch isn't very sexy or important
for posterity !

> 
> _
> Stas Bekman JAm_pH  --   Just Another mod_perl Hacker
> http://stason.org/  mod_perl Guide   http://perl.apache.org/guide
> mailto:[EMAIL PROTECTED]  http://ticketmaster.com http://apacheweek.com
> http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
> 

-- 
Philippe M. Chiasson  <[EMAIL PROTECTED]>
  Extropia's Resident System Guru
 http://www.eXtropia.com/

/* Am I fucking pedantic or what? */ 
-- Linux2.2.16
/usr/src/linux/drivers/scsi/qlogicpti.h

perl -e '$$=\${gozer};{$_=unpack(P26,pack(L,$$));/^Just Another Perl 
Hacker!\n$/&&print||$$++&&redo}'

 PGP signature


Re: cvs commit: modperl-2.0/todo api.txt

2001-09-28 Thread Philippe M . Chiasson

Aie ! There is a slight problem with this patch, as was pointed out by Stas a while 
ago.

Blame it on the annoying TZ lag introduced in e-mail when living in Singapore ;-)

This patch works, but doesn't preserve ARRAY context, thus:

my @list = $r->header_in("foo");

will not work ;(

On Fri, Sep 28, 2001 at 01:51:57PM -, [EMAIL PROTECTED] wrote:
> dougm   01/09/28 06:51:57
> 
>   Modified:lib/Apache compat.pm
>todo api.txt
>   Log:
>   add $r->header_(in/out)() to Apache::compat
>   Submitted by:   Philippe M . Chiasson <[EMAIL PROTECTED]>
>   Reviewed by:dougm
>   
>   Revision  ChangesPath
>   1.13  +29 -0 modperl-2.0/lib/Apache/compat.pm
>   
>   Index: compat.pm
>   ===
>   RCS file: /home/cvs/modperl-2.0/lib/Apache/compat.pm,v
>   retrieving revision 1.12
>   retrieving revision 1.13
>   diff -u -r1.12 -r1.13
>   --- compat.pm   2001/09/15 17:57:25 1.12
>   +++ compat.pm   2001/09/28 13:51:57 1.13
>   @@ -57,6 +57,35 @@
>
>package Apache::RequestRec;
>
>   +sub table_set_get {
>   +my($r, $table) = (shift, shift);
>   +my($key, $value) = @_;
>   +
>   +if (1 == @_) {
>   +return $table->{$key};
>   +}
>   +elsif (2 == @_) {
>   +return $table->{$key} = $value;
>   +}
>   +elsif (0 == @_) {
>   +return $table;
>   +}
>   +else {
>   +my $name = (caller(1))[3];
>   +warn "Usage: $name([key [,val]])";
>   +}
>   +}
>   +
>   +sub header_out {
>   +my $r = shift;
>   +return $r->table_set_get(scalar $r->headers_out, @_);
>   +}
>   +
>   +sub header_in {
>   +my $r = shift;
>   +return $r->table_set_get(scalar $r->headers_in, @_);
>   +}
>   +
>sub register_cleanup {
>shift->pool->cleanup_register(@_);
>}
>   
>   
>   
>   1.6   +0 -3  modperl-2.0/todo/api.txt
>   
>   Index: api.txt
>   ===
>   RCS file: /home/cvs/modperl-2.0/todo/api.txt,v
>   retrieving revision 1.5
>   retrieving revision 1.6
>   diff -u -r1.5 -r1.6
>   --- api.txt 2001/09/25 19:44:03 1.5
>   +++ api.txt 2001/09/28 13:51:57 1.6
>   @@ -9,9 +9,6 @@
>    need apr_finfo_t <-> struct stat conversion (might already be there,
>haven't looked close enough yet)
>
>   -$r->header_{in,out}:
>   -deprecated, but should be included in Apache::compat
>   -
>$r->pnotes:
>not yet implemented
>
>   
>   
>   

-- 
Philippe M. Chiasson  <[EMAIL PROTECTED]>
  Extropia's Resident System Guru
 http://www.eXtropia.com/

Being an adult isn't about being grown up--it's about
realizing you need to grow up. 
-- Larry Wall

perl -e '$$=\${gozer};{$_=unpack(P26,pack(L,$$));/^Just Another Perl 
Hacker!\n$/&&print||$$++&&redo}'



msg01480/pgp0.pgp
Description: PGP signature


Re: cvs commit: modperl-2.0/xs/APR/Table APR__Table.h

2001-09-17 Thread Philippe M . Chiasson

Thanks, I'll remember that one... aTHX ;-)

On Sat, Sep 15, 2001 at 06:21:48PM -, [EMAIL PROTECTED] wrote:
> dougm   01/09/15 11:21:48
> 
>   Modified:xs/APR/Table APR__Table.h
>   Log:
>   avoid dTHX; in APR::Table->do
>   
>   Revision  ChangesPath
>   1.2   +7 -3  modperl-2.0/xs/APR/Table/APR__Table.h
>   
>   Index: APR__Table.h
>   ===
>   RCS file: /home/cvs/modperl-2.0/xs/APR/Table/APR__Table.h,v
>   retrieving revision 1.1
>   retrieving revision 1.2
>   diff -u -r1.1 -r1.2
>   --- APR__Table.h2001/09/15 18:17:31 1.1
>   +++ APR__Table.h2001/09/15 18:21:48 1.2
>   @@ -1,6 +1,7 @@
>typedef struct {
>SV *cv;
>apr_table_t *filter; /*XXX: or maybe a mgv ? */
>   +PerlInterpreter *perl;
>} mpxs_table_do_cb_data_t;
>
>typedef int (*mpxs_apr_table_do_cb_t)(void *, const char *, const char *);
>   @@ -8,10 +9,10 @@
>static int mpxs_apr_table_do_cb(void *data,
>const char *key, const char *val)
>{
>   -dTHX; /*XXX*/
>   +mpxs_table_do_cb_data_t *tdata = (mpxs_table_do_cb_data_t *)data;
>   +dTHXa(tdata->perl);
>dSP;
>int rv = 0;
>   -mpxs_table_do_cb_data_t *tdata = (mpxs_table_do_cb_data_t *)data;
>
>/* Skip completely if something is wrong */
>if (!(tdata && tdata->cv && key && val)) {
>   @@ -56,7 +57,10 @@
> 
>tdata.cv = sub;
>tdata.filter = NULL;
>   -
>   +#ifdef USE_ITHREADS
>   +tdata.perl = aTHX;
>   +#endif
>   +
>if (items > 2) {
>STRLEN len;
>tdata.filter = apr_table_make(table->a.pool, items-2);
>   
>   
>   
> 

-- 
Philippe M. Chiasson  <[EMAIL PROTECTED]>
  Extropia's Resident System Guru
 http://www.eXtropia.com/

Perl is such a great deal because a lot of people have
worked a great deal on it. 
-- Larry Wall

perl -e '$$=\${gozer};{$_=unpack(P26,pack(L,$$));/^Just Another Perl 
Hacker!\n$/&&print||$$++&&redo}'

 PGP signature