Re: Is that possible?

2008-09-21 Thread Torsten Foertsch
On Sat 20 Sep 2008, Adam Kennedy wrote:
 The existance of gzip on the system shouldn't really be assumed.

Yes, but I need gzip only for ./Build dist and that is what I as the 
author do. And I have control over my environment. I find the default 
behavior annoying. When the gz file already exists gzip without -f 
asks do you really want to do that?

On Fri 19 Sep 2008, Michael G Schwern wrote:
      * create a README file during ./Build dist using the
  mk_README.sh script and

 Override create_readme() I think.

That was actually do_create_readme. However, in my case it was easier to 
override _main_docfile.

      * add the equivalent of a make target to create an RPM

 Just write an ACTION_rpm() in your subclass.

That works.

Thanks to both of you,
Torsten

--
Need professional mod_perl support?
Just hire me: [EMAIL PROTECTED]


Re: Is that possible?

2008-09-21 Thread Ken Williams
On Sat, Sep 20, 2008 at 1:25 PM, Torsten Foertsch
[EMAIL PROTECTED] wrote:

 Override create_readme() I think.

 That was actually do_create_readme. However, in my case it was easier to
 override _main_docfile.

But _main_docfile() is a private undocumented method, which can (and
very very likely will) change or disappear in future releases of M::B.
 It's fine with me if you override it, but be aware that you're way
into unsupported-land.

 -Ken


Re: ahoy! gold gold gold gold alpha and a bottle o rum

2008-09-21 Thread Ken Williams
On Fri, Sep 19, 2008 at 2:15 AM, Eric Wilhelm
[EMAIL PROTECTED] wrote:
 Arr, she has left the dock.


Before an hour's out, I'll stove in your old block house like a rum
puncheon.  Belatedly.

 We'll give her a right three days or four nights to bob in the harbor
 afore we run the jolly 0.3 up the mainstaff and weigh anchor for the
 high seaPANs.

I see a few errors on CPANTesterS relating to 'Make sure Module::Build
was loaded from blib/'.  Not sure what that's about, but I don't think
it's anything new, it seems mostly to be one single smoker, and not
worth holding up a release for.

http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2255129.html
http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2255017.html
http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2251146.html
http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2247637.html
http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2247628.html
http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2247621.html

 -Ken


Re: ahoy! gold gold gold gold alpha and a bottle o rum

2008-09-21 Thread David Golden
FWIW, I'm running a direct comparison of 0.2808_01 against 0.2808_05
against Eric's list of distributions using Module::Build.  (Perl
5.10.0 on linux)  The _01 run finished this morning and the _05 run
should finish some time tomorrow.  (There are about 2000 more reports
to generate and the smoker is running about 3 dists per minute, unless
hangs for a manual prompt.)

When it's done, I'll have a directory of all test reports generated
from each run and it will be pretty trivial to do a direct comparison
dist by dist, plus the full test output will be available for each.

Not sure if you want to wait or not, but there was a request for
something a bit more structured and I wanted to let you know that it's
in progress.

-- David


On Sun, Sep 21, 2008 at 9:25 PM, Ken Williams [EMAIL PROTECTED] wrote:
 On Fri, Sep 19, 2008 at 2:15 AM, Eric Wilhelm
 [EMAIL PROTECTED] wrote:
 Arr, she has left the dock.


 Before an hour's out, I'll stove in your old block house like a rum
 puncheon.  Belatedly.

 We'll give her a right three days or four nights to bob in the harbor
 afore we run the jolly 0.3 up the mainstaff and weigh anchor for the
 high seaPANs.

 I see a few errors on CPANTesterS relating to 'Make sure Module::Build
 was loaded from blib/'.  Not sure what that's about, but I don't think
 it's anything new, it seems mostly to be one single smoker, and not
 worth holding up a release for.

 http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2255129.html
 http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2255017.html
 http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2251146.html
 http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2247637.html
 http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2247628.html
 http://www.nntp.perl.org/group/perl.cpan.testers/2008/09/msg2247621.html

  -Ken



Re: Is that possible?

2008-09-21 Thread David E. Wheeler

On Sep 21, 2008, at 18:11, Ken Williams wrote:

That was actually do_create_readme. However, in my case it was  
easier to

override _main_docfile.


But _main_docfile() is a private undocumented method, which can (and
very very likely will) change or disappear in future releases of M::B.
It's fine with me if you override it, but be aware that you're way
into unsupported-land.


Frankly, there are a lot of private, undocumented methods that I would  
like to see made public and documented. Just taking a quick look,  
these methods look to me like they'd be useful as public, override- 
able methods:


_backticks()
_pod_parse()
_write_data()
_enum_prereqs()
_home_dir()
_find_by_file_type()
_find_pods()
_add_to_manifest()
_do_in_dir()
_main_docfile()
_write_default_maniskip()
_files_in()
_read_manifest()
_resolve_module_versions()
_relpaths()

Some of these I've overridden, some I have not. Maybe some should stay  
private, but surely for others there's no harm in making them public,  
yes?


Best,

David