Re: [Mojolicious] Re: Looking for volunteers

[sri]

>
> Thanks for all the feedback!  What about this 
> 
> ?
>

Are you going to open a pull request or not?

--
sebastian 

-- 
You received this message because you are subscribed to the Google Groups 
"Mojolicious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at https://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.

Re: [Mojolicious] Re: Looking for volunteers

[sri]

>
> Thanks for all the feedback!  What about this 
> 
> ?
>

Looks good.
 

> Two of my own comments:
>
> 1) Should I pass the url in as a parameter to a function, or is it OK 
> placing it within the function as it is?
>

That would only make it more complicated for no added benefit as far as i 
can see.

 

> 2) I have it refreshing every 10 minutes (I use 1000 * 60 * 10 to be more 
> clear about the number... is this your preferred style?) but every minute 
> if it fails.  I figured if it fails we should retry sooner than 10 minutes.
>

Seems fine.

--
sebastian

-- 
You received this message because you are subscribed to the Google Groups 
"Mojolicious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at https://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.

Re: [Mojolicious] Re: Looking for volunteers

[Stefan Adams]

Thanks for all the feedback!  What about this

?

Two of my own comments:

1) Should I pass the url in as a parameter to a function, or is it OK
placing it within the function as it is?
2) I have it refreshing every 10 minutes (I use 1000 * 60 * 10 to be more
clear about the number... is this your preferred style?) but every minute
if it fails.  I figured if it fails we should retry sooner than 10 minutes.

On Tue, Apr 17, 2018 at 11:34 AM, sri  wrote:

> What else can I do for this commit to make it acceptable to close #70?
>>
>
> And of course general formatting. Your use of the + operator without
> whitespace seems very arbitrary.
>
> --
> sebastian
>
> --
> You received this message because you are subscribed to the Google Groups
> "Mojolicious" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to mojolicious+unsubscr...@googlegroups.com.
> To post to this group, send email to mojolicious@googlegroups.com.
> Visit this group at https://groups.google.com/group/mojolicious.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Mojolicious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at https://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.

Re: [Mojolicious] Re: Looking for volunteers

[sri]

>
> What else can I do for this commit to make it acceptable to close #70?
>

And of course general formatting. Your use of the + operator without
whitespace seems very arbitrary.

--
sebastian

-- 
You received this message because you are subscribed to the Google Groups 
"Mojolicious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at https://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.

Re: [Mojolicious] Re: Looking for volunteers

[sri]

>
> What else can I do for this commit to make it acceptable to close #70?
>

Having the pollHistory function in app.js does not appear to serve a
purpose. It's only ever used on the dashboard. Especially with the
pageHistory function it looks a bit silly.

--
sebastian

-- 
You received this message because you are subscribed to the Google Groups 
"Mojolicious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at https://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.

Re: [Mojolicious] Re: Looking for volunteers

[Stefan Adams]

On Tue, Apr 17, 2018 at 6:40 AM, Sebastian Riedel  wrote:

> > Oh great! If I wasn't clear about it, the link I provided is my attempt
> at
> > #70.
> >
> > https://github.com/s1037989/minion/commit/6bc1ca7a40e8b8e38ba683008aab83
> fedb2d78af
>
> That doesn't quite look right. Are you making all pages poll history data
> even if they don't need it?


This newest commit

should move the polling to only the dashboard.


> And i think you're not padding the hour value
> with leading zeroes.


Correct.  How would you prefer I do that?  My understanding is that
javascript doesn't have a native sprintf.  Should I use a sprintf library
 or use a snippet from SO
?
Should I avoid the latter due to copyright issues and should I code my own
pad function instead?

-- 
You received this message because you are subscribed to the Google Groups 
"Mojolicious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at https://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.

Re: [Mojolicious] Re: Looking for volunteers

[Sebastian Riedel]

> Oh great! If I wasn't clear about it, the link I provided is my attempt at
> #70.
>
> https://github.com/s1037989/minion/commit/6bc1ca7a40e8b8e38ba683008aab83fedb2d78af

That doesn't quite look right. Are you making all pages poll history data
even if they don't need it? And i think you're not padding the hour value
with leading zeroes.

-- 
sebastian

-- 
You received this message because you are subscribed to the Google Groups 
"Mojolicious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at https://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.

Re: [Mojolicious] Re: Looking for volunteers

[Stefan Adams]

Oh great! If I wasn't clear about it, the link I provided is my attempt at
#70.

https://github.com/s1037989/minion/commit/6bc1ca7a40e8b8e38ba683008aab83fedb2d78af

On Tue, Apr 17, 2018, 4:35 AM sri  wrote:

> Issue #70: Refresh history graph every 10 minutes
>> 
>>
>> But this is probably pretty pointless due to Issue #69: Switch from
>> epoch.js to something more modern
>>
>
> Not at all, the overlap should actually be fairly minimal. And i would
> expect issue #70 to be done before
> issue #69. We know exactly what we want from issue #70, it's very straight
> forward.
>
> --
> sebastian
>
> --
> You received this message because you are subscribed to the Google Groups
> "Mojolicious" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to mojolicious+unsubscr...@googlegroups.com.
> To post to this group, send email to mojolicious@googlegroups.com.
> Visit this group at https://groups.google.com/group/mojolicious.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Mojolicious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at https://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.

Re: [Mojolicious] Re: Looking for volunteers

[sri]

>
> Issue #70: Refresh history graph every 10 minutes 
> 
>
> But this is probably pretty pointless due to Issue #69: Switch from 
> epoch.js to something more modern
>
 
Not at all, the overlap should actually be fairly minimal. And i would 
expect issue #70 to be done before
issue #69. We know exactly what we want from issue #70, it's very straight 
forward.

--
sebastian

-- 
You received this message because you are subscribed to the Google Groups 
"Mojolicious" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojolicious+unsubscr...@googlegroups.com.
To post to this group, send email to mojolicious@googlegroups.com.
Visit this group at https://groups.google.com/group/mojolicious.
For more options, visit https://groups.google.com/d/optout.